Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103353568
--- Diff: src/cppcache/src/LRUList.hpp ---
@@ -20,32 +20,32 @@
* limitations under the License.
*/
+#include <atomic>
+
#include <geode/geode_globals.hpp>
#include <geode/SharedPtr.hpp>
-#include "SpinLock.hpp"
+
+#include "util/concurrent/spinlock_mutex.hpp"
namespace apache {
namespace geode {
namespace client {
+
// Bit mask for recently used
-#define RECENTLY_USED_BITS 1ul
+#define RECENTLY_USED_BITS 1u
// Bit mask for evicted
-#define EVICTED_BITS 2ul
+#define EVICTED_BITS 2u
--- End diff --
They are macros, but they could be converted to `const` in anonymous
namespace or even in this namespace or `constexpr` on the class itself. I will
look at what that looks like and maybe update it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
