This is an automated email from the ASF dual-hosted git repository.
jbarrett pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode-native.git
The following commit(s) were added to refs/heads/develop by this push:
new a2e1f10 GEODE-3453: Fix native
This is an automated email from the ASF dual-hosted git repository.
jbarrett pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode-native.git
The following commit(s) were added to refs/heads/develop by this push:
new 0fba5ce GEODE-3455: Update Solaris
This is an automated email from the ASF dual-hosted git repository.
jbarrett pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode-native.git
The following commit(s) were added to refs/heads/develop by this push:
new 8e4fd71 GEODE-3457: Linking fails on
This is an automated email from the ASF dual-hosted git repository.
jbarrett pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode-native.git
The following commit(s) were added to refs/heads/develop by this push:
new cc6dafe GEODE-3497: Fix failing test
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/95#discussion_r115007123
--- Diff: README.md ---
@@ -24,3 +24,33 @@ Native Client applications can be written in these
client technologies:
* [C++](https
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/95#discussion_r115026056
--- Diff: README.md ---
@@ -24,3 +24,33 @@ Native Client applications can be written in these
client technologies:
* [C++](https
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/95
@masaki-yamakawa For future reference, please rebase your branch before
pull requests and include the `GEODE-XX: ` prefix in your first line commit
statement.
---
If your project is
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/99
GEODE-2741: Remove custom shared painter and replace with std::shared_ptr.
Tests pass on Linux, Windows, Solaris and Mac.
Please review.
You can merge this pull request into
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/102#discussion_r121248442
--- Diff: src/CMakeLists.txt ---
@@ -17,6 +17,15 @@ project(nativeclient)
list(APPEND CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/103
GEODE-2525: Removes MersenneTwister sources.
Can I get a quick review before I merge.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/103#discussion_r123866557
--- Diff: src/tests/cpp/fwklib/GsRandom.cpp ---
@@ -18,60 +18,16 @@
#include "GsRandom.hpp"
#include
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/104
It looks like your reverts were to undo changes to .gitignore. I'd suggest
not building from within the source tree at all. If you do there is an ignore
already for "build
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/104
Please open a JIRA and include it in your commit message.
GEODE-1234: blah blah
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/105#discussion_r125184959
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -171,7 +173,8 @@ class CPPCACHE_EXPORT TcrMessage {
GET_DURABLE_CQS_DATA_ERROR = 106
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/105#discussion_r125184965
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -44,6 +44,8 @@
#include
#include
+//
--- End diff --
Clean
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/105#discussion_r125184798
--- Diff: src/cppcache/src/TcrConnection.cpp ---
@@ -318,7 +318,9 @@ bool TcrConnection::InitTcrConnection(
LOGFINE("Attem
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/105#discussion_r125184917
--- Diff: src/cppcache/src/TcrConnection.cpp ---
@@ -703,15 +717,21 @@ inline ConnErrType TcrConnection::sendData(uint32_t&
timeS
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/105#discussion_r125184790
--- Diff: src/cppcache/src/TcrConnection.cpp ---
@@ -318,7 +318,9 @@ bool TcrConnection::InitTcrConnection(
LOGFINE("Attem
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/105
> I suggest to fix the issue by defining handshake pseudo message within
the range probably defined for such pseudo messages by original design i.e.:
> typede
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/105
@gregt5259 please close this pull request since you opened #106.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/106
@echobravopapa the branching scheme only applies to committers working
directly with the Geode repositories. Non-committers use pull requests which
render the branching/girflow
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/106
@gregt5259 This is a solution to the problem but not the solution we as
committers are comfortable committing as it directly conflicts with the correct
change, which is to use type
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/108#discussion_r126114295
--- Diff: docs/geode-native-docs/introduction/quickstart.html.md.erb ---
@@ -53,7 +53,7 @@ for the latest Java version for your operating
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/108#discussion_r126114552
--- Diff: docs/geode-native-docs/security/sslclientserver.html.md.erb ---
@@ -27,7 +27,7 @@ The open-source OpenSSL toolkit provides a full
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/108#discussion_r126113664
--- Diff:
docs/geode-native-docs/introduction/client-configurations.html.md.erb ---
@@ -157,7 +157,7 @@ The following libraries are external
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/108#discussion_r126114762
--- Diff: docs/geode-native-docs/security/sslclientserver.html.md.erb ---
@@ -42,17 +42,17 @@ To install OpenSSL:
2. Extract the archive
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r126115701
--- Diff: src/cppcache/include/geode/Struct.hpp ---
@@ -138,7 +138,7 @@ class CPPCACHE_EXPORT Struct : public Serializable {
* Returns
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r126116586
--- Diff: src/cppcache/integration-test/testThinClientRemoteQuerySS.cpp ---
@@ -56,59 +57,63 @@ const wchar_t* checkNullString(const wchar_t
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/102
@mhansonp please follow up or close this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/110#discussion_r126254216
--- Diff:
docs/geode-native-docs/introduction/client-configurations.html.md.erb ---
@@ -157,7 +157,7 @@ The following libraries are external
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/110#discussion_r126254300
--- Diff:
docs/geode-native-docs/introduction/client-configurations.html.md.erb ---
@@ -157,7 +157,7 @@ The following libraries are external
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/102
@mhansonp you have conflicts, can you rebase and force push.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r126792435
--- Diff: src/cppcache/src/Struct.cpp ---
@@ -96,16 +99,16 @@ Serializable* Struct::fromData(DataInput& input) {
return
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r126792525
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -78,13 +78,11 @@ int32_t StructSetImpl::getFieldIndex(const char*
fieldname
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r127278631
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -78,13 +78,12 @@ int32_t StructSetImpl::getFieldIndex(const char*
fieldname
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r127278443
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -66,8 +66,8 @@ SelectResultsIterator StructSetImpl::getIterator() {
return
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r127278256
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -66,8 +66,8 @@ SelectResultsIterator StructSetImpl::getIterator() {
return
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r127312259
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -78,13 +78,12 @@ int32_t StructSetImpl::getFieldIndex(const char*
fieldname
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/111
Just a test PR
Please ignore this while we test PR CI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pivotal-jbarrett/geode
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/114
Please fix up commit messages
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/115
GEODE-3165: Reogranized sources relative to the root for better CMake
⦠IDE integration.
- Moved src/docs to docs/api.
- Moved src/* to root.
- Fixup paths in CMake
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/115#discussion_r132755738
--- Diff: CMakeLists.txt ---
@@ -242,7 +242,7 @@ add_subdirectory(dhimpl)
add_subdirectory(sqliteimpl)
add_subdirectory(tests
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/115
@dgkimura which CMake find modules are you referring to?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/115#discussion_r132769880
--- Diff: CMakeLists.txt ---
@@ -242,7 +242,7 @@ add_subdirectory(dhimpl)
add_subdirectory(sqliteimpl)
add_subdirectory(tests
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/115
@dgkimura Those files actually need to be redone in a way more closely
aligned with other CMake find modules. I would leave them alone for now and fix
later.
---
If your project is
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/115
@dgkimura https://issues.apache.org/jira/browse/GEODE-3432
Anything else you don't like?
---
If your project is set up for it, you can reply to this email and have your
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/114
This was merged without auto-close comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/116
GEODE-3439: Split ThinClientRegionInterestTestsN into mulitple tests â¦
â¦to avoid random failures.
You can merge this pull request into a Git repository by running:
$ git
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/387
The convention in this pull request is not consistent with the Google C++
Style Guide.
https://google.github.io/styleguide/cppguide.html#The__define_Guard
---
If your project is
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/6
Why not use regex_replace in C++11
http://en.cppreference.com/w/cpp/regex/regex_replace?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100877742
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const
xmlChar** atts
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100878314
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1170,7 +1170,7 @@ class TcrMessageHelper {
}
if (compId != expectedPartType
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100878727
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1170,7 +1170,7 @@ class TcrMessageHelper {
}
if (compId != expectedPartType
Github user pivotal-jbarrett closed the pull request at:
https://github.com/apache/geode/pull/377
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/9
[GEODE-2408] Refactor CacheableDate with C++11 standards.
Moved from old repo to new repo. Can I get a thumbs up please?
You can merge this pull request into a Git repository by
Github user pivotal-jbarrett closed the pull request at:
https://github.com/apache/geode/pull/385
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/385
Moved to https://github.com/apache/geode-native/pull/9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100912867
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1170,7 +1170,7 @@ class TcrMessageHelper {
}
if (compId != expectedPartType
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100913452
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const
xmlChar** atts
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100942381
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const
xmlChar** atts
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/6#discussion_r100956921
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1382,6 +1377,31 @@ void
CacheHelper::createDuplicateXMLFile(std::string
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/6#discussion_r100956809
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1382,6 +1377,31 @@ void
CacheHelper::createDuplicateXMLFile(std::string
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/6#discussion_r100957079
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1382,6 +1377,31 @@ void
CacheHelper::createDuplicateXMLFile(std::string
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/7#discussion_r100958307
--- Diff: src/dependencies/xerces-c/CMakeLists.txt ---
@@ -32,10 +32,10 @@ if (WIN32)
set( _BUILD_DIR Build/Win32/VC${MSVC_VERSION
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/7#discussion_r100958376
--- Diff: src/dependencies/xerces-c/CMakeLists.txt ---
@@ -32,10 +32,10 @@ if (WIN32)
set( _BUILD_DIR Build/Win32/VC${MSVC_VERSION
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/11
GEODE-2486: Initialize OpenSSL for DEFAULT cipher support.
- Init SSLv23_client mode to support negotiation of all SSL/TLS
versions.
- Cleanup C++ style issues.
- Update
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/15#discussion_r101610701
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1114,10 +1116,10 @@ class TcrMessageHelper {
} else if (!isObj
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/12#discussion_r101658884
--- Diff: .ratignore ---
@@ -23,10 +23,12 @@
# expect script
.*changepasswd$
+.*winrm.cloud-init$
# doxygen
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/13#discussion_r101659693
--- Diff: src/cppcache/include/geode/AttributesFactory.hpp ---
@@ -20,7 +20,7 @@
* limitations under the License
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/13#discussion_r101659601
--- Diff: src/cppcache/include/geode/AttributesFactory.hpp ---
@@ -1,7 +1,7 @@
#pragma once
-#ifndef
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/13#discussion_r101659366
--- Diff: src/CMakeLists.txt ---
@@ -224,7 +222,7 @@ add_subdirectory(cppcache)
add_subdirectory(cryptoimpl)
add_subdirectory(dhimpl
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/15#discussion_r101662122
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1113,12 +1117,11 @@ class TcrMessageHelper {
return NULL_OBJECT;
} else
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/12#discussion_r101671763
--- Diff: .ratignore ---
@@ -23,10 +23,12 @@
# expect script
.*changepasswd$
+.*winrm.cloud-init$
# doxygen
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/13#discussion_r101824812
--- Diff: src/CMakeLists.txt ---
@@ -224,7 +222,7 @@ add_subdirectory(cppcache)
add_subdirectory(cryptoimpl)
add_subdirectory(dhimpl
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/13#discussion_r101825168
--- Diff: src/cppcache/include/geode/AttributesFactory.hpp ---
@@ -1,7 +1,7 @@
#pragma once
-#ifndef
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/19#discussion_r102271148
--- Diff: src/cppcache/integration-test/CMakeLists.txt ---
@@ -21,7 +21,7 @@ target_link_libraries(${TEST_UTILS_LIB}
PRIVATE
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/24
@PivotalSarge yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/24#discussion_r102517638
--- Diff: src/cppcache/src/CMakeLists.txt ---
@@ -125,7 +125,7 @@ target_include_directories(apache-geode
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/17
Please close this pull request and resubmit when you have cleaned up all
the places that use hashcode.
---
If your project is set up for it, you can reply to this email and have your
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/25#discussion_r102736948
--- Diff: src/xsds/gfcpp-cache-9.0.xsd ---
@@ -33,7 +33,7 @@ limitations under the License.
version="9.0">
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102739212
--- Diff: src/clicache/src/CacheableDate.cpp ---
@@ -90,7 +90,7 @@ namespace Apache
TimeSpan epochSpan = m_dateTime - EpochTime
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102745344
--- Diff: src/cppcache/src/statistics/HostStatHelperSolaris.cpp ---
@@ -86,23 +86,23 @@ void
HostStatHelperSolaris::refreshProcess
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102742460
--- Diff:
src/cppcache/integration-test/testThinClientFixedPartitionResolver.cpp ---
@@ -245,7 +245,7 @@ DUNIT_TASK_DEFINITION(CLIENT1
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102743540
--- Diff: src/cppcache/src/CacheImpl.cpp ---
@@ -185,8 +185,8 @@ bool CacheImpl::getAndResetNetworkHopFlag() {
return networkhop
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102744883
--- Diff: src/cppcache/src/statistics/GeodeStatisticsFactory.hpp ---
@@ -98,50 +98,50 @@ class GeodeStatisticsFactory : public
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102738544
--- Diff: src/clicache/src/CacheableDate.cpp ---
@@ -90,7 +90,7 @@ namespace Apache
TimeSpan epochSpan = m_dateTime - EpochTime
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102743673
--- Diff: src/cppcache/src/CqServiceVsdStats.hpp ---
@@ -108,7 +108,7 @@ class CPPCACHE_EXPORT CqServiceVsdStats : public
CqServiceStatistics
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102739037
--- Diff: src/clicache/src/CacheableDate.cpp ---
@@ -90,7 +90,7 @@ namespace Apache
TimeSpan epochSpan = m_dateTime - EpochTime
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102747392
--- Diff: src/cppcache/src/statistics/StatisticDescriptorImpl.cpp ---
@@ -41,8 +41,8 @@ StatisticDescriptorImpl::StatisticDescriptorImpl(const
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102743360
--- Diff: src/cppcache/src/BucketServerLocation.hpp ---
@@ -130,7 +130,7 @@ class BucketServerLocation : public ServerLocation
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102746696
--- Diff: src/cppcache/src/statistics/HostStatHelperWin.cpp ---
@@ -535,21 +535,21 @@ uint32
HostStatHelperWin::getInt32Value
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102742228
--- Diff: src/cppcache/include/geode/statistics/StatisticsFactory.hpp ---
@@ -96,7 +96,7 @@ class CPPCACHE_EXPORT StatisticsFactory
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102739522
--- Diff: src/cppcache/include/geode/geode_base.hpp ---
@@ -69,32 +69,9 @@
#define GF_TEMPLATE_EXPORT
#endif
-#if defined
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r10278
--- Diff: src/cppcache/src/RegionStats.hpp ---
@@ -129,7 +129,7 @@ class CPPCACHE_EXPORT RegionStats {
class RegionStatType
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/28#discussion_r102749040
--- Diff: src/cppcache/src/ClientMetadata.cpp ---
@@ -344,7 +344,7 @@ int ClientMetadata::assignFixedBucketId(const char*
partitionName
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102789698
--- Diff: src/clicache/src/CacheableDate.cpp ---
@@ -90,7 +90,7 @@ namespace Apache
TimeSpan epochSpan = m_dateTime - EpochTime
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/30
Does this change create the xml files in each of the individual integration
test's runtime directory of the root of the all the tests?
---
If your project is set up for it, yo
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102813470
--- Diff: src/cppcache/src/RegionStats.hpp ---
@@ -129,7 +129,7 @@ class CPPCACHE_EXPORT RegionStats {
class RegionStatType
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102813688
--- Diff:
src/cppcache/integration-test/testThinClientFixedPartitionResolver.cpp ---
@@ -245,7 +245,7 @@ DUNIT_TASK_DEFINITION(CLIENT1
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/27
A rebase would have been preferable to a merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
1 - 100 of 209 matches
Mail list logo
