Github user pivotal-jbarrett commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/13#discussion_r101824812
  
    --- Diff: src/CMakeLists.txt ---
    @@ -224,7 +222,7 @@ add_subdirectory(cppcache)
     add_subdirectory(cryptoimpl)
     add_subdirectory(dhimpl)
     add_subdirectory(sqliteimpl)
    -add_subdirectory(gfcpp)
    +add_subdirectory(getversion)
    --- End diff --
    
    If they are relying on it then their scripts will break either way. There 
are better ways to get version. I don't think I have ever seen anyone anywhere 
use it. I don't even see it in our documents. I say kill it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to