Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/24#discussion_r102517638
--- Diff: src/cppcache/src/CMakeLists.txt ---
@@ -125,7 +125,7 @@ target_include_directories(apache-geode
$<TARGET_PROPERTY:_apache-geode,INTERFACE_INCLUDE_DIRECTORIES>
)
add_dependencies(client-libraries apache-geode)
-set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER
"${PUBLIC_HEADERS}")
+set_target_properties(apache-geode PROPERTIES PUBLIC_HEADER
"${PUBLIC_HEADERS}" OUTPUT_NAME ${PRODUCT_LIB_NAME} )
--- End diff --
I would only suggest avoiding long lines in the CMake files by putting each
property on a new line.
```
set_target_properties(apache-geode PROPERTIES
PUBLIC_HEADER "${PUBLIC_HEADERS}"
OUTPUT_NAME ${PRODUCT_LIB_NAME})
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
