Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102747392
--- Diff: src/cppcache/src/statistics/StatisticDescriptorImpl.cpp ---
@@ -41,8 +41,8 @@ StatisticDescriptorImpl::StatisticDescriptorImpl(const
char* statName,
FieldType
statDescriptorType,
const char*
statDescription,
const char* statUnit,
- int8 statIsStatCounter,
- int8
statIsStatLargerBetter) {
+ int8_t statIsStatCounter,
--- End diff --
`bool`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---