Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100913452
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const
xmlChar** atts) {
throw CacheXmlException(s.c_str());
}
- ACE_OS::strncpy(libraryFunctionName, (char*)atts[i], len);
+ std::strncpy(libraryFunctionName, (char*)atts[i], len);
--- End diff --
I am of the camp that believes that large efforts like that are rarely
undertaken unless there is an easy tool to do the work for you. The clang-tidy
rule fixed some when we did the initial reformat and cleanup to Google C++
Style Guide. There were some it was unable to do automagically, my guess
because they were ambiguous. I would make an effort that any file you edit
should compile clean, no warnings and no static analyzer warnings/errors. You
can enable clang-tidy by passing CLANG_TIDY_ENABLED=ON to CMake.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
