Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

2017-04-20 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/#review172485 --- geode-core/src/test/java/org/apache/geode/test/dunit/rules/Locato

Re: Review Request 58544: GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl

2017-04-20 Thread Galen O'Sullivan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58544/#review172501 --- Ship it! This is awesome. Using an interface rather than castin

[jira] [Resolved] (GEODE-728) Rename Execution.withArgs to Execution.setArguments

2017-04-20 Thread Dan Smith (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Smith resolved GEODE-728. - Resolution: Fixed Fix Version/s: 1.2.0 I merged the changes from [~dalyssakim] for this issue. I thi

[jira] [Resolved] (GEODE-2653) GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError

2017-04-20 Thread Udo Kohlmeyer (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udo Kohlmeyer resolved GEODE-2653. -- Resolution: Fixed Fix Version/s: 1.2.0 > GMSJoinLeaveJUnitTest.testRemoveMember fails wit

[jira] [Created] (GEODE-2803) mark testThinClientPoolExecuteFunction FLAKY

2017-04-20 Thread Ernest Burghardt (JIRA)
Ernest Burghardt created GEODE-2803: --- Summary: mark testThinClientPoolExecuteFunction FLAKY Key: GEODE-2803 URL: https://issues.apache.org/jira/browse/GEODE-2803 Project: Geode Issue Type:

Build failed in Jenkins: Geode-nightly #813

2017-04-20 Thread Apache Jenkins Server
See Changes: [kmiller] GEODE-2103 Update gfsh start server|locator command reference page. [klund] GEODE-2632: refactor code to use interfaces instead of impls [kmiller] GEODE-2103 Revise http-service-port defn per

Re: Review Request 58550: AEQ regions being created before the user regions

2017-04-20 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58550/#review172513 --- I think the main thrust of this change looks good - get the AEQ cr

[jira] [Created] (GEODE-2804) Allow a locator host to be taken off line and replaced with a different machine having the same host name

2017-04-20 Thread Bruce Schuchardt (JIRA)
Bruce Schuchardt created GEODE-2804: --- Summary: Allow a locator host to be taken off line and replaced with a different machine having the same host name Key: GEODE-2804 URL: https://issues.apache.org/jira/browse

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

2017-04-20 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/#review172523 --- Ship it! Ship It! - Kirk Lund On April 19, 2017, 11:22 p.m.,

Review Request 58582: GEODE-2632: 1st pass cleaning up GemFireCacheImpl

2017-04-20 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58582/ --- Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, and Ken

[jira] [Commented] (GEODE-728) Rename Execution.withArgs to Execution.setArguments

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977141#comment-15977141 ] ASF subversion and git services commented on GEODE-728: --- Commit 5891e

Re: Review Request 58582: GEODE-2632: 1st pass cleaning up GemFireCacheImpl

2017-04-20 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58582/ --- (Updated April 20, 2017, 6:01 p.m.) Review request for geode, Darrel Schneider,

[jira] [Commented] (GEODE-2632) Integrated Security performance improvements

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977168#comment-15977168 ] ASF GitHub Bot commented on GEODE-2632: --- Github user kirklund commented on a diff in

[GitHub] geode pull request #450: GEODE-2632: create ClientCachePutBench

2017-04-20 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/450#discussion_r112522440 --- Diff: geode-core/src/jmh/java/org/apache/geode/internal/cache/tier/sockets/command/ClientCachePutBench.java --- @@ -0,0 +1,233 @@ +/* + * Licens

[GitHub] geode issue #450: GEODE-2632: create ClientCachePutBench

2017-04-20 Thread kirklund
Github user kirklund commented on the issue: https://github.com/apache/geode/pull/450 @galen-pivotal I don't know enough about "DuplicatesStrategy.WARN" but it gets printed because JMH is pulling in all dependencies from all geode modules and the way we have our gradle build setup, th

[jira] [Commented] (GEODE-2632) Integrated Security performance improvements

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977172#comment-15977172 ] ASF GitHub Bot commented on GEODE-2632: --- Github user kirklund commented on the issue

[GitHub] geode issue #450: GEODE-2632: create ClientCachePutBench

2017-04-20 Thread metatype
Github user metatype commented on the issue: https://github.com/apache/geode/pull/450 @upthewaterspout thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[jira] [Commented] (GEODE-2632) Integrated Security performance improvements

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977183#comment-15977183 ] ASF GitHub Bot commented on GEODE-2632: --- Github user metatype commented on the issue

[jira] [Updated] (GEODE-2804) Allow a locator host to be taken off line and replaced with a different machine having the same host name

2017-04-20 Thread Bruce Schuchardt (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Schuchardt updated GEODE-2804: Affects Version/s: 1.1.1 > Allow a locator host to be taken off line and replaced with a dif

Re: Review Request 58541: GEODE-576 & GEODE-516 Flaky test: GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction

2017-04-20 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58541/#review172534 --- Ship it! Ship It! - Hitesh Khamesra On April 19, 2017, 8:27

Re: Review Request 58520: GEODE-2799: suspend the transaction when creating iterator if necessary

2017-04-20 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58520/ --- (Updated April 20, 2017, 6:33 p.m.) Review request for geode, anilkumar gingade

[jira] [Updated] (GEODE-1561) CI Failure: GemfireDataCommandsDUnitTest.testSimulateForEntireDS assertion failure

2017-04-20 Thread Bruce Schuchardt (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Schuchardt updated GEODE-1561: Component/s: (was: rest (dev)) rest (admin) > CI Failure: GemfireDataC

Review Request 58586: GEODE-2801: change krfIds to be thread safe

2017-04-20 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58586/ --- Review request for geode, anilkumar gingade, Eric Shu, and Lynn Gallinat. Bugs:

[jira] [Created] (GEODE-2805) disk store backup may not include krf files for the oplogs it backs up

2017-04-20 Thread Darrel Schneider (JIRA)
Darrel Schneider created GEODE-2805: --- Summary: disk store backup may not include krf files for the oplogs it backs up Key: GEODE-2805 URL: https://issues.apache.org/jira/browse/GEODE-2805 Project: G

[GitHub] geode pull request #463: GEODE-236: Removed deprecated CacheEvent methods

2017-04-20 Thread davinash
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/463 GEODE-236: Removed deprecated CacheEvent methods Removed deprecated CacheEvent methods You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/g

[jira] [Commented] (GEODE-236) Remove deprecated CacheEvent methods

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977278#comment-15977278 ] ASF GitHub Bot commented on GEODE-236: -- GitHub user davinash opened a pull request:

[GitHub] geode pull request #464: GEODE-237: Removed deprecated API from EntryEvent

2017-04-20 Thread davinash
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/464 GEODE-237: Removed deprecated API from EntryEvent Removed deprecated CacheEvent methods You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/

[GitHub] geode pull request #465: GEODE-253: Removed depreated and not used EntryNotF...

2017-04-20 Thread davinash
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/465 GEODE-253: Removed depreated and not used EntryNotFoundInRegion class Removed depreated and not used EntryNotFoundInRegion class You can merge this pull request into a Git repository by running:

[jira] [Commented] (GEODE-237) Remove EntryEvent deprecated methods

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977281#comment-15977281 ] ASF GitHub Bot commented on GEODE-237: -- GitHub user davinash opened a pull request:

[GitHub] geode pull request #466: GEODE-255: Removed deprecated DataSerializer.regist...

2017-04-20 Thread davinash
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/466 GEODE-255: Removed deprecated DataSerializer.register(Class,byte) Removed deprecated DataSerializer.register(Class,byte) You can merge this pull request into a Git repository by running: $ git

[jira] [Commented] (GEODE-253) Remove deprecated EntryNotFoundInRegion

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977284#comment-15977284 ] ASF GitHub Bot commented on GEODE-253: -- GitHub user davinash opened a pull request:

[jira] [Commented] (GEODE-255) Remove deprecated DataSerializer.register(Class,byte)

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977285#comment-15977285 ] ASF GitHub Bot commented on GEODE-255: -- GitHub user davinash opened a pull request:

[GitHub] geode pull request #467: GEODE-258: Remove deprecated Cache.getLoggerI18n an...

2017-04-20 Thread davinash
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/467 GEODE-258: Remove deprecated Cache.getLoggerI18n and getSecurityLoggerI18n methods You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/g

[jira] [Commented] (GEODE-258) Remove deprecated Cache.getLoggerI18n and getSecurityLoggerI18n methods

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977289#comment-15977289 ] ASF GitHub Bot commented on GEODE-258: -- GitHub user davinash opened a pull request:

[GitHub] geode pull request #468: GEODE-260: Remove deprecated RemoteTransactionExcep...

2017-04-20 Thread davinash
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/468 GEODE-260: Remove deprecated RemoteTransactionException You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-260 Altern

[jira] [Commented] (GEODE-260) Remove deprecated RemoteTransactionException

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977291#comment-15977291 ] ASF GitHub Bot commented on GEODE-260: -- GitHub user davinash opened a pull request:

[GitHub] geode pull request #469: GEODE-266: Remove the deprecated ObjectSizerImpl cl...

2017-04-20 Thread davinash
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/469 GEODE-266: Remove the deprecated ObjectSizerImpl class You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-266 Alterna

[jira] [Commented] (GEODE-266) Remove deprecated ObjectSizerImpl

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977293#comment-15977293 ] ASF GitHub Bot commented on GEODE-266: -- GitHub user davinash opened a pull request:

[GitHub] geode pull request #470: GEODE-267: Remove deprecated ThreadInterruptedExcep...

2017-04-20 Thread davinash
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/470 GEODE-267: Remove deprecated ThreadInterruptedException You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-267 Altern

[jira] [Commented] (GEODE-267) Remove deprecated ThreadInterruptedException

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977296#comment-15977296 ] ASF GitHub Bot commented on GEODE-267: -- GitHub user davinash opened a pull request:

[GitHub] geode pull request #471: GEODE-289: Remove depcreated LicenseException class

2017-04-20 Thread davinash
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/471 GEODE-289: Remove depcreated LicenseException class You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-289 Alternativ

[jira] [Commented] (GEODE-289) Remove deprecated LicenseException

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977298#comment-15977298 ] ASF GitHub Bot commented on GEODE-289: -- GitHub user davinash opened a pull request:

Re: Review Request 58586: GEODE-2801: change krfIds to be thread safe

2017-04-20 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58586/#review172538 --- Ship it! Ship It! - anilkumar gingade On April 20, 2017, 6:4

[GitHub] geode issue #456: GEODE-72 : Remove deprecated APIs from Geode

2017-04-20 Thread davinash
Github user davinash commented on the issue: https://github.com/apache/geode/pull/456 closing this PR, as I have opened separate PR for each subtask. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] geode pull request #456: GEODE-72 : Remove deprecated APIs from Geode

2017-04-20 Thread davinash
Github user davinash closed the pull request at: https://github.com/apache/geode/pull/456 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Commented] (GEODE-72) Remove deprecated APIs from Geode

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977305#comment-15977305 ] ASF GitHub Bot commented on GEODE-72: - Github user davinash commented on the issue:

[jira] [Commented] (GEODE-72) Remove deprecated APIs from Geode

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977304#comment-15977304 ] ASF GitHub Bot commented on GEODE-72: - Github user davinash closed the pull request at:

Review Request 58589: GEODE-1597: use Spring shell's parser and delete our own parsing code

2017-04-20 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58589/ --- Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhombe

Refactor gfsh parser

2017-04-20 Thread Jinmei Liao
In the effort of adding option validation to gfsh commands (GEODE-1597) and simplifying gfsh parsing, I started this exercise of only using SpringShell's parser instead of a combination of springshell's, joptsimple's and our own parsers. The end result is a lot more manageable code base, and the c

Re: Refactor gfsh parser

2017-04-20 Thread Jens Deppe
IMO I much prefer having: --member=member1,member2 vs: --member=member1 --member=member2 The latter can leave me wondering if subsequent values are additive or actually override prior ones. --Jens On Thu, Apr 20, 2017 at 1:37 PM, Jinmei Liao wrote: > In the effort of adding option validati

[jira] [Created] (GEODE-2806) when batch is dispatched, if the bucket is not primary, we should still destroy the event from queue

2017-04-20 Thread xiaojian zhou (JIRA)
xiaojian zhou created GEODE-2806: Summary: when batch is dispatched, if the bucket is not primary, we should still destroy the event from queue Key: GEODE-2806 URL: https://issues.apache.org/jira/browse/GEODE-2806

[jira] [Assigned] (GEODE-2806) when batch is dispatched, if the bucket is not primary, we should still destroy the event from queue

2017-04-20 Thread xiaojian zhou (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaojian zhou reassigned GEODE-2806: Assignee: xiaojian zhou > when batch is dispatched, if the bucket is not primary, we should

Review Request 58594: even lost primary, dispatched batch should still be removed

2017-04-20 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58594/ --- Review request for geode and Jason Huynh. Bugs: GEODE-2806 https://issues.a

Re: Refactor gfsh parser

2017-04-20 Thread John Blum
+1, I agree with Jens; The option could be renamed to '--members' and mean 1 or more. On Thu, Apr 20, 2017 at 2:00 PM, Jens Deppe wrote: > IMO I much prefer having: > > --member=member1,member2 > > vs: > > --member=member1 --member=member2 > > The latter can leave me wondering if subsequent valu

[jira] [Commented] (GEODE-728) Rename Execution.withArgs to Execution.setArguments

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977555#comment-15977555 ] ASF subversion and git services commented on GEODE-728: --- Commit 5891e

Re: Review Request 58582: GEODE-2632: 1st pass cleaning up GemFireCacheImpl

2017-04-20 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58582/ --- (Updated April 20, 2017, 9:19 p.m.) Review request for geode, Darrel Schneider,

Re: Review Request 58544: GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl

2017-04-20 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58544/ --- (Updated April 20, 2017, 9:21 p.m.) Review request for geode, Jason Huynh, Jinm

[jira] [Commented] (GEODE-728) Rename Execution.withArgs to Execution.setArguments

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977562#comment-15977562 ] ASF subversion and git services commented on GEODE-728: --- Commit aaef1

[jira] [Commented] (GEODE-2796) NPE in ClassPathLoader

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977564#comment-15977564 ] ASF subversion and git services commented on GEODE-2796: Commit 48

[jira] [Commented] (GEODE-2681) Gfsh show missing-disk-stores command hangs when server is waiting for disk stores

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977560#comment-15977560 ] ASF subversion and git services commented on GEODE-2681: Commit ae

[jira] [Commented] (GEODE-728) Rename Execution.withArgs to Execution.setArguments

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977565#comment-15977565 ] ASF subversion and git services commented on GEODE-728: --- Commit 5891e

[jira] [Commented] (GEODE-510) Bug48571DUnitTest.testStatsMatchWithSize failed

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977561#comment-15977561 ] ASF subversion and git services commented on GEODE-510: --- Commit f038c

Re: Refactor gfsh parser

2017-04-20 Thread Michael Stolz
I see no issues with these changes. -- Mike Stolz Principal Engineer - Gemfire Product Manager Mobile: 631-835-4771 On Apr 20, 2017 4:38 PM, "Jinmei Liao" wrote: > In the effort of adding option validation to gfsh commands (GEODE-1597) and > simplifying gfsh parsing, I started this exercise of

Re: Refactor gfsh parser

2017-04-20 Thread Kirk Lund
These changes look great. Thanks! On Thu, Apr 20, 2017 at 1:37 PM, Jinmei Liao wrote: > In the effort of adding option validation to gfsh commands (GEODE-1597) and > simplifying gfsh parsing, I started this exercise of only using > SpringShell's parser instead of a combination of springshell's,

Re: Refactor gfsh parser

2017-04-20 Thread Swapnil Bawaskar
+1 On Thu, Apr 20, 2017 at 2:34 PM Kirk Lund wrote: > These changes look great. Thanks! > > On Thu, Apr 20, 2017 at 1:37 PM, Jinmei Liao wrote: > > > In the effort of adding option validation to gfsh commands (GEODE-1597) > and > > simplifying gfsh parsing, I started this exercise of only using

Re: Refactor gfsh parser

2017-04-20 Thread Bruce Schuchardt
+1 What other options like "member" exist that need to be modified? Le 4/20/2017 à 1:37 PM, Jinmei Liao a écrit : In the effort of adding option validation to gfsh commands (GEODE-1597) and simplifying gfsh parsing, I started this exercise of only using SpringShell's parser instead of a combinat

Re: Review Request 58582: GEODE-2632: 1st pass cleaning up GemFireCacheImpl

2017-04-20 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58582/ --- (Updated April 20, 2017, 9:49 p.m.) Review request for geode, Darrel Schneider,

[jira] [Closed] (GEODE-2290) Provide way to limit scanning of deployed jars

2017-04-20 Thread Swapnil Bawaskar (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Bawaskar closed GEODE-2290. --- > Provide way to limit scanning of deployed jars > --

[GitHub] geode issue #450: GEODE-2632: create ClientCachePutBench

2017-04-20 Thread upthewaterspout
Github user upthewaterspout commented on the issue: https://github.com/apache/geode/pull/450 Regarding putting JMH benchmarks in the core - seems fine. I think I originally made geode-benchmarks a separate project so it would be easy to share code and compare benchmarks between module

[jira] [Commented] (GEODE-2632) Integrated Security performance improvements

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977632#comment-15977632 ] ASF GitHub Bot commented on GEODE-2632: --- Github user upthewaterspout commented on th

[jira] [Assigned] (GEODE-1228) ClientAuthzObjectModDUnitTest.testAllOpsObjectModWithFailover

2017-04-20 Thread Bruce Schuchardt (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Schuchardt reassigned GEODE-1228: --- Assignee: Bruce Schuchardt (was: Udo Kohlmeyer) > ClientAuthzObjectModDUnitTest.test

Re: Refactor gfsh parser

2017-04-20 Thread Jinmei Liao
We should add option alias to to those options like "member(s)", "group(s)", "jar(s)", so that the command will accept either singular or plural. SpringShell parser does allow us to add option aliases. On Thu, Apr 20, 2017 at 2:40 PM, Bruce Schuchardt wrote: > +1 > What other options like "membe

[jira] [Commented] (GEODE-1228) ClientAuthzObjectModDUnitTest.testAllOpsObjectModWithFailover

2017-04-20 Thread Bruce Schuchardt (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977636#comment-15977636 ] Bruce Schuchardt commented on GEODE-1228: - I'll modify this test to use the locato

Review Request 58595: GEODE-2681: refactoring to prevent synchronization hang on getAnyInstance

2017-04-20 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58595/ --- Review request for geode, Jinmei Liao, Jared Stewart, Kirk Lund, and Patrick Rho

Re: Refactor gfsh parser

2017-04-20 Thread Jared Stewart
+1 for the suggested aliases > On Apr 20, 2017, at 3:02 PM, Jinmei Liao wrote: > > We should add option alias to to those options like "member(s)", > "group(s)", "jar(s)", so that the command will accept either singular or > plural. SpringShell parser does allow us to add option aliases. > > On

Re: Review Request 58541: GEODE-576 & GEODE-516 Flaky test: GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction

2017-04-20 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58541/#review172557 --- Ship it! Ship It! - Udo Kohlmeyer On April 19, 2017, 8:27 p.

[jira] [Commented] (GEODE-2653) GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977712#comment-15977712 ] ASF subversion and git services commented on GEODE-2653: Commit b1

[jira] [Commented] (GEODE-2605) Unable to do a Lucene query without CLUSTER:READ privilege

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977717#comment-15977717 ] ASF subversion and git services commented on GEODE-2605: Commit f6

[jira] [Commented] (GEODE-2796) NPE in ClassPathLoader

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977720#comment-15977720 ] ASF subversion and git services commented on GEODE-2796: Commit b8

[jira] [Commented] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977714#comment-15977714 ] ASF subversion and git services commented on GEODE-2103: Commit e9

[jira] [Commented] (GEODE-2632) Integrated Security performance improvements

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977715#comment-15977715 ] ASF subversion and git services commented on GEODE-2632: Commit 52

[jira] [Commented] (GEODE-728) Rename Execution.withArgs to Execution.setArguments

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977719#comment-15977719 ] ASF subversion and git services commented on GEODE-728: --- Commit 32613

[jira] [Commented] (GEODE-2681) Gfsh show missing-disk-stores command hangs when server is waiting for disk stores

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977722#comment-15977722 ] ASF subversion and git services commented on GEODE-2681: Commit fd

[jira] [Commented] (GEODE-510) Bug48571DUnitTest.testStatsMatchWithSize failed

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977718#comment-15977718 ] ASF subversion and git services commented on GEODE-510: --- Commit ed384

[jira] [Commented] (GEODE-2103) start locator command should include --http-service-port and --http-service-bind-address

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977716#comment-15977716 ] ASF subversion and git services commented on GEODE-2103: Commit a4

[jira] [Commented] (GEODE-728) Rename Execution.withArgs to Execution.setArguments

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977721#comment-15977721 ] ASF subversion and git services commented on GEODE-728: --- Commit 2d842

[jira] [Resolved] (GEODE-1274) Pulse logging does not appear in Geode log file.

2017-04-20 Thread Swapnil Bawaskar (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Bawaskar resolved GEODE-1274. - Resolution: Fixed > Pulse logging does not appear in Geode log file. > ---

[jira] [Commented] (GEODE-2681) Gfsh show missing-disk-stores command hangs when server is waiting for disk stores

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977731#comment-15977731 ] ASF subversion and git services commented on GEODE-2681: Commit 25

Re: Review Request 58595: GEODE-2681: refactoring to prevent synchronization hang on getAnyInstance

2017-04-20 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58595/ --- (Updated April 20, 2017, 10:41 p.m.) Review request for geode, Jinmei Liao, Jar

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #530 was SUCCESSFUL (with 1843 tests)

2017-04-20 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #530 was successful. --- Scheduled 1845 tests in total. https://build.spring.io/browse/SGF-NAG-530/ -- This

Re: Review Request 58594: even lost primary, dispatched batch should still be removed

2017-04-20 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58594/#review172561 --- Ship it! Maybe also have someone else review (maybe Barry) beca

[jira] [Commented] (GEODE-2681) Gfsh show missing-disk-stores command hangs when server is waiting for disk stores

2017-04-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977819#comment-15977819 ] ASF subversion and git services commented on GEODE-2681: Commit 7d

Re: Review Request 58594: even lost primary, dispatched batch should still be removed

2017-04-20 Thread Barry Oglesby
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58594/#review172566 --- Ship it! This looks ok. The only places that call ParallelGate

Review Request 58599: GEODE:2802 Tombstone version vector to contain only the members that generate the tombstone.

2017-04-20 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58599/ --- Review request for geode, Darrel Schneider, Eric Shu, and Lynn Gallinat. Reposi

[GitHub] geode-native issue #90: GEODE-2763: Remove of nonSingleHopsCount stat in cli...

2017-04-20 Thread ameybarve15
Github user ameybarve15 commented on the issue: https://github.com/apache/geode-native/pull/90 Hi @echobravopapa , and @PivotalSarge Thanks for your review. I am trying to merge my pull request but get this error. >~/source/open/t/geode-native (develop) $ git fetch ameyGitH

[jira] [Commented] (GEODE-2763) Remove of nonSingleHopsCount stat in client

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978082#comment-15978082 ] ASF GitHub Bot commented on GEODE-2763: --- Github user ameybarve15 commented on the is

[GitHub] geode-native issue #90: GEODE-2763: Remove of nonSingleHopsCount stat in cli...

2017-04-20 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode-native/pull/90 You shouldn't merge develop into your feature branch. You should rebase your feature branch on develop. This creates a much cleaner merge of the feature back into develop when approved.

[jira] [Commented] (GEODE-2763) Remove of nonSingleHopsCount stat in client

2017-04-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978113#comment-15978113 ] ASF GitHub Bot commented on GEODE-2763: --- Github user pivotal-jbarrett commented on t

Re: Review Request 58550: AEQ regions being created before the user regions

2017-04-20 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58550/#review172584 --- geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal

[jira] [Created] (GEODE-2807) Replace SharedPtr with std::shared_ptr

2017-04-20 Thread Jacob S. Barrett (JIRA)
Jacob S. Barrett created GEODE-2807: --- Summary: Replace SharedPtr with std::shared_ptr Key: GEODE-2807 URL: https://issues.apache.org/jira/browse/GEODE-2807 Project: Geode Issue Type: Improv

  1   2   >