[ 
https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977632#comment-15977632
 ] 

ASF GitHub Bot commented on GEODE-2632:
---------------------------------------

Github user upthewaterspout commented on the issue:

    https://github.com/apache/geode/pull/450
  
    Regarding putting JMH benchmarks in the core - seems fine. I think I 
originally made geode-benchmarks a separate project so it would be easy to 
share code and compare benchmarks between modules - eg comparing lucene to OQL 
queries. But putting the benchmarks in each module maybe makes more sense.
    
    This does seem to be somewhat stretching what JMH is designed for. JMH is 
targeted towards *microbenchmarks* so launching a separate server process seems 
a bit of a stretch. In particular, it's not clear to me here whether your 
server is getting restarted between benchmark iterations. JMH specifically 
tries to restart the JVM multiple times to deal with inconsistencies, but maybe 
only your client is getting restarted? In general I think we should probably be 
focusing on single VM, smaller unit benchmarks with JMH - benchmarking 
distributed systems might be better done with a different framework and 
multiple hosts.


> Integrated Security performance improvements
> --------------------------------------------
>
>                 Key: GEODE-2632
>                 URL: https://issues.apache.org/jira/browse/GEODE-2632
>             Project: Geode
>          Issue Type: Improvement
>          Components: security
>            Reporter: Jinmei Liao
>            Assignee: Kirk Lund
>              Labels: performance
>
> There is a security check in Put65.cmdExecute() that, if removed, improved 
> the performance.
> The expense of this security call needs to be reduced in order to get the 
> performance back.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to