-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58582/
-----------------------------------------------------------
(Updated April 20, 2017, 9:19 p.m.)
Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, and Ken
Howe.
Changes
-------
Fix compilation errors. I thought I did a full non-testing build before
submitting review (oops).
Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632
Repository: geode
Description
-------
GEODE-2632: 1st pass cleaning up GemFireCacheImpl
* remove dead-code
* add @Override annotations
* remove uselss javadocs and comments
* reduce scope of constants/vars/methods where possible
* fix misc IDE warnings
* remove unused imports (and reorg imports)
This turned out to be a big diff so I'm submitting a separate review just for
this cleanup.
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/cache/client/internal/ProxyCache.java
76306f51fc9479c7d9acaa28022ed908b674b7c0
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
56243e1b544f5958204e64c2ca391003aa1fd098
geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java
709308b57da847845ef9319bece18ebe9f25e569
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java
a5f0fc2bc7cf4250565aa8dd139004890b8da07d
geode-core/src/main/java/org/apache/geode/management/internal/beans/MemberMBeanBridge.java
d6a1efa73028e1b9514db67d2e3a4b564abee632
geode-core/src/test/java/org/apache/geode/TXJUnitTest.java
54d9e503f2645d045487cea51011143602764f62
geode-core/src/test/java/org/apache/geode/TXWriterTestCase.java
987f22f688ca695a8b37eacf239c69c329bb3b3b
geode-core/src/test/java/org/apache/geode/disttx/DistTXWriterJUnitTest.java
0a61b1f258d090090321c9ccff1a25781da7c8d1
geode-core/src/test/java/org/apache/geode/disttx/DistTXWriterOOMEJUnitTest.java
b99d3fd25cdac5f1862927d098d9d6381894510e
geode-core/src/test/java/org/apache/geode/internal/cache/PRTXJUnitTest.java
d2bad641a47f68edb22da0f89a04c462ab48cd33
Diff: https://reviews.apache.org/r/58582/diff/3/
Changes: https://reviews.apache.org/r/58582/diff/2-3/
Testing
-------
precheckin in progress
Thanks,
Kirk Lund
