----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58582/ -----------------------------------------------------------
Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, and Ken Howe. Bugs: GEODE-2632 https://issues.apache.org/jira/browse/GEODE-2632 Repository: geode Description ------- GEODE-2632: 1st pass cleaning up GemFireCacheImpl * remove dead-code * add @Override annotations * remove uselss javadocs and comments * reduce scope of constants/vars/methods where possible * fix misc IDE warnings * remove unused imports (and reorg imports) This turned out to be a big diff so I'm submitting a separate review just for this cleanup. Diffs ----- geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 56243e1b544f5958204e64c2ca391003aa1fd098 geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 709308b57da847845ef9319bece18ebe9f25e569 geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java a5f0fc2bc7cf4250565aa8dd139004890b8da07d Diff: https://reviews.apache.org/r/58582/diff/1/ Testing ------- precheckin in progress Thanks, Kirk Lund