-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58582/
-----------------------------------------------------------
(Updated April 20, 2017, 9:49 p.m.)
Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, and Ken
Howe.
Changes
-------
-1 somehow my changes broke BucketRegionQueue
Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632
Repository: geode
Description
-------
GEODE-2632: 1st pass cleaning up GemFireCacheImpl
* remove dead-code
* add @Override annotations
* remove uselss javadocs and comments
* reduce scope of constants/vars/methods where possible
* fix misc IDE warnings
* remove unused imports (and reorg imports)
This turned out to be a big diff so I'm submitting a separate review just for
this cleanup.
Diffs
-----
geode-core/src/main/java/org/apache/geode/cache/client/internal/ProxyCache.java
76306f51fc9479c7d9acaa28022ed908b674b7c0
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
56243e1b544f5958204e64c2ca391003aa1fd098
geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java
709308b57da847845ef9319bece18ebe9f25e569
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java
a5f0fc2bc7cf4250565aa8dd139004890b8da07d
geode-core/src/main/java/org/apache/geode/management/internal/beans/MemberMBeanBridge.java
d6a1efa73028e1b9514db67d2e3a4b564abee632
geode-core/src/test/java/org/apache/geode/TXJUnitTest.java
54d9e503f2645d045487cea51011143602764f62
geode-core/src/test/java/org/apache/geode/TXWriterTestCase.java
987f22f688ca695a8b37eacf239c69c329bb3b3b
geode-core/src/test/java/org/apache/geode/disttx/DistTXWriterJUnitTest.java
0a61b1f258d090090321c9ccff1a25781da7c8d1
geode-core/src/test/java/org/apache/geode/disttx/DistTXWriterOOMEJUnitTest.java
b99d3fd25cdac5f1862927d098d9d6381894510e
geode-core/src/test/java/org/apache/geode/internal/cache/PRTXJUnitTest.java
d2bad641a47f68edb22da0f89a04c462ab48cd33
Diff: https://reviews.apache.org/r/58582/diff/3/
Testing (updated)
-------
precheckin fails
These changes seem to cause failures elsewhere (BucketRegionQueue) in a way
that I can't seem to figure out. I think I'll have to scrap this change set and
start over with GemFireCacheImpl, running this test every few changes. This
collection seems to be at the root of the problem:
private final BlockingQueue<Object> eventSeqNumQueue = new
LinkedBlockingQueue<Object>();
The class declares it as <Object> but then casts it elsewhere to <EventID> and
then iterates over it and finds Long instead of EventID. The code on develop
does indeed put both EventID and Long in that Queue, but on my branch it seems
to leave a Long in the Queue which the code then blows up on during the
iterating.
java.lang.ClassCastException: java.lang.Long cannot be cast to
org.apache.geode.internal.cache.EventID
at
org.apache.geode.internal.cache.BucketRegionQueue.initializeEventSeqNumQueue(BucketRegionQueue.java:141)
at
org.apache.geode.internal.cache.BucketRegionQueue.cleanUpDestroyedTokensAndMarkGIIComplete(BucketRegionQueue.java:108)
at
org.apache.geode.internal.cache.BucketRegionQueueHelper.cleanUpDestroyedTokensAndMarkGIIComplete(BucketRegionQueueHelper.java:50)
at
org.apache.geode.internal.cache.wan.parallel.ParallelQueueRemovalMessageJUnitTest.validateDestroyKeyFromBucketQueueInUninitializedBucketRegionQueue(ParallelQueueRemovalMessageJUnitTest.java:175)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at
com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51)
at
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:237)
at
com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
Thanks,
Kirk Lund
