----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58586/#review172538 -----------------------------------------------------------
Ship it! Ship It! - anilkumar gingade On April 20, 2017, 6:44 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58586/ > ----------------------------------------------------------- > > (Updated April 20, 2017, 6:44 p.m.) > > > Review request for geode, anilkumar gingade, Eric Shu, and Lynn Gallinat. > > > Bugs: GEODE-2801 > https://issues.apache.org/jira/browse/GEODE-2801 > > > Repository: geode > > > Description > ------- > > Made this code theadsafe by changing krfIds to be a ConcurrentHashSet<Long> > instead of LongOpenHashSet. > Also added a unit test to do basic validation of krfIds. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/DiskInitFile.java > f6bf17f24ed2621731078d15bf59f1fd0326e3a9 > geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java > ca9468d503f5930fb20efa191335ba72d9b081ff > > geode-core/src/test/java/org/apache/geode/internal/cache/DiskInitFileJUnitTest.java > 6f2cf6c8f0088c29d2e38603e9e90fa1948294b2 > > > Diff: https://reviews.apache.org/r/58586/diff/1/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > >
