Re: [VOTE] C++ standardize on return values only

2017-10-03 Thread Hitesh Khamesra
Tuple option. Sent from Yahoo Mail on Android On Tue, Oct 3, 2017 at 4:27 PM, Jacob Barrett wrote: Voting on the conversation around C++ return values vs. out parameters. This vote is to adopt the standard of return values over the use of out parameters. On functions that must return more

Re: New client/server protocol - seeking feedback

2017-10-02 Thread Hitesh Khamesra
+1 On Monday, October 2, 2017, 11:14:55 AM PDT, Jacob Barrett wrote: A change to a message should just be a new message, no need to version it. Clients and severs could negotiate the messages they support or attempt the message they support and fallback to an alternative if the server r

Re: Review Request 62088: GEODE-3249 Validate internal client/server messages

2017-09-08 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62088/#review184986 --- Ship it! Ship It! - Hitesh Khamesra On Sept. 7, 2017, 5:43

Re: Review Request 62088: GEODE-3249 Validate internal client/server messages

2017-09-05 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62088/#review184565 --- Ship it! Ship It! - Hitesh Khamesra On Sept. 5, 2017, 5:57

Re: Review Request 61978: GEODE-3059: LoadMonitor.connectionClosed incrementing statistics only for client-server connection

2017-09-01 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61978/#review184391 --- Ship it! Ship It! - Hitesh Khamesra On Aug. 30, 2017, 8:48

Re: Review Request 61950: GEODE-3519 servers are not locking on remove or invalidate ops initiated by clients

2017-08-28 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61950/#review183950 --- Ship it! Ship It! - Hitesh Khamesra On Aug. 28, 2017, 4:09

Re: Review Request 61829: GEODE-3408 Flood of EOF warnings

2017-08-23 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61829/#review183634 --- Ship it! Ship It! - Hitesh Khamesra On Aug. 22, 2017, 11:41

Re: Review Request 61829: GEODE-3408 Flood of EOF warnings

2017-08-23 Thread Hitesh Khamesra
/sockets/GenericProtocolServerConnection.java Line 68 (original), 72 (patched) <https://reviews.apache.org/r/61829/#comment259684> Will this warning be printed every time when we close the socket? - Hitesh Khamesra On Aug. 22, 2017, 11:41 p.m., Bruce Schuchardt

Re: Review Request 61816: GEODE-3409 Protobuf Client Can't Connect Once Connection Limit Has Been Reached, Even After Connections Closed

2017-08-23 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61816/#review183615 --- Ship it! Ship It! - Hitesh Khamesra On Aug. 23, 2017, 3:47

Re: Review Request 61411: GEODE-3286 Failing to cleanup connections from ConnectionTable receiver table (corrected "stopped" check in previous fix)

2017-08-03 Thread Hitesh Khamesra
------ Thanks, Hitesh Khamesra

Review Request 61420: GEODE-3307 CI failure: Uncaught exception in thread Thread[Geode Membership View Creator

2017-08-03 Thread Hitesh Khamesra
rship/GMSJoinLeave.java 40a4254 Diff: https://reviews.apache.org/r/61420/diff/1/ Testing --- Thanks, Hitesh Khamesra

Review Request 61411: GEODE-3286 Failing to cleanup connections from ConnectionTable receiver table (corrected "stopped" check in previous fix)

2017-08-03 Thread Hitesh Khamesra
e/src/test/java/org/apache/geode/internal/tcp/ConnectionTableTest.java 312c64d Diff: https://reviews.apache.org/r/61411/diff/1/ Testing --- Thanks, Hitesh Khamesra

Re: [VOTE] Apache Geode release - v1.2.0 RC2

2017-07-14 Thread Hitesh Khamesra
+1 same as Dan!! On Wednesday, July 12, 2017, 1:38:44 PM PDT, Dan Smith wrote: +0 I ran geode-release-check against this project. It all looks good except that the md5sum and sha256 sums tasks don't pass because the .md5 and .sha256 file

Re: Review Request 60856: GEODE-3052 Need to reset isCoordinator flag in GMSLocator.

2017-07-14 Thread Hitesh Khamesra
automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60856/#review180497 --- On July 14, 2017, 5:06 p.m., Hitesh Khamesra wrote: > > --- > Thi

Re: Review Request 60856: GEODE-3052 Need to reset isCoordinator flag in GMSLocator.

2017-07-14 Thread Hitesh Khamesra
https://reviews.apache.org/r/60856/diff/1-2/ Testing --- Thanks, Hitesh Khamesra

Review Request 60856: GEODE-3052 Need to reset isCoordinator flag in GMSLocator.

2017-07-13 Thread Hitesh Khamesra
.java 9591673 geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java d8c12e2 Diff: https://reviews.apache.org/r/60856/diff/1/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure host as ip string.

2017-06-29 Thread Hitesh Khamesra
es 6a730a4 Diff: https://reviews.apache.org/r/60312/diff/3/ Testing --- File Attachments (updated) Latest diff https://reviews.apache.org/media/uploaded/files/2017/06/29/45369a6d-34d0-42dd-96bc-a1c009d00824__GEODE-2804v2.patch Thanks, Hitesh Khamesra

Re: Review Request 60550: GEODE-3154: add geode-protobuf to expected_jars.txt

2017-06-29 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60550/#review179309 --- Ship it! Ship It! - Hitesh Khamesra On June 29, 2017, 9:39

Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure host as ip string.

2017-06-28 Thread Hitesh Khamesra
dependency-versions.properties 6a730a4 Diff: https://reviews.apache.org/r/60312/diff/3/ Changes: https://reviews.apache.org/r/60312/diff/2-3/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 60507: GEODE-3145: add geode-protobuf code to the geode jar

2017-06-28 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60507/#review179135 --- Ship it! Ship It! - Hitesh Khamesra On June 28, 2017, 5:26

Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure host as ip string.

2017-06-27 Thread Hitesh Khamesra
a dbc2cc6 geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java 6d75064 gradle/dependency-versions.properties 6a730a4 Diff: https://reviews.apache.org/r/60312/diff/2/ Changes: https://reviews.apache.org/r/60312/diff/1-2/ Testing --- Thank

Re: Review Request 60451: GEODE-2996: adding Put handler

2017-06-27 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60451/#review179015 --- Ship it! Ship It! - Hitesh Khamesra On June 27, 2017, 1:20

New Apache commons-validato.jar

2017-06-27 Thread Hitesh Khamesra
We are planning to include Apache commons-validator_1.6.jar in Geode. As part of GEODE-2804, we need to validate whether host string is configured as IP or not. Please let us know if there is any issue with it. Thanks. Hitesh

Re: Review Request 60446: Events do not get removed from the client queue for 1.0 clients

2017-06-26 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60446/#review178936 --- Ship it! Ship It! - Hitesh Khamesra On June 26, 2017, 10:24

Re: Review Request 60442: GEODE-3130: Refactoring AcceptorImpl communication mode switch

2017-06-26 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60442/#review178916 --- Ship it! Ship It! - Hitesh Khamesra On June 26, 2017, 6:31

Re: Review Request 60394: GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.

2017-06-23 Thread Hitesh Khamesra
reviews.apache.org/r/60394/ > --- > > (Updated June 23, 2017, 5:52 p.m.) > > > Review request for geode, Alexander Murmann, Bruce Schuchardt, Hitesh > Khamesra, Udo Kohlmeyer, and Brian Rowe. > > > Repository: geode >

Re: Review Request 60106: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

2017-06-21 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60106/#review178617 --- Ship it! Ship It! - Hitesh Khamesra On June 21, 2017, 10:24

Re: Review Request 60106: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

2017-06-21 Thread Hitesh Khamesra
reviewboard. geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java (Diff revision 2) 235 if (v == null) { we are setting -1 viewid for recorded view while recovery. Thus do we need "usingRecoveredView" flag here? - Hites

Re: Review Request 60106: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

2017-06-21 Thread Hitesh Khamesra
/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java Line 79 (original), 79 (patched) <https://reviews.apache.org/r/60106/#comment252666> do we want fine level log here? - Hitesh Khamesra On June 21, 2017, 10:24 p.m.

Re: Review Request 60106: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

2017-06-21 Thread Hitesh Khamesra
/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java Line 79 (original), 79 (patched) <https://reviews.apache.org/r/60106/#comment252666> do we want fine level log here? - Hitesh Khamesra On June 21, 2017, 10:24 p.m.

Re: Review Request 60106: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

2017-06-21 Thread Hitesh Khamesra
/membership/gms/locator/GMSLocator.java Lines 235 (patched) <https://reviews.apache.org/r/60106/#comment252637> we are setting -1 viewid for recorded view while recovery. Thus do we need "usingRecoveredView" flag here? - Hitesh Khamesra On June 19, 2017, 4:09 p.m., Bruce

Review Request 60312: GEODE-2804 Cache InetAddress if configure host as ip string.

2017-06-21 Thread Hitesh Khamesra
/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java 6d75064 gradle/dependency-versions.properties 183dafc Diff: https://reviews.apache.org/r/60312/diff/1/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 60217: GEODE-2995: adding in protocol handler for protobuf messages

2017-06-21 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60217/#review178527 --- Ship it! Ship It! - Hitesh Khamesra On June 21, 2017, 7:01

Re: Review Request 60217: GEODE-2995: adding in protocol handler for protobuf messages

2017-06-21 Thread Hitesh Khamesra
0217/#comment252540> How about keeping two byte[] here. One for true and one for false. geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ByteCodec.java Lines 24 (patched) <https://reviews.apache.org/r/60217/#comment252541> Just return first byte? - Hitesh Kha

Re: Review Request 59894: GEODE-3041 CI failure: DistributedMemberDUnitTest.testGroupsInAllVMs fails intermittently

2017-06-08 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59894/#review177350 --- Ship it! Ship It! - Hitesh Khamesra On June 7, 2017, 9:56

Review Request 59924: Reverted GEODE-2804 (Allow a locator host to be taken off line and replaced with a different machine having the same host name)

2017-06-08 Thread Hitesh Khamesra
rg/apache/geode/management/internal/configuration/utils/ClusterConfigurationStatusRetriever.java 9f35edd geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 9ceb461 Diff: https://reviews.apache.org/r/59924/diff/1/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

2017-06-07 Thread Hitesh Khamesra
/apache/geode/distributed/internal/tcpserver/TcpServer.java Line 171 (original) <https://reviews.apache.org/r/59850/#comment250793> Is that code moved inside/will never happen? - Hitesh Khamesra On June 7, 2017, 11:32 p.m., Udo Kohlmeyer

Re: Review Request 59863: Removing obsolete SSL handling in `AcceptorImpl.accept` catch block

2017-06-07 Thread Hitesh Khamesra
/sockets/AcceptorImpl.java Line 1252 (original) <https://reviews.apache.org/r/59863/#comment250791> Do we need to move this code in another thread? - Hitesh Khamesra On June 6, 2017, 10:19 p.m., Brian Rowe wrote: > > ---

Re: Review Request 59757: GEODE-3024 race condition between server and restarted locator preparing membership views

2017-06-06 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59757/#review177093 --- Ship it! Ship It! - Hitesh Khamesra On June 2, 2017, 7:18

Re: Review Request 59819: GEODE-3034 java.lang.ArrayIndexOutOfBoundsException: 0 on auto-reconnect attempt with multicast enabled

2017-06-06 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59819/#review177091 --- Ship it! Ship It! - Hitesh Khamesra On June 5, 2017, 10:14

[jira] [Updated] (GEODE-2940) Remove verification of locator host on start

2017-06-01 Thread Hitesh Khamesra (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitesh Khamesra updated GEODE-2940: --- Description: We configure locator list to start the cache. This locator list is validated

[jira] [Issue Comment Deleted] (GEODE-3017) On windows, we don't choose right interface for IPv6

2017-06-01 Thread Hitesh Khamesra (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitesh Khamesra updated GEODE-3017: --- Comment: was deleted (was: It seems changes related to GEODE-2804 causing this issue. In that

[jira] [Updated] (GEODE-3017) On windows, we don't choose right interface for IPv6

2017-06-01 Thread Hitesh Khamesra (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitesh Khamesra updated GEODE-3017: --- Description: It seems changes related to GEODE-2804 causing this issue. In that change, we

[jira] [Commented] (GEODE-3017) On windows, we don't choose right interface for IPv6

2017-06-01 Thread Hitesh Khamesra (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033293#comment-16033293 ] Hitesh Khamesra commented on GEODE-3017: It seems changes related to GEODE-

[jira] [Created] (GEODE-3017) On windows, we don't choose right interface for IPv6

2017-06-01 Thread Hitesh Khamesra (JIRA)
Hitesh Khamesra created GEODE-3017: -- Summary: On windows, we don't choose right interface for IPv6 Key: GEODE-3017 URL: https://issues.apache.org/jira/browse/GEODE-3017 Project: Geode

Re: Review Request 59546: GEODE-2940 Remove verification of locator host on start

2017-05-25 Thread Hitesh Khamesra
JUnitTest.java Lines 346 (patched) <https://reviews.apache.org/r/59546/#comment249452> If locator host is still not avialable then server won't be able to join the cluster. - Hitesh Khamesra On May 25, 2017, 7:06 p.m., Hitesh Khamesra wrote: > >

Re: Review Request 59546: GEODE-2940 Remove verification of locator host on start

2017-05-25 Thread Hitesh Khamesra
org/r/59546/diff/1-2/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 59546: GEODE-2940 Remove verification of locator host on start

2017-05-25 Thread Hitesh Khamesra
lysis/excludedClasses.txt 9cff80d geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java d6d5d7c Diff: https://reviews.apache.org/r/59546/diff/1/ Testing --- Thanks, Hitesh Khamesra

Review Request 59546: GEODE-2940 Remove verification of locator host on start

2017-05-24 Thread Hitesh Khamesra
lysis/excludedClasses.txt 9cff80d geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java d6d5d7c Diff: https://reviews.apache.org/r/59546/diff/1/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 59422: GEODE-2954 Old client gets null memberID in cache listener

2017-05-24 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59422/#review175989 --- Ship it! Ship It! - Hitesh Khamesra On May 19, 2017, 10:48

[jira] [Updated] (GEODE-2983) gfsh doesn't return user friendly error message when java property has comma separated values

2017-05-24 Thread Hitesh Khamesra (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitesh Khamesra updated GEODE-2983: --- Description: Here is the gfsh command and output. It is telling "Error: Could not fi

[jira] [Created] (GEODE-2983) gfsh doesn't return user friendly error message when java property has comma separated values

2017-05-24 Thread Hitesh Khamesra (JIRA)
Hitesh Khamesra created GEODE-2983: -- Summary: gfsh doesn't return user friendly error message when java property has comma separated values Key: GEODE-2983 URL: https://issues.apache.org/jira/browse/GEODE

[jira] [Assigned] (GEODE-2804) Allow a locator host to be taken off line and replaced with a different machine having the same host name

2017-05-18 Thread Hitesh Khamesra (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitesh Khamesra reassigned GEODE-2804: -- Assignee: Hitesh Khamesra > Allow a locator host to be taken off line and repla

[jira] [Resolved] (GEODE-2804) Allow a locator host to be taken off line and replaced with a different machine having the same host name

2017-05-18 Thread Hitesh Khamesra (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitesh Khamesra resolved GEODE-2804. Resolution: Fixed > Allow a locator host to be taken off line and replaced with a differ

Re: Review Request 59242: GEODE-2915 Messages rejected due to unknown "vmkind"

2017-05-16 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59242/#review175149 --- Ship it! Ship It! - Hitesh Khamesra On May 15, 2017, 11:13

Re: Review Request 59239: Allow a locator host to be taken off line and replaced with a different machine having the same host name

2017-05-15 Thread Hitesh Khamesra
de I will change that. Thanks Bruce and Udo. - Hitesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59239/#review175022 ------- On May 15, 2017, 8:46 p.m., Hitesh Khamesra wrote: > > ---

Re: Review Request 59239: Allow a locator host to be taken off line and replaced with a different machine having the same host name

2017-05-15 Thread Hitesh Khamesra
f/2-3/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 59239: Allow a locator host to be taken off line and replaced with a different machine having the same host name

2017-05-15 Thread Hitesh Khamesra
ogic. - Hitesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59239/#review174980 --- On May 15, 2017, 6:33 p.m., Hitesh Khamesra wrote: > > --

Re: Review Request 59239: Allow a locator host to be taken off line and replaced with a different machine having the same host name

2017-05-15 Thread Hitesh Khamesra
ionSourceImplJUnitTest.java > > Lines 155 (patched) > > <https://reviews.apache.org/r/59239/diff/2/?file=1718525#file1718525line155> > > > > Is floc2 necessary? It just to test the logic. - Hitesh ---

Re: Review Request 58937: GEODE-2865 data loss in initial-image replication with multicast

2017-05-15 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58937/#review175012 --- Ship it! Ship It! - Hitesh Khamesra On May 5, 2017, 4:57

Re: Review Request 59242: GEODE-2915 Messages rejected due to unknown "vmkind"

2017-05-15 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59242/#review174998 --- Ship it! Ship It! - Hitesh Khamesra On May 12, 2017, 8:28

Re: Review Request 59239: Allow a locator host to be taken off line and replaced with a different machine having the same host name

2017-05-15 Thread Hitesh Khamesra
f/1-2/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 59239: Allow a locator host to be taken off line and replaced with a different machine having the same host name

2017-05-12 Thread Hitesh Khamesra
n automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59239/#review174861 --- On May 12, 2017, 7:01 p.m., Hitesh Khamesra wrote: > > --- > This is an a

Review Request 59239: Allow a locator host to be taken off line and replaced with a different machine having the same host name

2017-05-12 Thread Hitesh Khamesra
-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 385569c Diff: https://reviews.apache.org/r/59239/diff/1/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 59237: GEODE-2875 shutdown is taking as long as 20 seconds

2017-05-12 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59237/#review174831 --- Ship it! Ship It! - Hitesh Khamesra On May 12, 2017, 6:29

[jira] [Commented] (GEODE-2874) StringIndexOutOfBoundsException while initializing logger

2017-05-11 Thread Hitesh Khamesra (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007229#comment-16007229 ] Hitesh Khamesra commented on GEODE-2874: [~jstewart] it seems log file doe

Re: Review Request 59071: GEODE-2875 shutdown is taking as long as 20 seconds

2017-05-08 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59071/#review174234 --- Ship it! Ship It! - Hitesh Khamesra On May 8, 2017, 10:07

Re: Review Request 59034: GEODE-2352 Document that REST API requires two properties

2017-05-08 Thread Hitesh Khamesra
) <https://reviews.apache.org/r/59034/#comment247338> This looks good to me. ship it - Hitesh Khamesra On May 5, 2017, 10:32 p.m., Dave Barnes wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 59057: GEODE-2193 a member is kicked out immediately after joining

2017-05-08 Thread Hitesh Khamesra
> On May 8, 2017, 5:44 p.m., Hitesh Khamesra wrote: > > How about sending pending joinRequest(new member) with shutdown message. And let new coordinator take care of it. - Hitesh --- This is an automatically generated e-mail.

[jira] [Updated] (GEODE-2839) Enhance OQL portions of REST API developer documentation

2017-05-08 Thread Hitesh Khamesra (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitesh Khamesra updated GEODE-2839: --- Component/s: rest (dev) > Enhance OQL portions of REST API developer documentat

Re: Review Request 59057: GEODE-2193 a member is kicked out immediately after joining

2017-05-08 Thread Hitesh Khamesra
w view by removing current coordinator. - Hitesh Khamesra On May 8, 2017, 5:23 p.m., Bruce Schuchardt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 59057: GEODE-2193 a member is kicked out immediately after joining

2017-05-08 Thread Hitesh Khamesra
Then "receiver1" becomes coordinator(legal coordinator) by removing current coordinator. Now if current coordinator sends new view then cluster just ignores that view, as cluster has new-view by "receiver1". - Hitesh Khamesra On May 8, 201

[jira] [Commented] (GEODE-2874) StringIndexOutOfBoundsException while initializing logger

2017-05-08 Thread Hitesh Khamesra (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001129#comment-16001129 ] Hitesh Khamesra commented on GEODE-2874: Here is the list of files. I think

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-05 Thread Hitesh Khamesra
chunked input stream and can de-serialize the object as it is coming (DataSerializable.fromData(ChunkedStream)). From: Jacob Barrett To: dev@geode.apache.org; Hitesh Khamesra Cc: Anthony Baker Sent: Friday, May 5, 2017 7:29 AM Subject: Re: [gemfire-dev] New Client-Server Protocol

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-04 Thread Hitesh Khamesra
can read field offset from serialized stream, and then can read field value. Though, I can imagine with the help of pdxType, we can interpret serialized stream. From: Jacob Barrett To: dev@geode.apache.org; Hitesh Khamesra Cc: Anthony Baker Sent: Thursday

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-04 Thread Hitesh Khamesra
posal Sent from my iPhone > On May 4, 2017, at 12:03 PM, Hitesh Khamesra > wrote: > > And len 0 would indicate end of the message? > > > a. Now these two chunks will go continuous. They would appear continuous to the object serialization layer. > >

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-04 Thread Hitesh Khamesra
tand this better. Thanks. Hitesh ________ From: Anthony Baker To: Hitesh Khamesra Cc: "dev@geode.apache.org" Sent: Thursday, May 4, 2017 11:20 AM Subject: Re: [gemfire-dev] New Client-Server Protocol Proposal There would be one Message containing a single Me

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-04 Thread Hitesh Khamesra
ssages using "correlationId" ? Thanks. HItesh From: Anthony Baker To: dev@geode.apache.org Cc: Hitesh Khamesra Sent: Wednesday, May 3, 2017 5:42 PM Subject: Re: [gemfire-dev] New Client-Server Protocol Proposal > On May 3, 2017, at 1:33 PM, Galen M O

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-03 Thread Hitesh Khamesra
Good point Dan !! that needs to document. From: Dan Smith To: dev@geode.apache.org Sent: Wednesday, May 3, 2017 5:31 PM Subject: Re: [gemfire-dev] New Client-Server Protocol Proposal Okay but how do I has an implementer of a driver know what messages need an event id and which

[jira] [Created] (GEODE-2874) StringIndexOutOfBoundsException while initializing logger

2017-05-03 Thread Hitesh Khamesra (JIRA)
Hitesh Khamesra created GEODE-2874: -- Summary: StringIndexOutOfBoundsException while initializing logger Key: GEODE-2874 URL: https://issues.apache.org/jira/browse/GEODE-2874 Project: Geode

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-03 Thread Hitesh Khamesra
o json or vice-versa. Any thoughts? Thanks. HItesh ________ From: Hitesh Khamesra To: "dev@geode.apache.org" Sent: Wednesday, May 3, 2017 10:01 AM Subject: Re: [gemfire-dev] New Client-Server Protocol Proposal Here are the few things we need to consider..

Re: New Client-Server Protocol Proposal

2017-05-03 Thread Hitesh Khamesra
ghts? Thanks.Hitesh. From: Hitesh Khamesra To: "dev@geode.apache.org" Sent: Wednesday, May 3, 2017 10:01 AM Subject: Re: [gemfire-dev] New Client-Server Protocol Proposal Here are the few things we need to consider.. 1. key, value, callbackarg can be required to interpret

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-03 Thread Hitesh Khamesra
Here are the few things we need to consider.. 1. key, value, callbackarg can be required to interpret as JSON-to-pdx2. client calls "get/getall" api and want return value as JSON. Value was serialized as pdx.3. This behavior should be optional, if possible no overhead for others.4. "putAll api"

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-03 Thread Hitesh Khamesra
We have version at api(put, get etc) level https://cwiki.apache.org/confluence/display/GEODE/Message+Structure+and+Definition#MessageStructureandDefinition-RequestHeader. The client will connect to gemfire server by sending the "byte". That can be treated for message serialization. From: M

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-02 Thread Hitesh Khamesra
Absolutely its a implementation detail. JSON: Surely we can consider ValueHeader. But then every client(and message) needs to send that. Using metadata its a optional. From: Dan Smith To: Udo Kohlmeyer Cc: dev@geode.apache.org Sent: Tuesday, May 2, 2017 11:39 AM Subject: Re: [gemfire

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-01 Thread Hitesh Khamesra
>>>The message header currently is specified to have things like correlation id, isPartial message, and also metdatadata about whether the key or the value is JSON. IsPartialMessage: This flag gives us ability to send partial message without serializing the whole key-value(request). lets say I exe

[jira] [Assigned] (GEODE-1697) RedisDistDUnitTest.testConcOps

2017-04-28 Thread Hitesh Khamesra (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitesh Khamesra reassigned GEODE-1697: -- Assignee: Hitesh Khamesra > RedisDistDUnitTest.testConc

[jira] [Updated] (GEODE-2642) Sometime client doesn't ping server in ping-interval

2017-04-27 Thread Hitesh Khamesra (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitesh Khamesra updated GEODE-2642: --- Fix Version/s: 1.2.0 > Sometime client doesn't ping server in ping-

[jira] [Resolved] (GEODE-2642) Sometime client doesn't ping server in ping-interval

2017-04-27 Thread Hitesh Khamesra (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitesh Khamesra resolved GEODE-2642. Resolution: Fixed > Sometime client doesn't ping server in ping-

Re: Simple Java Client

2017-04-24 Thread Hitesh Khamesra
I would imagine rest client for mobile device.. From: Michael Stolz To: dev@geode.apache.org Sent: Monday, April 24, 2017 3:55 PM Subject: Re: Simple Java Client +1 I'd really like this to be a thin client. Something that would fit comfortably on a mobile device. -- Mike Stolz P

Re: Review Request 58541: GEODE-576 & GEODE-516 Flaky test: GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithFunction

2017-04-20 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58541/#review172534 --- Ship it! Ship It! - Hitesh Khamesra On April 19, 2017, 8:27

[jira] [Resolved] (GEODE-2193) a member is kicked out immediately after joining

2017-04-12 Thread Hitesh Khamesra (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitesh Khamesra resolved GEODE-2193. Fix Version/s: (was: 1.1.0) 1.2.0 > a member is kicked

Review Request 58391: GEODE-2193 Now we don't send view if shutdown process is started.

2017-04-12 Thread Hitesh Khamesra
/mgr/GMSMembershipManager.java 0180ddb Diff: https://reviews.apache.org/r/58391/diff/1/ Testing --- Thanks, Hitesh Khamesra

[jira] [Assigned] (GEODE-2193) a member is kicked out immediately after joining

2017-04-11 Thread Hitesh Khamesra (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitesh Khamesra reassigned GEODE-2193: -- Assignee: Hitesh Khamesra (was: Bruce Schuchardt) > a member is kicked

Re: Review Request 58187: GEODE-2732 after auto-reconnect a server is restarted on the default port of 40404

2017-04-05 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58187/#review171159 --- Ship it! Ship It! - Hitesh Khamesra On April 4, 2017, 8:46

Re: Global PDX Types -> Move to Region Level?

2017-04-05 Thread Hitesh Khamesra
Well said, Mike. We should document that as best practices. As Anthony mentioned, we should look for fuzzy type checking, atleast for numbers. I did consider this some time back. But It is tedious to support backward compability, unless we say pdx version 2.  From: Anthony Baker To: d

Re: Review Request 58155: GEODE-2653: fix a flaky test.

2017-04-04 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58155/#review171071 --- Ship it! Ship It! - Hitesh Khamesra On April 3, 2017, 6:31

[jira] [Created] (GEODE-2752) FixedPRSinglehopDUnitTest.test_FPAmetadataFetch fails on Jenkins

2017-04-04 Thread Hitesh Khamesra (JIRA)
Hitesh Khamesra created GEODE-2752: -- Summary: FixedPRSinglehopDUnitTest.test_FPAmetadataFetch fails on Jenkins Key: GEODE-2752 URL: https://issues.apache.org/jira/browse/GEODE-2752 Project: Geode

[jira] [Created] (GEODE-2751) UniversalMembershipListenerAdapterDUnitTest.testSystemClientEventsInServer fails on Jenkins

2017-04-04 Thread Hitesh Khamesra (JIRA)
Hitesh Khamesra created GEODE-2751: -- Summary: UniversalMembershipListenerAdapterDUnitTest.testSystemClientEventsInServer fails on Jenkins Key: GEODE-2751 URL: https://issues.apache.org/jira/browse/GEODE-2751

[jira] [Commented] (GEODE-2658) Provide Developer friendly api on Geode

2017-03-27 Thread Hitesh Khamesra (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944145#comment-15944145 ] Hitesh Khamesra commented on GEODE-2658: Rest Api should be able to use

  1   2   3   4   5   6   >