[jira] [Commented] (GEODE-2167) BundledJarsJUnitTest.verifyBundledJarsHaveNotChanged fails with java.nio.file.InvalidPathException on Windows

2016-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753599#comment-15753599 ] ASF GitHub Bot commented on GEODE-2167: --- Github user vectorijk commented on a diff i

[GitHub] geode pull request #308: [GEODE-2167] BundledJarsJUnitTest fails on Windows

2016-12-15 Thread vectorijk
Github user vectorijk commented on a diff in the pull request: https://github.com/apache/geode/pull/308#discussion_r92757837 --- Diff: geode-assembly/src/test/java/org/apache/geode/BundledJarsJUnitTest.java --- @@ -48,8 +49,10 @@ public void loadExpectedJars() throws IOExcep

Question for precheckin UnitTest Failures

2016-12-15 Thread Alyssa Kim
Hi, Hi, I have been facing UnitTest failures on Windows Environment. *Summary :* Compilation with skip test works fine and the application works fine too. However, whenever I try to compile the code with >gradlew.bat precheckin some of the test cases fail. 1. installIntoWebXml : fails due to 1 l

[jira] [Commented] (GEODE-1541) statsListUniqueId should be an AtomicLong

2016-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753442#comment-15753442 ] ASF GitHub Bot commented on GEODE-1541: --- Github user davinash commented on the issue

[GitHub] geode issue #319: GEODE-1541 : Made statsListUniqueId to be an AtomicLong.

2016-12-15 Thread davinash
Github user davinash commented on the issue: https://github.com/apache/geode/pull/319 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[jira] [Commented] (GEODE-1995) remove ReliableMessageQueueFactory, ReliableMessageQueue, and getReliableMessageQueueFactory

2016-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753424#comment-15753424 ] ASF GitHub Bot commented on GEODE-1995: --- Github user davinash commented on the issue

[GitHub] geode issue #315: GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQ...

2016-12-15 Thread davinash
Github user davinash commented on the issue: https://github.com/apache/geode/pull/315 Please review this PR, Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[jira] [Commented] (GEODE-1541) statsListUniqueId should be an AtomicLong

2016-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753371#comment-15753371 ] ASF GitHub Bot commented on GEODE-1541: --- GitHub user ameybarve15 opened a pull reque

[GitHub] geode pull request #319: GEODE-1541 : Made statsListUniqueId to be an Atomic...

2016-12-15 Thread ameybarve15
GitHub user ameybarve15 opened a pull request: https://github.com/apache/geode/pull/319 GEODE-1541 : Made statsListUniqueId to be an AtomicLong. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ameybarve15/incubator-geode feature/

Re: Review Request 54801: GEODE-2207 GEODE-1662: fix and rename SecurityManager callback test

2016-12-15 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54801/#review159402 --- geode-core/src/test/java/org/apache/geode/security/IntegratedSecu

[jira] [Commented] (GEODE-2196) Write more tests to cover the current behavior of cluster config

2016-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753141#comment-15753141 ] ASF GitHub Bot commented on GEODE-2196: --- Github user asfgit closed the pull request

[jira] [Commented] (GEODE-2196) Write more tests to cover the current behavior of cluster config

2016-12-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753140#comment-15753140 ] ASF subversion and git services commented on GEODE-2196: Commit 4e

[GitHub] geode pull request #317: [GEODE-2196] Add test for exportClusterConfig.

2016-12-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/317 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

Re: Review Request 54801: GEODE-2207 GEODE-1662: fix and rename SecurityManager callback test

2016-12-15 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54801/#review159396 --- geode-core/src/test/java/org/apache/geode/security/SpySecurityMan

Review Request 54801: GEODE-2207 GEODE-1662: fix and rename SecurityManager callback test

2016-12-15 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54801/ --- Review request for geode, Jinmei Liao, Jared Stewart, and Kevin Duling. Bugs: G

[jira] [Assigned] (GEODE-1662) CI failure: IntegratedSecurityCacheLifecycleDistributedTest.initAndCloseTest

2016-12-15 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-1662: Assignee: Kirk Lund > CI failure: IntegratedSecurityCacheLifecycleDistributedTest.initAndCloseTest

[GitHub] geode issue #318: Handle exceptions and don't deserialize PDX objects when c...

2016-12-15 Thread upthewaterspout
Github user upthewaterspout commented on the issue: https://github.com/apache/geode/pull/318 I added the additional tests we dicussed. Take a look and let me know what you think. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (GEODE-2196) Write more tests to cover the current behavior of cluster config

2016-12-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752815#comment-15752815 ] ASF subversion and git services commented on GEODE-2196: Commit 98

[jira] [Commented] (GEODE-2196) Write more tests to cover the current behavior of cluster config

2016-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752750#comment-15752750 ] ASF GitHub Bot commented on GEODE-2196: --- Github user jaredjstewart commented on the

[GitHub] geode issue #317: [GEODE-2196] Add test for exportClusterConfig.

2016-12-15 Thread jaredjstewart
Github user jaredjstewart commented on the issue: https://github.com/apache/geode/pull/317 Precheckin passed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[jira] [Created] (GEODE-2217) Add generic type parameter to FunctionContext interface

2016-12-15 Thread Jared Stewart (JIRA)
Jared Stewart created GEODE-2217: Summary: Add generic type parameter to FunctionContext interface Key: GEODE-2217 URL: https://issues.apache.org/jira/browse/GEODE-2217 Project: Geode Issue T

[jira] [Closed] (GEODE-641) Allow lambda expressions to be used for Geode functions

2016-12-15 Thread Dan Smith (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Smith closed GEODE-641. --- > Allow lambda expressions to be used for Geode functions > ---

[jira] [Resolved] (GEODE-641) Allow lambda expressions to be used for Geode functions

2016-12-15 Thread Dan Smith (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Smith resolved GEODE-641. - Resolution: Fixed Fix Version/s: 1.0.0-incubating > Allow lambda expressions to be used for Geode fu

[GitHub] geode pull request #318: Handle exceptions and don't deserialize PDX objects...

2016-12-15 Thread jhuynh1
Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/318#discussion_r92691796 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionQueryDUnitTest.java --- @@ -149,6 +154,92 @@ public void run() {

[jira] [Commented] (GEODE-1955) JMX suspect string causes tests to fail

2016-12-15 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752400#comment-15752400 ] Kirk Lund commented on GEODE-1955: -- I'm also wondering why the ticket says "PATCH AVAILAB

[GitHub] geode pull request #318: Handle exceptions and don't deserialize PDX objects...

2016-12-15 Thread upthewaterspout
Github user upthewaterspout commented on a diff in the pull request: https://github.com/apache/geode/pull/318#discussion_r92688937 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java --- @@ -8751,18 +8751,26 @@ public Index createIndex(boolean

[GitHub] geode pull request #318: Handle exceptions and don't deserialize PDX objects...

2016-12-15 Thread upthewaterspout
Github user upthewaterspout commented on a diff in the pull request: https://github.com/apache/geode/pull/318#discussion_r92688373 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionQueryDUnitTest.java --- @@ -149,6 +154,92 @@ public void run() {

Re: Review Request 54752: GEODE-2213 Deadlock in GMSJoinLeaveJUnitTest

2016-12-15 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54752/#review159355 --- Ship it! Except for the @Test exception handling, this seems to

Re: Review Request 54752: GEODE-2213 Deadlock in GMSJoinLeaveJUnitTest

2016-12-15 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54752/#review159353 --- geode-core/src/test/java/org/apache/geode/distributed/internal/Di

[GitHub] geode pull request #318: Handle exceptions and don't deserialize PDX objects...

2016-12-15 Thread jhuynh1
Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/318#discussion_r92677109 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java --- @@ -8751,18 +8751,26 @@ public Index createIndex(boolean remote

[GitHub] geode pull request #318: Handle exceptions and don't deserialize PDX objects...

2016-12-15 Thread jhuynh1
Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/318#discussion_r92678100 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionQueryDUnitTest.java --- @@ -149,6 +154,92 @@ public void run() {

[GitHub] geode pull request #318: Handle exceptions and don't deserialize PDX objects...

2016-12-15 Thread jhuynh1
Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/318#discussion_r92677783 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionQueryDUnitTest.java --- @@ -149,6 +154,92 @@ public void run() {

[jira] [Commented] (GEODE-2196) Write more tests to cover the current behavior of cluster config

2016-12-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752186#comment-15752186 ] ASF subversion and git services commented on GEODE-2196: Commit ca

[GitHub] geode pull request #318: Handle exceptions and don't deserialize PDX objects...

2016-12-15 Thread upthewaterspout
GitHub user upthewaterspout opened a pull request: https://github.com/apache/geode/pull/318 Handle exceptions and don't deserialize PDX objects when creating indexes These are two related changes to our index creation code. We should not deserialize PDX objects during index creation

[jira] [Commented] (GEODE-2209) Only 16 GatewaySenders are supported

2016-12-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752124#comment-15752124 ] ASF subversion and git services commented on GEODE-2209: Commit b0

Re: Review Request 54767: GEODE-2214: fall back to TCCL if target CL fails to resolve class

2016-12-15 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54767/#review159340 --- Ship it! Ship It! - Dan Smith On Dec. 15, 2016, 1:05 a.m., J

Re: Review Request 54767: GEODE-2214: fall back to TCCL if target CL fails to resolve class

2016-12-15 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54767/#review159339 --- extensions/geode-modules/src/test/java/org/apache/geode/modules/u

[jira] [Commented] (GEODE-2196) Write more tests to cover the current behavior of cluster config

2016-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752093#comment-15752093 ] ASF GitHub Bot commented on GEODE-2196: --- Github user jaredjstewart commented on a di

[GitHub] geode pull request #317: [GEODE-2196] Add test for exportClusterConfig.

2016-12-15 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/317#discussion_r92668393 --- Diff: geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java --- @@ -85,21 +91,16 @@ public void connect(String...

Fwd: Jenkins build is back to normal : Geode-nightly #685

2016-12-15 Thread Kirk Lund
This one completed in 12 hours and thus passed. -- Forwarded message -- From: Apache Jenkins Server Date: Wed, Dec 14, 2016 at 7:57 AM Subject: Jenkins build is back to normal : Geode-nightly #685 To: dev@geode.apache.org, adon...@apache.org, kl...@pivotal.io, dbar...@pivotal.io,

Re: Hidden system functions

2016-12-15 Thread Kirk Lund
Thanks Avinash! On Thu, Dec 15, 2016 at 10:10 AM, Avinash Dongre wrote: > I think Function should implement InternalEntity > > Thanks > Avinash > > > On Thu, Dec 15, 2016 at 11:36 PM, Kirk Lund wrote: > > > Does anyone know off the top of their heads how to create an internal > Geode > > Funct

[jira] [Commented] (GEODE-2214) ClassLoaderObjectInputStream should support usage of TCCL

2016-12-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752074#comment-15752074 ] ASF subversion and git services commented on GEODE-2214: Commit 41

[GitHub] geode pull request #317: [GEODE-2196] Add test for exportClusterConfig.

2016-12-15 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/317#discussion_r92666840 --- Diff: geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java --- @@ -85,21 +91,16 @@ public void connect(String... opt

[jira] [Commented] (GEODE-2196) Write more tests to cover the current behavior of cluster config

2016-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752072#comment-15752072 ] ASF GitHub Bot commented on GEODE-2196: --- Github user jinmeiliao commented on a diff

Re: Hidden system functions

2016-12-15 Thread Avinash Dongre
I think Function should implement InternalEntity Thanks Avinash On Thu, Dec 15, 2016 at 11:36 PM, Kirk Lund wrote: > Does anyone know off the top of their heads how to create an internal Geode > Function that doesn't show up for the User? >

[jira] [Resolved] (GEODE-2169) Subclasses of OperationContext should also be deprecated

2016-12-15 Thread Kevin Duling (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Duling resolved GEODE-2169. - Resolution: Fixed Fix Version/s: 1.1.0 commit 8b90324c79f7ae25cc34955b8e45a2ab9e9993f6 Inc

Hidden system functions

2016-12-15 Thread Kirk Lund
Does anyone know off the top of their heads how to create an internal Geode Function that doesn't show up for the User?

[jira] [Assigned] (GEODE-2169) Subclasses of OperationContext should also be deprecated

2016-12-15 Thread Kevin Duling (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Duling reassigned GEODE-2169: --- Assignee: Kevin Duling > Subclasses of OperationContext should also be deprecated > -

Re: Review Request 54772: GEODE-2212: request headers are case-insensitive

2016-12-15 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54772/#review159330 --- Ship it! Ship It! - Kevin Duling On Dec. 14, 2016, 9:44 p.m.

[jira] [Commented] (GEODE-2188) ExampleSecurityManager references SampleSecurityManager in javadoc

2016-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752012#comment-15752012 ] ASF GitHub Bot commented on GEODE-2188: --- Github user kjduling commented on a diff in

[GitHub] geode pull request #316: GEODE-2188: ExampleSecurityManager references Sampl...

2016-12-15 Thread kjduling
Github user kjduling commented on a diff in the pull request: https://github.com/apache/geode/pull/316#discussion_r92662419 --- Diff: geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java --- @@ -257,15 +257,65 @@ private void readUsers(final Map

[jira] [Commented] (GEODE-2212) gfsh http authentication fails when routed through a proxy

2016-12-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751982#comment-15751982 ] ASF subversion and git services commented on GEODE-2212: Commit 46

Re: Review Request 54772: GEODE-2212: request headers are case-insensitive

2016-12-15 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54772/#review159321 --- Ship it! Ship It! - Jared Stewart On Dec. 15, 2016, 5:44 a.m

Re: Review Request 54767: GEODE-2214: fall back to TCCL if target CL fails to resolve class

2016-12-15 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54767/#review159323 --- Fix it, then Ship it! Fix it and ship it! extensions/geode-mo

Re: Review Request 54772: GEODE-2212: request headers are case-insensitive

2016-12-15 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54772/#review159322 --- Ship it! Ship It! - Kirk Lund On Dec. 15, 2016, 5:44 a.m., J

Re: Review Request 54761: GEODE-2215 NPE in ViewCreator thread setting public keys into a NetVie

2016-12-15 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54761/#review159320 --- Ship it! Other than the issue raised, ship it - Udo Kohlmeyer

[jira] [Commented] (GEODE-2196) Write more tests to cover the current behavior of cluster config

2016-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751875#comment-15751875 ] ASF GitHub Bot commented on GEODE-2196: --- Github user jaredjstewart commented on a di

Re: Review Request 54761: GEODE-2215 NPE in ViewCreator thread setting public keys into a NetVie

2016-12-15 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54761/#review159319 --- geode-core/src/main/java/org/apache/geode/distributed/internal/me

[GitHub] geode pull request #317: [GEODE-2196] Add test for exportClusterConfig.

2016-12-15 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/317#discussion_r92652733 --- Diff: geode-core/src/test/java/org/apache/geode/test/dunit/rules/Locator.java --- @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Fo

[jira] [Commented] (GEODE-2196) Write more tests to cover the current behavior of cluster config

2016-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751865#comment-15751865 ] ASF GitHub Bot commented on GEODE-2196: --- Github user jaredjstewart commented on a di

[GitHub] geode pull request #317: [GEODE-2196] Add test for exportClusterConfig.

2016-12-15 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/317#discussion_r92651688 --- Diff: geode-core/src/test/java/org/apache/geode/test/dunit/rules/ConfigGroup.java --- @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Softwa

[jira] [Commented] (GEODE-2196) Write more tests to cover the current behavior of cluster config

2016-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751863#comment-15751863 ] ASF GitHub Bot commented on GEODE-2196: --- Github user jaredjstewart commented on a di

[GitHub] geode pull request #317: [GEODE-2196] Add test for exportClusterConfig.

2016-12-15 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/317#discussion_r92651523 --- Diff: geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java --- @@ -44,32 +46,32 @@ /** * This is

[jira] [Commented] (GEODE-2196) Write more tests to cover the current behavior of cluster config

2016-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751846#comment-15751846 ] ASF GitHub Bot commented on GEODE-2196: --- Github user jaredjstewart commented on a di

[GitHub] geode pull request #317: [GEODE-2196] Add test for exportClusterConfig.

2016-12-15 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/317#discussion_r92650337 --- Diff: geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java --- @@ -85,19 +91,17 @@ public void connect(String...

[jira] [Resolved] (GEODE-789) Create and clear define index shouldn't be available on disconnected GFSH

2016-12-15 Thread Amey Barve (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amey Barve resolved GEODE-789. -- Resolution: Fixed This is resolved with https://github.com/apache/geode/pull/314 pull request > Create a

[jira] [Commented] (GEODE-789) Create and clear define index shouldn't be available on disconnected GFSH

2016-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15750867#comment-15750867 ] ASF GitHub Bot commented on GEODE-789: -- Github user ameybarve15 closed the pull reques

[GitHub] geode pull request #314: GEODE-789: Added 'create defined indexes', 'clear d...

2016-12-15 Thread ameybarve15
Github user ameybarve15 closed the pull request at: https://github.com/apache/geode/pull/314 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is