GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode/pull/318
Handle exceptions and don't deserialize PDX objects when creating indexes
These are two related changes to our index creation code. We should not
deserialize PDX objects during index creation. We should also fail the index
creation and clean up the index if there is a failure.
I'm a committer, I can merge these changes. Creating the PR for review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/upthewaterspout/incubator-geode
feature/GEODE-1272
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/318.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #318
----
commit 6782e0f100dacb5034e41f3854be27060f8af2e8
Author: Dan Smith <[email protected]>
Date: 2016-12-15T00:59:51Z
GEODE-2216: Throwing an exception if index creation fails.
Making sure index creation always throws an exception and cleans up the
index if the index creation fails. Adding a test that causes index
creation failure by failing to deserialize entries.
commit 4a240dc27d77ae98dde10b4097e9eee6d515e1ce
Author: Dan Smith <[email protected]>
Date: 2016-12-15T01:08:36Z
GEODE-1272 Don't deserialize PDX objects when creating an index
Setting the flag to prevent deserialization of PDX objects while
populating an index that is defined on a partitioned region. We were
setting this flag in the member that initially created the index, but
not in other members that receive the IndexCreationMessage.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
