----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54761/#review159319 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/NetView.java (lines 608 - 610) <https://reviews.apache.org/r/54761/#comment230295> Do we maybe not want to clear the previous entries before putAll? Do we want to keep all previous entries? - Udo Kohlmeyer On Dec. 14, 2016, 10:41 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54761/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2016, 10:41 p.m.) > > > Review request for geode, Galen O'Sullivan and Udo Kohlmeyer. > > > Bugs: GEODE-2215 > https://issues.apache.org/jira/browse/GEODE-2215 > > > Repository: geode > > > Description > ------- > > NetView creates a ConcurrentHashmap to hold the public keys when it's > constructed but it had some methods that were replacing it with a Hashmap. I > made the field final and also added checks to avoid putting a null key or > value into the map. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/NetView.java > ca62e203985c19068554ff740f6e3d893ebd50a2 > > geode-core/src/test/java/org/apache/geode/distributed/internal/membership/NetViewJUnitTest.java > 715da474393cbfdd430cc5d54011c8a7739f6aee > > Diff: https://reviews.apache.org/r/54761/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Bruce Schuchardt > >
