-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54801/
-----------------------------------------------------------

Review request for geode, Jinmei Liao, Jared Stewart, and Kevin Duling.


Bugs: GEODE-1662 and GEODE-2207
    https://issues.apache.org/jira/browse/GEODE-1662
    https://issues.apache.org/jira/browse/GEODE-2207


Repository: geode


Description
-------

The point of this test originally was to start up a Manager and a non-Manager 
with a SecurityManager and verify that init and close were correctly being 
invoked in both. At some point the test was marked as Flaky and then completed 
disabled with Ignore.

I've renamed the test and some methods to make it more clear about what it's 
doing and testing. I also tried to make it more stable and ran it 1000 times to 
try to shake the flakiness. It seems stable now.


Diffs
-----

  
geode-core/src/test/java/org/apache/geode/security/IntegratedSecurityCacheLifecycleDistributedTest.java
 00a9276c51c45e5260a3795258d186f99edaa21f 
  geode-core/src/test/java/org/apache/geode/security/SpySecurityManager.java 
8704e934a04910907bbcda068629086d9c278143 

Diff: https://reviews.apache.org/r/54801/diff/


Testing
-------

targeted testing for flakiness
precheckin in progress


Thanks,

Kirk Lund

Reply via email to