[
https://issues.apache.org/jira/browse/GEODE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752012#comment-15752012
]
ASF GitHub Bot commented on GEODE-2188:
---------------------------------------
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/geode/pull/316#discussion_r92662419
--- Diff:
geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
---
@@ -257,15 +257,65 @@ private void readUsers(final Map<String, User>
rolesToUsers, final JsonNode node
return roleMap;
}
- static class Role {
+ public static class Role {
List<ResourcePermission> permissions = new ArrayList<>();
+
--- End diff --
I didn't add them, I just marked them public so that the Test could reach
them. It didn't make sense to me for TestSecurityManagerTest to be testing
TestSecurityManager. It makes slightly more sense to test the
ExampleSecurityManager. The two security managers are identical code at this
point (RE: GEODE-2092), but I'm sure that'll change in the near future as we
build out Geode examples.
If we were to remove Roles and Users, we'd also remove about 95% of the
code in ExampleSecurityManager, not leaving much example left. We should have
a separate ticket to refactor the example. This one really is only supposed to
address some Javadoc and System.out messages.
> ExampleSecurityManager references SampleSecurityManager in javadoc
> ------------------------------------------------------------------
>
> Key: GEODE-2188
> URL: https://issues.apache.org/jira/browse/GEODE-2188
> Project: Geode
> Issue Type: Bug
> Components: core, docs
> Reporter: Kevin Duling
> Assignee: Kevin Duling
> Priority: Minor
> Fix For: 1.1.0
>
>
> Example code was moved in GEODE-2092, but some strings need to be updated.
> Javadoc references an incorrect path.
> {{@code security-manager =
> org.apache.geode.security.examples.SampleSecurityManager}}
> and several strings refer to SampleSecurityManager.
> E.g.,
> {code}
> if (!initializeFromJsonResource(jsonPropertyValue)) {
> throw new AuthenticationFailedException(
> "SampleSecurityManager: unable to find json resource \"" +
> jsonPropertyValue
> + "\" as specified by [" + SECURITY_JSON + "].");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
