[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1619: Check all tablet using partition tablet map during publish version

2019-08-13 Thread GitBox
chaoyli commented on a change in pull request #1619: Check all tablet using partition tablet map during publish version URL: https://github.com/apache/incubator-doris/pull/1619#discussion_r313719310 ## File path: be/src/olap/tablet_sync_service.cpp ## @@ -0,0 +1,149 @@ +//

[GitHub] [incubator-doris] kangkaisen commented on issue #1638: Make Netty SO_BACKLOG configurable

2019-08-13 Thread GitBox
kangkaisen commented on issue #1638: Make Netty SO_BACKLOG configurable URL: https://github.com/apache/incubator-doris/pull/1638#issuecomment-521090573 > Besides this, thrift server also have a default backlog(50). > It's better if you can modify it together. OK, Update. -

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1638: Make Netty SO_BACKLOG configurable

2019-08-13 Thread GitBox
kangkaisen commented on a change in pull request #1638: Make Netty SO_BACKLOG configurable URL: https://github.com/apache/incubator-doris/pull/1638#discussion_r313693895 ## File path: fe/src/main/java/org/apache/doris/common/Config.java ## @@ -215,6 +215,14 @@ * Curr

[GitHub] [incubator-doris] manannan2017 opened a new issue #1640: the accuracy problem of set_x

2019-08-13 Thread GitBox
manannan2017 opened a new issue #1640: the accuracy problem of set_x URL: https://github.com/apache/incubator-doris/issues/1640 SELECT ST_X(ST_Point(-18.12345678901234, 16.7)); SELECT ST_X(ST_Point(-123.1234567890123456789, 16.7)); [图片]

[GitHub] [incubator-doris] manannan2017 opened a new issue #1639: ST_Contains function:not suitable for Circle、ST_Polygon

2019-08-13 Thread GitBox
manannan2017 opened a new issue #1639: ST_Contains function:not suitable for Circle、ST_Polygon URL: https://github.com/apache/incubator-doris/issues/1639 2 cases: case 1: SELECT ST_Contains(ST_Circle(111, 64, 90), ST_Circle(111, 64, 10)); ![image](https://user-images.githubusercont

[GitHub] [incubator-doris] imay commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1635#discussion_r313686877 ## File path: be/src/exec/parquet_reader.cpp ## @@ -396,6 +412,35 @@ Status Parque

[GitHub] [incubator-doris] imay commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1635#discussion_r313684725 ## File path: gensrc/thrift/PlanNodes.thrift ## @@ -114,6 +114,8 @@ struct TBroker

[GitHub] [incubator-doris] imay commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1635#discussion_r313685109 ## File path: be/src/exec/broker_scanner.cpp ## @@ -452,6 +456,31 @@ bool BrokerSc

[GitHub] [incubator-doris] imay commented on a change in pull request #1638: Make Netty SO_BACKLOG configurable

2019-08-13 Thread GitBox
imay commented on a change in pull request #1638: Make Netty SO_BACKLOG configurable URL: https://github.com/apache/incubator-doris/pull/1638#discussion_r313685761 ## File path: fe/src/main/java/org/apache/doris/common/Config.java ## @@ -215,6 +215,14 @@ * Currently,

[GitHub] [incubator-doris] kangkaisen opened a new pull request #1638: Make Netty SO_BACKLOG configurable

2019-08-13 Thread GitBox
kangkaisen opened a new pull request #1638: Make Netty SO_BACKLOG configurable URL: https://github.com/apache/incubator-doris/pull/1638 For https://github.com/apache/incubator-doris/issues/1637 This is an automated message fro

[GitHub] [incubator-doris] kangkaisen opened a new issue #1637: Curl Mini load timeout

2019-08-13 Thread GitBox
kangkaisen opened a new issue #1637: Curl Mini load timeout URL: https://github.com/apache/incubator-doris/issues/1637 **Describe the bug** Yesterday, Our user run a large hive to doris job, which had 700+ doris Http mini load, but a one http mini load get the following error: ```

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313680515 ## File path: be/src/olap/rowset/segment_v2/zone_map.h ## @@ -0,0 +1,92 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313680478 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.cpp ## @@ -0,0 +1,43 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] kangpinghuang commented on issue #1636: delete predicate can be used to filter segment data

2019-08-13 Thread GitBox
kangpinghuang commented on issue #1636: delete predicate can be used to filter segment data URL: https://github.com/apache/incubator-doris/issues/1636#issuecomment-521072427 parent issue #1305 This is an automated message fr

[GitHub] [incubator-doris] kangpinghuang opened a new issue #1636: delete predicate can be used to filter segment data

2019-08-13 Thread GitBox
kangpinghuang opened a new issue #1636: delete predicate can be used to filter segment data URL: https://github.com/apache/incubator-doris/issues/1636 Now delete predicate is user issued delete sql like this: delete from table_a where column_a = 1; So the delete predicate can be used

[GitHub] [incubator-doris] chaoyli merged pull request #1634: Fix bug that bad replica can not be synchronized when report

2019-08-13 Thread GitBox
chaoyli merged pull request #1634: Fix bug that bad replica can not be synchronized when report URL: https://github.com/apache/incubator-doris/pull/1634 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] yuanlihan opened a new pull request #1635: Enable parsing columns from file path for Broker Load (#1582)

2019-08-13 Thread GitBox
yuanlihan opened a new pull request #1635: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1635 Currently, we do not support parsing encoded/compressed columns in file path, eg: extract column k1 from file path /path/to/dir/

[GitHub] [incubator-doris] yuanlihan closed pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

2019-08-13 Thread GitBox
yuanlihan closed pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] yuanlihan opened a new pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

2019-08-13 Thread GitBox
yuanlihan opened a new pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629 Currently, we do not support parsing encoded/compressed columns in file path, eg: extract column k1 from file path `/path/to/dir

[GitHub] [incubator-doris] yuanlihan closed pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

2019-08-13 Thread GitBox
yuanlihan closed pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313370572 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.cpp ## @@ -0,0 +1,43 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313370236 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,98 @@ +// Licensed to the Apache S

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313368798 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -45,14 +46,17 @@ SegmentIterator::~Segm

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313364724 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -114,6 +119,80 @@ Status SegmentIterato

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313364770 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -114,6 +119,80 @@ Status SegmentIterato

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313362677 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.cpp ## @@ -0,0 +1,43 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313362446 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.cpp ## @@ -0,0 +1,43 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313361920 ## File path: be/src/olap/rowset/segment_v2/ordinal_page_index.h ## @@ -97,6 +98,19 @@ class OrdinalPageIndex

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313348479 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313342425 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313337023 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313335851 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313335014 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313334634 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313334727 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313334702 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313334566 ## File path: be/src/olap/iterators.h ## @@ -26,24 +26,29 @@ namespace doris { class RowCursor; class RowBlo

[GitHub] [incubator-doris] morningman merged pull request #1631: Fix time zone compatibility

2019-08-13 Thread GitBox
morningman merged pull request #1631: Fix time zone compatibility URL: https://github.com/apache/incubator-doris/pull/1631 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] morningman opened a new pull request #1634: Fix bug that bad replica can not be synchronized when report

2019-08-13 Thread GitBox
morningman opened a new pull request #1634: Fix bug that bad replica can not be synchronized when report URL: https://github.com/apache/incubator-doris/pull/1634 When the replica is recovered from bad on BE, the report process should change the bad status of replica on FE to false, or th

[GitHub] [incubator-doris] imay merged pull request #1576: Change cumulative compaction for decoupling storage from compution

2019-08-13 Thread GitBox
imay merged pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313279699 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -114,6 +119,80 @@ Status SegmentIterator::_prepar

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313248034 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313260150 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313248458 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313273446 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,98 @@ +// Licensed to the Apache Software Fo

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313275263 ## File path: be/src/olap/rowset/segment_v2/zone_map.h ## @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundatio

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313269063 ## File path: be/src/olap/rowset/segment_v2/ordinal_page_index.h ## @@ -97,6 +98,19 @@ class OrdinalPageIndex { }

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313244859 ## File path: be/src/olap/iterators.h ## @@ -26,24 +26,29 @@ namespace doris { class RowCursor; class RowBlockV2; cla

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313263989 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313264882 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313259805 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313273183 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.cpp ## @@ -0,0 +1,43 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313273011 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.cpp ## @@ -0,0 +1,43 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313278406 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -114,6 +119,80 @@ Status SegmentIterator::_prepar

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313266172 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313282796 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -114,6 +119,80 @@ Status SegmentIterator::_prepar

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313272696 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.cpp ## @@ -0,0 +1,43 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313263504 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,332 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313272393 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.cpp ## @@ -0,0 +1,43 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313276366 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -45,14 +46,17 @@ SegmentIterator::~SegmentIterato

[GitHub] [incubator-doris] imay commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

2019-08-13 Thread GitBox
imay commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629#discussion_r313251662 ## File path: be/src/exec/parquet_reader.cpp ## @@ -204,13 +208,23 @@ Status Parqu

[GitHub] [incubator-doris] yuanlihan commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

2019-08-13 Thread GitBox
yuanlihan commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629#discussion_r313250651 ## File path: fe/src/main/java/org/apache/doris/planner/BrokerScanNode.java ##

[GitHub] [incubator-doris] yuanlihan commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

2019-08-13 Thread GitBox
yuanlihan commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629#discussion_r313248654 ## File path: be/src/exec/parquet_reader.cpp ## @@ -204,13 +208,23 @@ Status

[GitHub] [incubator-doris] yuanlihan commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

2019-08-13 Thread GitBox
yuanlihan commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629#discussion_r313249231 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -1050,10 +1050,11 @@ data_

[GitHub] [incubator-doris] yuanlihan commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

2019-08-13 Thread GitBox
yuanlihan commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629#discussion_r313248654 ## File path: be/src/exec/parquet_reader.cpp ## @@ -204,13 +208,23 @@ Status