imay commented on a change in pull request #1635: Enable parsing columns from
file path for Broker Load (#1582)
URL: https://github.com/apache/incubator-doris/pull/1635#discussion_r313684725
##########
File path: gensrc/thrift/PlanNodes.thrift
##########
@@ -114,6 +114,8 @@ struct TBrokerRangeDesc {
7: optional Types.TUniqueId load_id
// total size of the file
8: optional i64 file_size
+ // columns parsed from file path
+ 9: optional list<string> columns_from_path
Review comment:
It's better to record the slot offset for `columns_from_path` or name it
`num_of_columns_from_file`. Because we may add other `columns_from_xxx`, we
should make it definite.
And you should comment that `columns_from_path` is after the columns read
from file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
