imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313279699
########## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ########## @@ -114,6 +119,80 @@ Status SegmentIterator::_prepare_seek() { return Status::OK(); } +Status SegmentIterator::_init_row_ranges() { + if (_lower_rowid == _upper_rowid) { + // no data return; + _row_ranges = RowRanges(); + return Status::OK(); + } + // short key range is [_lower_rowid, _upper_rowid) + RowRanges short_key_row_ranges(std::move(RowRanges::create_single(_lower_rowid, _upper_rowid))); Review comment: And I think after _init_short_key_range, we generate a RowRange ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org