imay commented on a change in pull request #1633: add zone map page(#1390)
URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313269063
##########
File path: be/src/olap/rowset/segment_v2/ordinal_page_index.h
##########
@@ -97,6 +98,19 @@ class OrdinalPageIndex {
}
OrdinalPageIndexIterator end() {
return OrdinalPageIndexIterator(this, _num_pages);
+ }
+ rowid_t get_first_row_id(int page_index) const {
+ return _rowids[page_index];
+ }
+
+ rowid_t get_last_row_id(int page_index, size_t column_row_count) const {
Review comment:
you can write last row id to _rowids, if you do that, you can make this
logic simple.
just get_first_row_id(next_page_index) - 1, and without column_row_count
param
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
