imay commented on a change in pull request #1633: add zone map page(#1390)
URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313244859
##########
File path: be/src/olap/iterators.h
##########
@@ -26,24 +26,29 @@ namespace doris {
class RowCursor;
class RowBlockV2;
class Schema;
+class Conditions;
struct StorageReadOptions {
// lower_bound defines the smallest key at which iterator will
// return data.
// If lower_bound is null, won't return
- std::shared_ptr<RowCursor> lower_bound;
+ std::shared_ptr<RowCursor> lower_bound = nullptr;
// If include_lower_bound is true, data equal with lower_bound will
// be read
- bool include_lower_bound;
+ bool include_lower_bound = false;
// upper_bound defines the extend upto which the iterator can return
// data.
- std::shared_ptr<RowCursor> upper_bound;
+ std::shared_ptr<RowCursor> upper_bound = nullptr;
// If include_upper_bound is true, data equal with upper_bound will
// be read
- bool include_upper_bound;
+ bool include_upper_bound = false;
+
+ // reader's column predicates
+ // used to filter data by zone map/bloom filter/second index
+ Conditions* conditions = nullptr;
Review comment:
better to use shared_ptr to make client easy to use
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
