imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r313259805
########## File path: be/src/olap/rowset/segment_v2/row_ranges.h ########## @@ -0,0 +1,332 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <string> +#include <vector> + +#include "common/logging.h" +#include "olap/rowset/segment_v2/common.h" +#include "gutil/strings/substitute.h" + +namespace doris { +namespace segment_v2 { + +class Range { +public: + // Returns true if if two ranges are overlapped or false. + // The union range will be returned through range. + static bool range_union(const Range& left, const Range& right, Range* range) { + if (left._from <= right._from) { + if (left._to >= right._from) { + range->_from = left._from; + range->_to = std::max(left._to, right._to); + return true; + } + } else if (right._to >= left._from) { + range->_from = right._from; + range->_to = std::max(left._to, right._to); + return true; + } + // return a invalid range + range->_from = 0; + range->_to = 0; + return false; + } + + // Returns true if the two ranges are overlapped or false. + // The intersection of the two ranges is returned through range. + static bool range_intersection(const Range& left, const Range& right, Range* range) { + if (left._from <= right._from) { + if (left._to > right._from) { + range->_from = right._from; + range->_to = std::min(left._to, right._to); + return true; + } + } else if (right._to > left._from) { + range->_from = left._from; + range->_to = std::min(left._to, right._to); + return true; + } + // return a invalid range + range->_from = 0; + range->_to = 0; + return false; + } + + Range() { Review comment: initialization list ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org
