Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v19]

2025-06-26 Thread Doug Lea
> This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Use javadoc internal linkages in CHM -

Re: RFR: 8359174: tools/jlink/JLink20000Packages.java timed out [v3]

2025-06-26 Thread Eirik Bjørsnøs
On Thu, 26 Jun 2025 06:56:17 GMT, Eirik Bjørsnøs wrote: > For these simple class files I would assume using the class file API to > generate the class files directly without involving javac at all would both > simplify this test and run faster. Here's a branch on top of your PR with an explora

Re: RFR: 8359174: tools/jlink/JLink20000Packages.java timed out [v3]

2025-06-26 Thread Eirik Bjørsnøs
On Thu, 26 Jun 2025 06:16:06 GMT, Henry Jen wrote: >> Create a jar directly from the memory instead of real file, this should >> reduce the I/O overhead which likely the reason for the time out. >> The issue is not reproducible locally, and fails intermittently, so we >> simply trying to reduce

Re: RFR: 8359437: Make users and test suite not able to set LockingMode flag [v6]

2025-06-26 Thread duke
On Wed, 25 Jun 2025 11:26:22 GMT, Anton Artemov wrote: >> This PR contains changes for the 1st phase of the `LockingMode` flag >> obsoletion. >> >> The work is done by @fbredber, I have taken it over and am finishing it >> while he's on vacation. >> >> In the 1st phase one keeps the `Lockin

Integrated: 8359437: Make users and test suite not able to set LockingMode flag

2025-06-26 Thread Anton Artemov
On Tue, 17 Jun 2025 08:39:49 GMT, Anton Artemov wrote: > This PR contains changes for the 1st phase of the `LockingMode` flag > obsoletion. > > The work is done by @fbredber, I have taken it over and am finishing it while > he's on vacation. > > In the 1st phase one keeps the `LockingMode`

Re: RFR: 8359174: tools/jlink/JLink20000Packages.java timed out [v3]

2025-06-26 Thread Eirik Bjørsnøs
On Thu, 26 Jun 2025 06:16:06 GMT, Henry Jen wrote: >> Create a jar directly from the memory instead of real file, this should >> reduce the I/O overhead which likely the reason for the time out. >> The issue is not reproducible locally, and fails intermittently, so we >> simply trying to reduce

Re: Object.wait returns normally if interrupted

2025-06-26 Thread David Holmes
Hi Pavel, On 27/06/2025 8:23 am, Pavel Rappo wrote: Here's an interesting behaviour. A thread that has been blocked in Object.wait is interrupted. But instead of throwing an InterruptedException, Object.wait returns normally with the thread's interrupt status set. Do you mean it returns normal

Re: RFR: 8357289: Break down the String constructor into smaller methods [v8]

2025-06-26 Thread Shaojin Wen
On Wed, 25 Jun 2025 00:13:56 GMT, Shaojin Wen wrote: >> Through JVM Option +PrintInlining, we found that String has a constructor >> codeSize of 852, which is too large. This caused failed to inline. >> >> The following is the output information of PrintInlining: >> >> @ 9 ja

Re: RFR: 8354242: VectorAPI: combine vector not operation with compare [v9]

2025-06-26 Thread Xiaohong Gong
On Wed, 25 Jun 2025 10:08:23 GMT, erifan wrote: >> This patch optimizes the following patterns: >> For integer types: >> >> (XorV (VectorMaskCmp src1 src2 cond) (Replicate -1)) >> => (VectorMaskCmp src1 src2 ncond) >> (XorVMask (VectorMaskCmp src1 src2 cond) (MaskAll m1)) >> => (VectorMa

Re: RFR: 8359174: tools/jlink/JLink20000Packages.java timed out [v4]

2025-06-26 Thread Henry Jen
> Create a jar directly from the memory instead of real file, this should > reduce the I/O overhead which likely the reason for the time out. > The issue is not reproducible locally, and fails intermittently, so we simply > trying to reduce time needed. > The jar file created is verified manually

Re: RFR: 8359174: tools/jlink/JLink20000Packages.java timed out [v4]

2025-06-26 Thread Eirik Bjørsnøs
On Fri, 27 Jun 2025 04:59:58 GMT, Henry Jen wrote: >> Create a jar directly from the memory instead of real file, this should >> reduce the I/O overhead which likely the reason for the time out. >> The issue is not reproducible locally, and fails intermittently, so we >> simply trying to reduce

Re: RFR: 8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta) [v2]

2025-06-26 Thread Jaikiran Pai
On Wed, 25 Jun 2025 10:20:15 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to address the issue >> noted in https://bugs.openjdk.org/browse/JDK-8359830? >> >> macOS operating system's newer version 26 (currently in Beta) is reported as >> a 16 by older ver

[jdk25] RFR: 8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta)

2025-06-26 Thread Jaikiran Pai
Can I please get a review of this backport to JDK 25? This backports https://bugs.openjdk.org/browse/JDK-8359830 which was integrated into mainline a few minutes back https://github.com/openjdk/jdk/pull/25865. With this change it should now be possible to test JDK 25 on macOS 26 when it gets re

Re: RFR: 8360518: Docker tests do not work when asan is configured

2025-06-26 Thread Severin Gehwolf
On Thu, 26 Jun 2025 01:26:38 GMT, SendaoYan wrote: > Should we should copy the dependent files such as libasan.so.8 to docker > images when build it. See: https://bugs.openjdk.org/browse/JDK-8333144?focusedId=14792939&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comme

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v8]

2025-06-26 Thread Jaikiran Pai
On Tue, 22 Apr 2025 16:15:29 GMT, Artur Barashev wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 506 commits: >> >> - merge latest changes from master branch >> - http3: update H3InsertionsLimitTest to sta

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v7]

2025-06-26 Thread Naoto Sato
On Wed, 25 Jun 2025 21:28:16 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v7]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 11:04:33 GMT, Daniel Fuchs wrote: >> Thank you Artur. >> >> @dfuch this conversation can be resolved too. > > Done > Hi Jaikiran! Sounds good. It's likely we are going to re-work this code > anyhow when we make QUIC engine public in the next iteration. We had a > discussio

Re: RFR: 8357272: Add overrides for all default methods to wrapper collections

2025-06-26 Thread Stuart Marks
On Wed, 28 May 2025 03:03:45 GMT, Stuart Marks wrote: > This mostly just adds overrides to the wrapper implementations in > java.util.Collections. However, in order to satisfy the test, some overrides > are also added to ReverseOrderSortedMapView, which is used by the SortedMap > wrapper keySe

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v8]

2025-06-26 Thread Alisen Chung
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK since the previous L10n drop. Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: Update src/demo/share/jfc/SwingSet2/resources/sw

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v7]

2025-06-26 Thread Alisen Chung
On Thu, 26 Jun 2025 17:41:13 GMT, Christian Stein wrote: >> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 461: >> >>> 459: SliderDemo.majorticks=Hauptteilstriche >>> 460: SliderDemo.majorticksdescription=Ein Schieberegler mit >>> Hauptteilstrichen >>> 461: SliderDemo.ticks=

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer away from jdk.internal.ref.Cleaner [v6]

2025-06-26 Thread Kim Barrett
On Fri, 27 Jun 2025 01:03:30 GMT, Kim Barrett wrote: >> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage >> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences >> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to >>

Re: [jdk25] RFR: 8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta)

2025-06-26 Thread Jaikiran Pai
On Thu, 26 Jun 2025 13:43:27 GMT, Jaikiran Pai wrote: > Can I please get a review of this backport to JDK 25? This backports > https://bugs.openjdk.org/browse/JDK-8359830 which was integrated into > mainline a few minutes back https://github.com/openjdk/jdk/pull/25865. > > With this change it

Re: [jdk25] RFR: 8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta)

2025-06-26 Thread Roger Riggs
On Thu, 26 Jun 2025 13:43:27 GMT, Jaikiran Pai wrote: > Can I please get a review of this backport to JDK 25? This backports > https://bugs.openjdk.org/browse/JDK-8359830 which was integrated into > mainline a few minutes back https://github.com/openjdk/jdk/pull/25865. > > With this change it

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v7]

2025-06-26 Thread Alexey Ivanov
On Wed, 25 Jun 2025 21:28:16 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Jeliński
On Thu, 26 Jun 2025 16:57:53 GMT, Daniel Fuchs wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 525 commits: >> >> - merge latest changes from master branch >> - http3: run H3StreamLimitReachedTest.java wit

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Jeliński
On Tue, 22 Apr 2025 16:21:30 GMT, Artur Barashev wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 525 commits: >> >> - merge latest changes from master branch >> - http3: run H3StreamLimitReachedTest.java w

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v7]

2025-06-26 Thread Christian Stein
On Thu, 26 Jun 2025 17:22:24 GMT, Alexey Ivanov wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> revert german translation, revert english wxl format change > > src/demo/share/jfc/SwingSet2/resources/swingset_de.pro

Re: RFR: 8359174: tools/jlink/JLink20000Packages.java timed out [v4]

2025-06-26 Thread Henry Jen
On Fri, 27 Jun 2025 06:28:32 GMT, Eirik Bjørsnøs wrote: >> Henry Jen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adapt review feedbacks > > test/jdk/tools/jlink/JLink2Packages.java line 130: > >> 128: /** >> 129: * Gene

Re: RFR: 8359174: tools/jlink/JLink20000Packages.java timed out [v4]

2025-06-26 Thread Eirik Bjørsnøs
On Fri, 27 Jun 2025 06:38:06 GMT, Henry Jen wrote: >> test/jdk/tools/jlink/JLink2Packages.java line 130: >> >>> 128: /** >>> 129: * Generate test class with main() does >>> 130: * System.out.println("JLink2PackagesTest started."); >> >> The test currently does not use this

Re: RFR: 8359174: tools/jlink/JLink20000Packages.java timed out [v4]

2025-06-26 Thread Eirik Bjørsnøs
On Fri, 27 Jun 2025 04:59:58 GMT, Henry Jen wrote: >> Create a jar directly from the memory instead of real file, this should >> reduce the I/O overhead which likely the reason for the time out. >> The issue is not reproducible locally, and fails intermittently, so we >> simply trying to reduce

Re: RFR: 8360518: Docker tests do not work when asan is configured

2025-06-26 Thread Matthias Baesken
On Wed, 25 Jun 2025 14:09:42 GMT, Matthias Baesken wrote: > When the address sanitizer ASAN is configured, we run into errors in the > docker tests. > Example hotspot/jtreg/containers/docker/DockerBasicTest.java : > > [STDOUT] > /jdk/bin/java: error while loading shared libraries: libasan.so.8:

Integrated: 8360518: Docker tests do not work when asan is configured

2025-06-26 Thread Matthias Baesken
On Wed, 25 Jun 2025 14:09:42 GMT, Matthias Baesken wrote: > When the address sanitizer ASAN is configured, we run into errors in the > docker tests. > Example hotspot/jtreg/containers/docker/DockerBasicTest.java : > > [STDOUT] > /jdk/bin/java: error while loading shared libraries: libasan.so.8:

Re: RFR: 8359174: tools/jlink/JLink20000Packages.java timed out [v3]

2025-06-26 Thread Jan Lahoda
On Thu, 26 Jun 2025 06:16:06 GMT, Henry Jen wrote: >> Create a jar directly from the memory instead of real file, this should >> reduce the I/O overhead which likely the reason for the time out. >> The issue is not reproducible locally, and fails intermittently, so we >> simply trying to reduce

Re: RFR: 8360518: Docker tests do not work when asan is configured

2025-06-26 Thread SendaoYan
On Wed, 25 Jun 2025 14:09:42 GMT, Matthias Baesken wrote: > When the address sanitizer ASAN is configured, we run into errors in the > docker tests. > Example hotspot/jtreg/containers/docker/DockerBasicTest.java : > > [STDOUT] > /jdk/bin/java: error while loading shared libraries: libasan.so.8:

Re: RFR: 8360518: Docker tests do not work when asan is configured

2025-06-26 Thread Severin Gehwolf
On Wed, 25 Jun 2025 14:09:42 GMT, Matthias Baesken wrote: > When the address sanitizer ASAN is configured, we run into errors in the > docker tests. > Example hotspot/jtreg/containers/docker/DockerBasicTest.java : > > [STDOUT] > /jdk/bin/java: error while loading shared libraries: libasan.so.8:

Re: RFR: 8357289: Break down the String constructor into smaller methods [v8]

2025-06-26 Thread Chen Liang
On Wed, 25 Jun 2025 00:13:56 GMT, Shaojin Wen wrote: >> Through JVM Option +PrintInlining, we found that String has a constructor >> codeSize of 852, which is too large. This caused failed to inline. >> >> The following is the output information of PrintInlining: >> >> @ 9 ja

Re: RFR: 8357289: Break down the String constructor into smaller methods [v8]

2025-06-26 Thread Roger Riggs
On Wed, 25 Jun 2025 22:29:39 GMT, Chen Liang wrote: > For startup time, I believe this should have little impact: String itself, > without allocation of its storage array, should be as expensive as generic > record objects. This should have similar impact of declaring new records > (minimal),

Re: RFR: 8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta) [v2]

2025-06-26 Thread Roger Riggs
On Wed, 25 Jun 2025 10:20:15 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to address the issue >> noted in https://bugs.openjdk.org/browse/JDK-8359830? >> >> macOS operating system's newer version 26 (currently in Beta) is reported as >> a 16 by older ver

Integrated: 8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta)

2025-06-26 Thread Jaikiran Pai
On Wed, 18 Jun 2025 06:01:43 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to address the issue > noted in https://bugs.openjdk.org/browse/JDK-8359830? > > macOS operating system's newer version 26 (currently in Beta) is reported as > a 16 by older versions

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v8]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 13:22:28 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/sun/security/ssl/X509Authentication.java line >> 226: >> >>> 224: chc.peerSupportedAuthorities == null ? null : >>> 225: chc.peerSupportedAuthorities.clone(), >>>

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v7]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 01:04:41 GMT, Jaikiran Pai wrote: >> Hi Jaikiran! Sounds good. It's likely we are going to re-work this code >> anyhow when we make QUIC engine public in the next iteration. We had a >> discussion with Daniel about it today. > > Thank you Artur. > > @dfuch this conversation

Re: RFR: 8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta) [v2]

2025-06-26 Thread Lance Andersen
On Wed, 25 Jun 2025 10:20:15 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to address the issue >> noted in https://bugs.openjdk.org/browse/JDK-8359830? >> >> macOS operating system's newer version 26 (currently in Beta) is reported as >> a 16 by older ver

Integrated: 8359919: Minor java.util.concurrent doc improvements

2025-06-26 Thread Doug Lea
On Wed, 18 Jun 2025 17:51:20 GMT, Doug Lea wrote: > This collects miscellaneous open issues that can be resolved with > documentation updates; each indicated by adding JDK issue numbers This pull request has now been integrated. Changeset: ff24088c Author:Doug Lea URL: https://git.

Re: RFR: 8191963: Path.equals() and File.equals() return true for two different files on Windows

2025-06-26 Thread Brian Burkhalter
On Thu, 26 Jun 2025 06:51:14 GMT, Alan Bateman wrote: > Exactly, so I think the first step here has to validate that where we ended > up in WindowsPath.compareTo is correct. `WindowsPath.compareTo` returns zero (equal) if and only if the path strings are the same length, and the two characters

Re: RFR: 8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta)

2025-06-26 Thread Jaikiran Pai
On Tue, 24 Jun 2025 13:10:41 GMT, Jaikiran Pai wrote: > The few places where this misreporting of macOS version in os_bsd.cpp is > going to impact is the VM error reporting (in hs_err files for example) and > the output of the newly introduced -XX:+PrintJVMInfoAtExit option. So I think > we ca

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Fuchs
> Hi, > > Please find here a PR for the implementation of [JEP 517: HTTP/3 for the HTTP > Client API](https://openjdk.org/jeps/517). > > The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the HTTP > Client API](https://bugs.openjdk.org/browse/JDK-8350588) > > This JEP propose

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8355177: Speed up StringBuilder::append(char[]) via Unsafe::copyMemory [v7]

2025-06-26 Thread Chen Liang
On Wed, 25 Jun 2025 02:01:18 GMT, Shaojin Wen wrote: >> In BufferedReader.readLine and other similar scenarios, we need to use >> StringBuilder.append(char[]) to build the string. >> >> For these scenarios, we can Unsafe.copyMemory instead of the character copy >> of the char-by-char loop to i

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v2]

2025-06-26 Thread Daniel Jeliński
On Fri, 25 Apr 2025 19:42:34 GMT, Artur Barashev wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 409 commits: >> >> - merge latest changes from master branch >> - http3: add missing separator to Http3Disc

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Jeliński
On Tue, 22 Apr 2025 16:49:10 GMT, Artur Barashev wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 525 commits: >> >> - merge latest changes from master branch >> - http3: run H3StreamLimitReachedTest.java w

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Jeliński
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 17:36:21 GMT, Daniel Jeliński wrote: >> src/java.base/share/classes/jdk/internal/net/quic/QuicTLSContext.java line >> 70: >> >>> 68: if (!(underlyingImpl instanceof SSLContextImpl ssci)) { >>> 69: return false; >>> 70: } >> >> Would there be a wa

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v2]

2025-06-26 Thread Daniel Jeliński
On Mon, 28 Apr 2025 18:52:10 GMT, Sean Mullan wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 409 commits: >> >> - merge latest changes from master branch >> - http3: add missing separator to Http3Discove

Re: RFR: 8359919: Minor java.util.concurrent doc improvements [v19]

2025-06-26 Thread Alan Bateman
On Thu, 26 Jun 2025 10:40:50 GMT, Doug Lea wrote: >> This collects miscellaneous open issues that can be resolved with >> documentation updates; each indicated by adding JDK issue numbers > > Doug Lea has updated the pull request incrementally with one additional > commit since the last revisio

Object.wait returns normally if interrupted

2025-06-26 Thread Pavel Rappo
Here's an interesting behaviour. A thread that has been blocked in Object.wait is interrupted. But instead of throwing an InterruptedException, Object.wait returns normally with the thread's interrupt status set. This behaviour is not mentioned in javadoc, yet I witnessed it. Granted, I could only

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines [v5]

2025-06-26 Thread Brian Burkhalter
On Tue, 24 Jun 2025 19:15:38 GMT, Brian Burkhalter wrote: > > One possibility is to copy the remaining fragment of a line to a new > > transfer buffer (maybe twice the size). > > It's probably worth testing this. In 0ee3f59 I implemented something like this. It is a bit faster than the currec

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines [v5]

2025-06-26 Thread Brian Burkhalter
> Replaces the implementation `readAllCharsAsString().lines().toList()` with > reading into a temporary `char` array which is then processed to detect line > terminators and copy non-terminating characters into strings which are added > to the list. Brian Burkhalter has updated the pull request

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer away from jdk.internal.ref.Cleaner [v6]

2025-06-26 Thread Kim Barrett
> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage > native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences > and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to > use java.lang.ref.Cleaner. > > This change is algorithmica

Re: RFR: 8355177: Speed up StringBuilder::append(char[]) via Unsafe::copyMemory [v8]

2025-06-26 Thread Shaojin Wen
> In BufferedReader.readLine and other similar scenarios, we need to use > StringBuilder.append(char[]) to build the string. > > For these scenarios, we can Unsafe.copyMemory instead of the character copy > of the char-by-char loop to improve the speed. > > @RogerRiggs completed the optimizatio

[jdk25] Integrated: 8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta)

2025-06-26 Thread Jaikiran Pai
On Thu, 26 Jun 2025 13:43:27 GMT, Jaikiran Pai wrote: > Can I please get a review of this backport to JDK 25? This backports > https://bugs.openjdk.org/browse/JDK-8359830 which was integrated into > mainline a few minutes back https://github.com/openjdk/jdk/pull/25865. > > With this change it