On Thu, 26 Jun 2025 06:16:06 GMT, Henry Jen <henry...@openjdk.org> wrote:
>> Create a jar directly from the memory instead of real file, this should
>> reduce the I/O overhead which likely the reason for the time out.
>> The issue is not reproducible locally, and fails intermittently, so we
>> simply trying to reduce time needed.
>> The jar file created is verified manually running jtreg with retain=all.
>
> Henry Jen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright year
test/jdk/tools/jlink/JLink20000Packages.java line 67:
> 65: }
> 66:
> 67: public static void main(String[] args) throws Exception {
The:
private static final ToolProvider JAVAC_TOOL =
ToolProvider.findFirst("javac")
.orElseThrow(() -> new RuntimeException("javac tool not found"));
static void report(String command, String[] args) {
System.out.println(command + " " + String.join(" ",
Arrays.asList(args)));
}
static void javac(String[] args) {
report("javac", args);
JAVAC_TOOL.run(System.out, System.err, args);
}
seems no longer needed/used?
(Otherwise the direction seems sensible to me.)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25981#discussion_r2168949669
