On Mon, 28 Apr 2025 18:52:10 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 409 commits: >> >> - merge latest changes from master branch >> - http3: add missing <p> separator to Http3DiscoveryMode.ALT_SVC API >> documentation >> - http3: improve documentation for Http3DiscoveryMode.ALT_SVC >> - http3: Use AlgorithmConstraints and OCSP responses when validating server >> certificate during QUIC TLS handshake >> - http3: Artur's review - use SecurityUtils.removeFromDisabledTlsAlgs() in >> test >> - http3: minor improvement to log message >> - http3: Artur's review - remove commented out code from test >> - http3: Artur's review - make methods package private >> - http3: qpack - allow 0 capacity when max capacity is 0 >> - Remove flow control from stream limit comments >> - ... and 399 more: https://git.openjdk.org/jdk/compare/1ec64811...4da61bbe > > test/jdk/java/net/httpclient/http3/H3QuicTLSConnection.java line 130: > >> 128: + "expect >> UnsupportedProtocolVersionException", >> 129: () -> connect(uriString, new SSLParameters( >> 130: new String[] { >> "SSL_DHE_RSA_WITH_3DES_EDE_CBC_SHA" }, > > Shouldn't this be "TLS_AES_128_GCM_SHA256" (per the test comment above)? Corrected in 368f9b58736e4eb4f37d043ecd4df28d316fec49 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2169591633
