[GitHub] [pinot] dependabot[bot] opened a new pull request, #9142: Bump gson from 2.2.4 to 2.9.1

dependabot[bot] opened a new pull request, #9142: URL: https://github.com/apache/pinot/pull/9142 Bumps [gson](https://github.com/google/gson) from 2.2.4 to 2.9.1. Release notes Sourced from https://github.com/google/gson/releases";>gson's releases. Gson 2.9.1 Make Obj

[GitHub] [pinot] dependabot[bot] closed pull request #8902: Bump gson from 2.2.4 to 2.9.0

dependabot[bot] closed pull request #8902: Bump gson from 2.2.4 to 2.9.0 URL: https://github.com/apache/pinot/pull/8902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [pinot] dependabot[bot] commented on pull request #8902: Bump gson from 2.2.4 to 2.9.0

dependabot[bot] commented on PR #8902: URL: https://github.com/apache/pinot/pull/8902#issuecomment-1201051057 Superseded by #9142. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[pinot] branch dependabot/maven/com.google.code.gson-gson-2.9.1 created (now a9490a471e)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.code.gson-gson-2.9.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at a9490a471e Bump gson from 2.2.4 to 2.9.1 No new revisions were added by

[GitHub] [pinot] codecov-commenter commented on pull request #9142: Bump gson from 2.2.4 to 2.9.1

codecov-commenter commented on PR #9142: URL: https://github.com/apache/pinot/pull/9142#issuecomment-1201094747 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9142?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9116: [multistage] fix timeout & excessive data block exception

siddharthteotia commented on code in PR #9116: URL: https://github.com/apache/pinot/pull/9116#discussion_r934719159 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryConfig.java: ## @@ -22,6 +22,9 @@ * Configuration for setting up query runtime. */ pu

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934726395 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/CountAggregationFunction.java: ## @@ -75,6 +94,20 @@ public void aggregate(int length, Agg

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934726539 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/CountAggregationFunction.java: ## @@ -75,6 +94,20 @@ public void aggregate(int length, Agg

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934726539 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/CountAggregationFunction.java: ## @@ -75,6 +94,20 @@ public void aggregate(int length, Agg

[GitHub] [pinot] walterddr commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

walterddr commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934734852 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java: ## @@ -81,11 +81,6 @@ public static ExpressionContext getExpression(Expre

[GitHub] [pinot] walterddr commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

walterddr commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934736891 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java: ## @@ -81,11 +81,6 @@ public static ExpressionContext getExpression(Expre

[GitHub] [pinot] walterddr commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

walterddr commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r934734852 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java: ## @@ -81,11 +81,6 @@ public static ExpressionContext getExpression(Expre

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9116: [multistage] fix timeout & excessive data block exception

siddharthteotia commented on code in PR #9116: URL: https://github.com/apache/pinot/pull/9116#discussion_r934749916 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryConfig.java: ## @@ -22,6 +22,9 @@ * Configuration for setting up query runtime. */ pu

[GitHub] [pinot] siddharthteotia merged pull request #9116: [multistage] fix timeout & excessive data block exception

siddharthteotia merged PR #9116: URL: https://github.com/apache/pinot/pull/9116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pino

[pinot] branch master updated: [multistage] fix timeout & excessive data block exception (#9116)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 8ece2147eb [multistage] fix timeout & excessi

[GitHub] [pinot] jasperjiaguo commented on pull request #8163: Put Netty Channel handlers and Tls context creation logic at same place

jasperjiaguo commented on PR #8163: URL: https://github.com/apache/pinot/pull/8163#issuecomment-1201489334 @apucher could you please take a look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pinot] walterddr commented on a diff in pull request #9116: [multistage] fix timeout & excessive data block exception

walterddr commented on code in PR #9116: URL: https://github.com/apache/pinot/pull/9116#discussion_r934752728 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryConfig.java: ## @@ -22,6 +22,9 @@ * Configuration for setting up query runtime. */ public c

[GitHub] [pinot] apucher commented on a diff in pull request #8163: Put Netty Channel handlers and Tls context creation logic at same place

apucher commented on code in PR #8163: URL: https://github.com/apache/pinot/pull/8163#discussion_r934752758 ## pinot-common/src/main/java/org/apache/pinot/common/utils/TlsUtils.java: ## @@ -339,4 +343,49 @@ public Socket createSocket(String host, int port) return _sslSock

[GitHub] [pinot] apucher commented on pull request #8163: Put Netty Channel handlers and Tls context creation logic at same place

apucher commented on PR #8163: URL: https://github.com/apache/pinot/pull/8163#issuecomment-1201499125 Hi folks, would you mind sharing same additional background on why some of the QueryServer code is being factored out into a separate class? I understand the desire for readability, althoug

[GitHub] [pinot] mqliang commented on pull request #8163: Put Netty Channel handlers and Tls context creation logic at same place

mqliang commented on PR #8163: URL: https://github.com/apache/pinot/pull/8163#issuecomment-1201506981 > why some of the QueryServer code is being factored out into a separate class? I understand the desire for readability, although this can be achieved without adding yet another static help

[GitHub] [pinot] apucher commented on pull request #8163: Put Netty Channel handlers and Tls context creation logic at same place

apucher commented on PR #8163: URL: https://github.com/apache/pinot/pull/8163#issuecomment-1201511781 The factory class is entirely static, i.e. it's a utility. The factory/utility methods themselves are only being used within QueryServer. Do you expect to use the factory methods anywhere e

[GitHub] [pinot] siddharthteotia commented on pull request #9123: Add support for regexpReplace scalar function

siddharthteotia commented on PR #9123: URL: https://github.com/apache/pinot/pull/9123#issuecomment-1201544715 @vvivekiyer - can you rebase this once and also look at test failures ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [pinot] klsince commented on a diff in pull request #9141: Initial commit to support cancelling a long running query (WIP)

klsince commented on code in PR #9141: URL: https://github.com/apache/pinot/pull/9141#discussion_r934782007 ## pinot-core/src/main/java/org/apache/pinot/core/util/trace/TraceContext.java: ## @@ -45,9 +49,28 @@ * request from tracing to prevent resource leak. */ public final

[GitHub] [pinot] mqliang commented on pull request #8163: Put Netty Channel handlers and Tls context creation logic at same place

mqliang commented on PR #8163: URL: https://github.com/apache/pinot/pull/8163#issuecomment-1201570215 > The factory/utility methods themselves are only being used within QueryServer Not exactly. They are get used both server side (QueryServer) and client side (ServerChannels) -- T

[GitHub] [pinot] mqliang closed pull request #8163: Put Netty Channel handlers and Tls context creation logic at same place

mqliang closed pull request #8163: Put Netty Channel handlers and Tls context creation logic at same place URL: https://github.com/apache/pinot/pull/8163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pinot] walterddr commented on issue #8966: [multistage] clean up mailbox/datatransfer layer

walterddr commented on issue #8966: URL: https://github.com/apache/pinot/issues/8966#issuecomment-1201587603 closed for #9026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [pinot] walterddr closed issue #8966: [multistage] clean up mailbox/datatransfer layer

walterddr closed issue #8966: [multistage] clean up mailbox/datatransfer layer URL: https://github.com/apache/pinot/issues/8966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pinot] dongxiaoman opened a new pull request, #9144: Avoid swagger loading too much types and showing noisy log

dongxiaoman opened a new pull request, #9144: URL: https://github.com/apache/pinot/pull/9144 ## Description Reduce the reflection scan by Swagger and avoid the new noisy logs. ## Problems to fix With the new Helix 1.0.4 update, somehow if we start Pinot in an large jar files tha

[GitHub] [pinot] codecov-commenter commented on pull request #9144: Avoid swagger loading too much types and showing noisy log

codecov-commenter commented on PR #9144: URL: https://github.com/apache/pinot/pull/9144#issuecomment-1201685879 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9144?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8828: Add controller API for reload segment task status

Jackie-Jiang commented on code in PR #8828: URL: https://github.com/apache/pinot/pull/8828#discussion_r934899690 ## pinot-server/src/main/java/org/apache/pinot/server/api/resources/ControllerJobStatusResource.java: ## @@ -0,0 +1,92 @@ +/** + * Licensed to the Apache Software Fou

[GitHub] [pinot] Jackie-Jiang commented on issue #9128: [Alerting/Monitoring] Add an API to get the server shutDownInProgress config and expose the info at tenant level.

Jackie-Jiang commented on issue #9128: URL: https://github.com/apache/pinot/issues/9128#issuecomment-1201708269 We can definitely add an API to return whether server is ready to serve queries (in addition to `shutDownInProgress` flag, we might also want to track `HELIX_ENABLED` which indica

[GitHub] [pinot] mayankshriv opened a new pull request, #9145: Cleanup: Modify log message to indicate failure reasons when creating data directory on the server.

mayankshriv opened a new pull request, #9145: URL: https://github.com/apache/pinot/pull/9145 The existing log message seemed to suggest that the only reason for not being able to create data directory was due to permissions issues. Modified the log to indicate that it can also happen in cas

[GitHub] [pinot] SabrinaZhaozyf commented on a diff in pull request #9114: Add support for Base64 Encode/Decode Scalar Functions

SabrinaZhaozyf commented on code in PR #9114: URL: https://github.com/apache/pinot/pull/9114#discussion_r934975976 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -560,4 +561,26 @@ public static String decodeUrl(String input)

[GitHub] [pinot] SabrinaZhaozyf commented on a diff in pull request #9114: Add support for Base64 Encode/Decode Scalar Functions

SabrinaZhaozyf commented on code in PR #9114: URL: https://github.com/apache/pinot/pull/9114#discussion_r934976156 ## pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/LiteralOnlyBrokerRequestTest.java: ## @@ -211,6 +219,59 @@ public void testBrokerRequestHandler

[GitHub] [pinot] SabrinaZhaozyf commented on a diff in pull request #9114: Add support for Base64 Encode/Decode Scalar Functions

SabrinaZhaozyf commented on code in PR #9114: URL: https://github.com/apache/pinot/pull/9114#discussion_r934976289 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -560,4 +561,24 @@ public static String decodeUrl(String input)

[GitHub] [pinot] SabrinaZhaozyf commented on a diff in pull request #9114: Add support for Base64 Encode/Decode Scalar Functions

SabrinaZhaozyf commented on code in PR #9114: URL: https://github.com/apache/pinot/pull/9114#discussion_r934976956 ## pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java: ## @@ -1890,6 +1890,41 @@ public void testCompilationInvokedFunction() {

[GitHub] [pinot] SabrinaZhaozyf commented on a diff in pull request #9114: Add support for Base64 Encode/Decode Scalar Functions

SabrinaZhaozyf commented on code in PR #9114: URL: https://github.com/apache/pinot/pull/9114#discussion_r934977816 ## pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/LiteralOnlyBrokerRequestTest.java: ## @@ -104,6 +104,12 @@ public void testLiteralOnlyTransform

[GitHub] [pinot] mqliang closed pull request #7167: Bump up data table version to V4 to optimize space usage.

mqliang closed pull request #7167: Bump up data table version to V4 to optimize space usage. URL: https://github.com/apache/pinot/pull/7167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [pinot] SabrinaZhaozyf commented on a diff in pull request #9114: Add support for Base64 Encode/Decode Scalar Functions

SabrinaZhaozyf commented on code in PR #9114: URL: https://github.com/apache/pinot/pull/9114#discussion_r934980010 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -560,4 +562,42 @@ public static String decodeUrl(String input)

[GitHub] [pinot] SabrinaZhaozyf commented on a diff in pull request #9114: Add support for Base64 Encode/Decode Scalar Functions

SabrinaZhaozyf commented on code in PR #9114: URL: https://github.com/apache/pinot/pull/9114#discussion_r934981212 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -560,4 +562,42 @@ public static String decodeUrl(String input)

[GitHub] [pinot] walterddr merged pull request #9126: fix grpc query server not setting max inbound msg size

walterddr merged PR #9126: URL: https://github.com/apache/pinot/pull/9126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[pinot] branch master updated: fix grpc query server not setting max inbound msg size (#9126)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new bfb604a883 fix grpc query server not setting max i

[GitHub] [pinot] Jackie-Jiang commented on pull request #8979: optimize `order by sorted ASC, unsorted` and `order by DESC` cases

Jackie-Jiang commented on PR #8979: URL: https://github.com/apache/pinot/pull/8979#issuecomment-1201838643 For the `assert` statement, personally I usually use it for documentation purpose to indicate that a condition should always be met based on the calling tree (e.g. a condition is alrea

[GitHub] [pinot] jugomezv commented on a diff in pull request #8753: Streamed segment download & untar with rate limiter to control disk usage

jugomezv commented on code in PR #8753: URL: https://github.com/apache/pinot/pull/8753#discussion_r934994303 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -409,11 +421,35 @@ private File downloadSegmentFromDeepStore(String segme

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9062: [Upsert] persist validDocsIndex snapshot for Pinot upsert optimization

Jackie-Jiang commented on code in PR #9062: URL: https://github.com/apache/pinot/pull/9062#discussion_r934993468 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java: ## @@ -55,12 +55,16 @@ public enum Strategy { @JsonPropertyDescription("Column for

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9134: Add timestamp index fields to schema for the real-time ingestion path

Jackie-Jiang commented on code in PR #9134: URL: https://github.com/apache/pinot/pull/9134#discussion_r935001004 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java: ## @@ -636,7 +636,7 @@ private void setTimestampIndexExpressionOv

[GitHub] [pinot] chenboat commented on issue #8519: [Bug]Pinot broker routes queries to servers while they are still downloading segments

chenboat commented on issue #8519: URL: https://github.com/apache/pinot/issues/8519#issuecomment-1201858785 @mcvsubbu This is not a performance issue but rather a query correctness issue. I also prefer to use the ExternalView as the single place to control the query routing decision rather

[GitHub] [pinot] Jackie-Jiang merged pull request #9138: [Kubernetes] fix jvm processors count

Jackie-Jiang merged PR #9138: URL: https://github.com/apache/pinot/pull/9138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[pinot] branch master updated (bfb604a883 -> 32afa701ab)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from bfb604a883 fix grpc query server not setting max inbound msg size (#9126) add 32afa701ab fix jvm processors count

[pinot] branch master updated (32afa701ab -> 280aad1588)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 32afa701ab fix jvm processors count (#9138) add 280aad1588 Fixing ingress manifest for controller and broker (#913

[GitHub] [pinot] Jackie-Jiang merged pull request #9135: Fixing ingress manifest for controller and broker

Jackie-Jiang merged PR #9135: URL: https://github.com/apache/pinot/pull/9135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[GitHub] [pinot] Jackie-Jiang merged pull request #8972: Add Protocol Buffer Stream Decoder

Jackie-Jiang merged PR #8972: URL: https://github.com/apache/pinot/pull/8972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[GitHub] [pinot] Jackie-Jiang commented on pull request #9139: Enforce java compilation version in pom

Jackie-Jiang commented on PR #9139: URL: https://github.com/apache/pinot/pull/9139#issuecomment-1201872090 We do want to support compiling pinot with java 8 (for prestoDB connector) and versions later than 11. Seems you run into an issue when trying to compile pinot with java 18. We should

[GitHub] [pinot] mcvsubbu commented on issue #8519: [Bug]Pinot broker routes queries to servers while they are still downloading segments

mcvsubbu commented on issue #8519: URL: https://github.com/apache/pinot/issues/8519#issuecomment-1201882228 One thing that can be done is as a part of new server workflow, set the `queriesDisabled` flag in Helix to true. This flag behaves the same as `shutdownInProgress`, except that the se

[GitHub] [pinot] Jackie-Jiang merged pull request #8163: Put Netty Channel handlers and Tls context creation logic at same place

Jackie-Jiang merged PR #8163: URL: https://github.com/apache/pinot/pull/8163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[pinot] branch master updated: Put Netty Channel handlers and Tls context creation logic at same place (#8163)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d0426e9864 Put Netty Channel handlers and Tls con

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

Jackie-Jiang commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r935024683 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/CountAggregationFunction.java: ## @@ -89,7 +122,33 @@ public void aggregate(int length, A

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9145: Cleanup: Modify log message to indicate failure reasons when creating data directory on the server.

Jackie-Jiang commented on code in PR #9145: URL: https://github.com/apache/pinot/pull/9145#discussion_r935032732 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -122,15 +122,16 @@ public void init(TableDataManagerConfig tableDataM

[GitHub] [pinot] mayankshriv commented on a diff in pull request #9145: Cleanup: Modify log message to indicate failure reasons when creating data directory on the server.

mayankshriv commented on code in PR #9145: URL: https://github.com/apache/pinot/pull/9145#discussion_r935042746 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -122,15 +122,16 @@ public void init(TableDataManagerConfig tableDataMa

[GitHub] [pinot] mayankshriv commented on a diff in pull request #9145: Cleanup: Modify log message to indicate failure reasons when creating data directory on the server.

mayankshriv commented on code in PR #9145: URL: https://github.com/apache/pinot/pull/9145#discussion_r935042746 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -122,15 +122,16 @@ public void init(TableDataManagerConfig tableDataMa

[GitHub] [pinot] mayankshriv commented on a diff in pull request #9145: Cleanup: Modify log message to indicate failure reasons when creating data directory on the server.

mayankshriv commented on code in PR #9145: URL: https://github.com/apache/pinot/pull/9145#discussion_r935042746 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -122,15 +122,16 @@ public void init(TableDataManagerConfig tableDataMa

[GitHub] [pinot] mayankshriv commented on a diff in pull request #9145: Cleanup: Modify log message to indicate failure reasons when creating data directory on the server.

mayankshriv commented on code in PR #9145: URL: https://github.com/apache/pinot/pull/9145#discussion_r935042746 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -122,15 +122,16 @@ public void init(TableDataManagerConfig tableDataMa

[GitHub] [pinot] codecov-commenter commented on pull request #9145: Cleanup: Modify log message to indicate failure reasons when creating data directory on the server.

codecov-commenter commented on PR #9145: URL: https://github.com/apache/pinot/pull/9145#issuecomment-1201952643 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9145?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r935075754 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/CountAggregationFunction.java: ## @@ -75,6 +94,20 @@ public void aggregate(int length, Agg

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r935077195 ## pinot-core/src/test/java/org/apache/pinot/queries/BigDecimalQueriesTest.java: ## @@ -387,54 +387,6 @@ public void testQueries() { assertEquals(row[0], BASE

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r935078690 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/CountAggregationFunction.java: ## @@ -89,7 +122,33 @@ public void aggregate(int length, Ag

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r935084912 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/SumAggregationFunction.java: ## @@ -28,13 +30,23 @@ import org.apache.pinot.core.query.a

[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r935085879 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/SumPrecisionAggregationFunction.java: ## @@ -48,8 +51,11 @@ public class SumPrecisionAggr

[GitHub] [pinot] mayankshriv commented on a diff in pull request #9145: Cleanup: Modify log message to indicate failure reasons when creating data directory on the server.

mayankshriv commented on code in PR #9145: URL: https://github.com/apache/pinot/pull/9145#discussion_r935042746 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -122,15 +122,16 @@ public void init(TableDataManagerConfig tableDataMa

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

Jackie-Jiang commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r935139942 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/CountAggregationFunction.java: ## @@ -89,7 +122,33 @@ public void aggregate(int length, A

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9145: Cleanup: Modify log message to indicate failure reasons when creating data directory on the server.

Jackie-Jiang commented on code in PR #9145: URL: https://github.com/apache/pinot/pull/9145#discussion_r935142585 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -122,15 +122,18 @@ public void init(TableDataManagerConfig tableDataM

[GitHub] [pinot] Jackie-Jiang merged pull request #9145: Cleanup: Modify log message to indicate failure reasons when creating data directory on the server.

Jackie-Jiang merged PR #9145: URL: https://github.com/apache/pinot/pull/9145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[pinot] branch master updated: Cleanup: Modify log message to indicate failure reasons when creating data directory on the server. (#9145)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new cc8362fe60 Cleanup: Modify log message to indicat

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8828: Add controller API for reload segment task status

saurabhd336 commented on code in PR #8828: URL: https://github.com/apache/pinot/pull/8828#discussion_r935162064 ## pinot-server/src/main/java/org/apache/pinot/server/api/resources/ControllerJobStatusResource.java: ## @@ -0,0 +1,92 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8828: Add controller API for reload segment task status

saurabhd336 commented on code in PR #8828: URL: https://github.com/apache/pinot/pull/8828#discussion_r935175091 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java: ## @@ -2366,16 +2382,56 @@ public void testJDBCClient()

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8828: Add controller API for reload segment task status

saurabhd336 commented on code in PR #8828: URL: https://github.com/apache/pinot/pull/8828#discussion_r935176493 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java: ## @@ -427,6 +428,21 @@ public void testUploadSegmentRe

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8828: Add controller API for reload segment task status

saurabhd336 commented on code in PR #8828: URL: https://github.com/apache/pinot/pull/8828#discussion_r935176283 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java: ## @@ -2366,16 +2382,56 @@ public void testJDBCClient()