nizarhejazi commented on code in PR #9086:
URL: https://github.com/apache/pinot/pull/9086#discussion_r935078690
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/CountAggregationFunction.java:
##########
@@ -89,7 +122,33 @@ public void aggregate(int length, AggregationResultHolder
aggregationResultHolde
@Override
public void aggregateGroupBySV(int length, int[] groupKeyArray,
GroupByResultHolder groupByResultHolder,
Map<ExpressionContext, BlockValSet> blockValSetMap) {
- if (blockValSetMap.isEmpty()) {
+ if (blockValSetMap.isEmpty() ||
!blockValSetMap.containsKey(STAR_TREE_COUNT_STAR_EXPRESSION)) {
Review Comment:
@Jackie-Jiang We have three branches:
1- blockValSetMap.isEmpty() for count(*), and no StarTree.
2- !blockValSetMap.containsKey(STAR_TREE_COUNT_STAR_EXPRESSION) for
count(columnName), and no StarTree (please see the ! at the beginning).
Example: count(bigDecimalColumn). Note: we can have count(bigDecimalColumn) and
nullHandling is either enable or not enabled.
3- StarTree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
