dongxiaoman opened a new pull request, #9144:
URL: https://github.com/apache/pinot/pull/9144
## Description
Reduce the reflection scan by Swagger and avoid the new noisy logs.
## Problems to fix
With the new Helix 1.0.4 update, somehow if we start Pinot in an large jar
files that contains all our packages, we will see **many** of below warnings
from Swagger init:
```
2022/08/01 18:31:51.243 WARN [Reflections] [Start a Pinot [SERVER]] could
not get type for name
org.hibernate.engine.jdbc.connections.spi.ConnectionProvider from any class
loader
ai.startree.shaded.org.reflections.ReflectionsException: could not get type
for name org.hibernate.engine.jdbc.connections.spi.ConnectionProvider
at
ai.startree.shaded.org.reflections.ReflectionUtils.forName(ReflectionUtils.java:390)
~[startree-pinot-all-0.11.0-SNAPSHOT-jar-with-dependencies.jar:0.11.0-SNAPSHOT]
at
ai.startree.shaded.org.reflections.Reflections.expandSuperTypes(Reflections.java:381)
~[startree-pinot-all-0.11.0-SNAPSHOT-jar-with-dependencies.jar:0.11.0-SNAPSHOT]
at
ai.startree.shaded.org.reflections.Reflections.<init>(Reflections.java:126)
~[startree-pinot-all-0.11.0-SNAPSHOT-jar-with-dependencies.jar:0.11.0-SNAPSHOT-6bce1b2023b8253e658324843ba851f469694b9a]
at io.swagger.jaxrs.config.BeanConfig.classes(BeanConfig.java:288)
~[startree-pinot-all-0.11.0-SNAPSHOT-jar-with-dependencies.jar:0.11.0-SNAPSHOT-6bce1b2023b8253e658324843ba851f469694b9a]
at io.swagger.jaxrs.config.BeanConfig.scanAndRead(BeanConfig.java:250)
~[startree-pinot-all-0.11.0-SNAPSHOT-jar-with-dependencies.jar:0.11.0-SNAPSHOT-6bce1b2023b8253e658324843ba851f469694b9a]
at io.swagger.jaxrs.config.BeanConfig.setScan(BeanConfig.java:231)
~[startree-pinot-all-0.11.0-SNAPSHOT-jar-with-dependencies.jar:0.11.0-SNAPSHOT-6bce1b2023b8253e658324843ba851f469694b9a]
at
org.apache.pinot.server.starter.helix.AdminApiApplication.setupSwagger(AdminApiApplication.java:125)
~[startree-pinot-all-0.11.0-SNAPSHOT-jar-with-dependencies.jar:0.11.0-SNAPSHOT-6bce1b2023b8253e658324843ba851f469694b9a]
```
It shows that the Swagger is actually scanning lots of class types and it is
not helpful anyways.
## Tests done
This log cannot be reproduced in `quick-start` (not sure why), it only shows
up in our pinot-all Docker image run. After this fix the log lines are gone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
