Jackie-Jiang commented on PR #8979: URL: https://github.com/apache/pinot/pull/8979#issuecomment-1201838643
For the `assert` statement, personally I usually use it for documentation purpose to indicate that a condition should always be met based on the calling tree (e.g. a condition is already checked before calling a method), especially in performance critical path. If a condition might not be met when the input is illegal, we can use `Preconditions` instead. For the descending order case, the final solution should be using the reverse iterator. I'd suggest modifying the current PR to optimize ascending order only, and then open a separate PR to add the reverse iterator and optimize the descending order case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
