mqliang commented on PR #8163: URL: https://github.com/apache/pinot/pull/8163#issuecomment-1201506981
> why some of the QueryServer code is being factored out into a separate class? I understand the desire for readability, although this can be achieved without adding yet another static helper class. For readability: - factor out all ChannelHandlers code into class ChannelHandlerFactory - factor out the `attachSSLHandler` functions (both Client side and Server side) into Why add another static helper class: - the method initChannel is called for every new connection that is opened, anything that requires unique state should be constructed inside this method. Thus we should use the factory pattern to get a new object for all the handlers whenever initChannel is called. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
