[GitHub] [pinot] nizarhejazi commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

[GitBox]

nizarhejazi commented on code in PR #9086:
URL: https://github.com/apache/pinot/pull/9086#discussion_r935085879


##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/SumPrecisionAggregationFunction.java:
##########
@@ -48,8 +51,11 @@
 public class SumPrecisionAggregationFunction extends 
BaseSingleInputAggregationFunction<BigDecimal, BigDecimal> {
   private final Integer _precision;
   private final Integer _scale;
+  private final boolean _nullHandlingEnabled;
 
-  public SumPrecisionAggregationFunction(List<ExpressionContext> arguments) {
+  private final Set<Integer> _groupKeysWithNonNullValue;

Review Comment:
   Just noticed that AVG also needs to return null when all input is null. 
Updated both `AVG` and `SumPrecision`:
   
   ```
   SELECT avg(id) as avg, key FROM (VALUES (null, 1), (null, 1), (null, 2), (1, 
3), (null, 3)) AS t(id, key)  GROUP BY key ORDER BY key DESC;
    avg  | key
   ------+-----
     1.0 |   3
    NULL |   2
    NULL |   1
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org