yashmayya merged PR #15256:
URL: https://github.com/apache/pinot/pull/15256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
himanish-star commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r2002387752
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerConfigurationOptions/RebalanceServerConfigurationOptionInteger.ts
somandal commented on PR #15256:
URL: https://github.com/apache/pinot/pull/15256#issuecomment-2733797187
let's also update the latest video in the PR description? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
codecov-commenter commented on PR #15256:
URL: https://github.com/apache/pinot/pull/15256#issuecomment-2734089947
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15256?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
yashmayya commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r2001481701
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerConfigurationOptions/RebalanceServerConfigurationOptionInteger.tsx:
#
himanish-star commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r2001310006
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,150 @@
+export type RebalanceSe
somandal commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1999089433
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,150 @@
+export type RebalanceServerO
somandal commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1999088062
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,145 @@
+export type RebalanceServerO
himanish-star commented on PR #15256:
URL: https://github.com/apache/pinot/pull/15256#issuecomment-2729882087
> @himanish-star can you update the PR description with latest screenshot?
also, I think we can increase the dialog width a bit. maybe md size?
Done!
--
This is an automate
himanish-star commented on PR #15256:
URL: https://github.com/apache/pinot/pull/15256#issuecomment-2729813016
> @himanish-star can you update the PR description with latest screenshot?
also, I think we can increase the dialog width a bit. maybe md size?
Sure 👍🏻
--
This is an autom
jayeshchoudhary commented on PR #15256:
URL: https://github.com/apache/pinot/pull/15256#issuecomment-2729810036
@himanish-star can you update the PR description with latest screenshot?
also, I think we can increase the dialog width a bit. maybe md size?
--
This is an automated message f
himanish-star commented on PR #15256:
URL: https://github.com/apache/pinot/pull/15256#issuecomment-2728508163
@jayeshchoudhary addressed all comments:
- [x] let's add a divider after each section.
- [x] section heading and input label text looks almost same. can we make
input label
himanish-star commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1998143434
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,150 @@
+export type RebalanceSe
himanish-star commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1997965275
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,145 @@
+export type RebalanceSe
jayeshchoudhary commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1993632588
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,145 @@
+export type Rebalance
jayeshchoudhary commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1993636663
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerConfigurationOptions/RebalanceServerConfigurationOptionInteger.
jayeshchoudhary commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1993636663
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerConfigurationOptions/RebalanceServerConfigurationOptionInteger.
jayeshchoudhary commented on PR #15256:
URL: https://github.com/apache/pinot/pull/15256#issuecomment-2721426146
> https://private-user-images.githubusercontent.com/30361728/422021231-f35b6b18-3adf-4d1b-9004-9a1dfb37381b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29t
jayeshchoudhary commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1993632588
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,145 @@
+export type Rebalance
jayeshchoudhary commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1993631824
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,145 @@
+export type Rebalance
somandal commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1992591300
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,145 @@
+export type RebalanceServerO
himanish-star commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1992505810
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,145 @@
+export type RebalanceSe
subCode321 commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1992504754
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,145 @@
+export type RebalanceServe
subCode321 commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1992504754
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,145 @@
+export type RebalanceServe
somandal commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1992262041
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,145 @@
+export type RebalanceServerO
somandal commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1992265800
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,145 @@
+export type RebalanceServerO
somandal commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1992262041
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,145 @@
+export type RebalanceServerO
somandal commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1992047953
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,145 @@
+export type RebalanceServerO
himanish-star commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1992040846
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,145 @@
+export type RebalanceSe
29 matches
Mail list logo
