himanish-star commented on PR #15256:
URL: https://github.com/apache/pinot/pull/15256#issuecomment-2728508163
@jayeshchoudhary addressed all comments:
- [x] let's add a divider after each section.
- [x] section heading and input label text looks almost same. can we make
input label a bit more small / fontWeight light?
Preparation checks when added in alert info seems to be invisible (due to
same blue color). recommend removing checks outside of alert.
<img width="300" alt="image"
src="https://github.com/user-attachments/assets/574d6c5a-d20a-405d-9b5d-432fbc8a8679";
/>
- [x] let's use TextField variant="outlined"
- [x] can we add a tooltip on hover with the reason for breaking changes? I
think Sonam added reason for each breaking change input in the document.
- [x] advanced options preview
<img width="300" alt="image"
src="https://github.com/user-attachments/assets/c1cc1b59-8fc4-415a-b278-077974b50dc1";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
