jayeshchoudhary commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1993632588
##########
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##########
@@ -0,0 +1,145 @@
+export type RebalanceServerOption = {
+ name: string;
+ label: string;
+ type: "BOOL" | "INTEGER" | "SELECT";
+ description: string;
+ defaultValue: string | boolean | number;
+ isAdvancedConfig: boolean;
+ isStatsGatheringConfig: boolean;
+ hasBreakingChange: boolean;
+ allowedValues?: string[];
+}
+
+export const rebalanceServerOptions: RebalanceServerOption[] = [
+ {
+ "name": "dryRun",
+ "defaultValue": false,
+ "label": "Dry Run",
+ "type": "BOOL",
+ "description": "If enabled, rebalance will not run but expected
changes that will occur will be returned",
+ "isAdvancedConfig": false,
+ "isStatsGatheringConfig": true,
+ "hasBreakingChange": false
+ },
+ {
+ "name": "preChecks",
+ "defaultValue": false,
+ "type": "BOOL",
+ "label": "Pre-Checks",
+ "description": "If enabled, will perform some pre-checks to ensure
rebalance is safe, must enable dryRun to enable this",
Review Comment:
can we make type: "BOOL" ... as enum ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
