Re: [PR] [feature] render new options for rebalance server [pinot]

Thu, 13 Mar 2025 07:18:34 -0700 


jayeshchoudhary commented on PR #15256:
URL: https://github.com/apache/pinot/pull/15256#issuecomment-2721426146

   
   > <img alt="image" width="868" 
src="https://private-user-images.githubusercontent.com/30361728/422021231-f35b6b18-3adf-4d1b-9004-9a1dfb37381b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDE4NzUzODMsIm5iZiI6MTc0MTg3NTA4MywicGF0aCI6Ii8zMDM2MTcyOC80MjIwMjEyMzEtZjM1YjZiMTgtM2FkZi00ZDFiLTkwMDQtOWExZGZiMzczODFiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAzMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMzEzVDE0MTEyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVlMDE2ZDc5MjI0YzQ3YThiNjhmYWUyN2M0Mzk3YmNkYjA1ZmQxNDZmNDZhN2ExOGY4NGI2MmNkNGE4ODYwMDMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.bcJhbafauA6Ls-r5lGJWmCFDZ6JWF9vXFTVCSfE1M4o";>
   
   Couple of UX feedback
   1. let's add a divider after each section.
   2. section heading and input label text looks almost same. can we make input 
label a bit more  small / fontWeight light?
   3. Preparation checks when added in alert info seems to be invisible (due to 
same blue color). recommend removing checks outside of alert.
   4. let's use TextField variant="outlined"
   5. can we add a tooltip on hover with the reason for breaking changes? I 
think Sonam added reason for each breaking change input in the document.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to