somandal commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1992265800
##########
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##########
@@ -0,0 +1,145 @@
+export type RebalanceServerOption = {
+ name: string;
+ label: string;
+ type: "BOOL" | "INTEGER" | "SELECT";
+ description: string;
+ defaultValue: string | boolean | number;
+ isAdvancedConfig: boolean;
+ isStatsGatheringConfig: boolean;
+ hasBreakingChange: boolean;
Review Comment:
Also, can we show a tool-tip for all the options marked as
`hasBreakingChange` to explain why? I can share the "why" text in the doc we
have if this is possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
