Re: [PR] Retry on segment cannot build [pinot]

chenboat merged PR #15234: URL: https://github.com/apache/pinot/pull/15234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Retry on segment cannot build [pinot]

lnbest0707-uber commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2004596351 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -267,6 +267,7 @@ public void deleteSegmentFile()

Re: [PR] Retry on segment cannot build [pinot]

lnbest0707-uber commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2004602472 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1093,6 +1093,35 @@ public void seg

Re: [PR] Retry on segment cannot build [pinot]

lnbest0707-uber commented on PR #15234: URL: https://github.com/apache/pinot/pull/15234#issuecomment-2737702374 > > Regarding to pauseless consumption, this issue could also arise and be even more severe(no way to recover). In my opinion, we should introduce similar thing in the /reingest f

Re: [PR] Retry on segment cannot build [pinot]

Jackie-Jiang commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2003929972 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java: ## @@ -297,6 +297,28 @@ public String segmentCommit

Re: [PR] Retry on segment cannot build [pinot]

Jackie-Jiang commented on PR #15234: URL: https://github.com/apache/pinot/pull/15234#issuecomment-2737542977 > Regarding to pauseless consumption, this issue could also arise and be even more severe(no way to recover). In my opinion, we should introduce similar thing in the /reingest failur

Re: [PR] Retry on segment cannot build [pinot]

chenboat commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002274863 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1093,6 +1093,35 @@ public void segmentSto

Re: [PR] Retry on segment cannot build [pinot]

chenboat commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002278498 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1093,6 +1093,35 @@ public void segmentSto

Re: [PR] Retry on segment cannot build [pinot]

chenboat commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002258351 ## pinot-common/src/main/java/org/apache/pinot/common/protocols/SegmentCompletionProtocol.java: ## @@ -123,6 +123,7 @@ public enum ControllerResponseStatus { public

Re: [PR] Retry on segment cannot build [pinot]

lnbest0707-uber commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002285709 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1093,6 +1093,35 @@ public void seg

Re: [PR] Retry on segment cannot build [pinot]

chenboat commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002251422 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1210,6 +1222,19 @@ boolean commitSegment(String control

Re: [PR] Retry on segment cannot build [pinot]

lnbest0707-uber commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002250414 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -267,6 +267,7 @@ public void deleteSegmentFile()

Re: [PR] Retry on segment cannot build [pinot]

lnbest0707-uber commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002206416 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java: ## @@ -297,6 +297,28 @@ public String segmentCom

Re: [PR] Retry on segment cannot build [pinot]

chenboat commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002244114 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -267,6 +267,7 @@ public void deleteSegmentFile() { pr

Re: [PR] Retry on segment cannot build [pinot]

lnbest0707-uber commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002206416 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java: ## @@ -297,6 +297,28 @@ public String segmentCom

Re: [PR] Retry on segment cannot build [pinot]

lnbest0707-uber commented on PR #15234: URL: https://github.com/apache/pinot/pull/15234#issuecomment-2735020908 > This won't work for pauseless consumption because segment build happens after commit. cc @KKcorps @9aman > > Ideally we should try to follow the mechanism introduced in #1

Re: [PR] Retry on segment cannot build [pinot]

Jackie-Jiang commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002191472 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java: ## @@ -297,6 +297,28 @@ public String segmentCommit

Re: [PR] Retry on segment cannot build [pinot]

lnbest0707-uber commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002157712 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManagerTest.java: ## @@ -1386,6 +1393,28 @@ public void

Re: [PR] Retry on segment cannot build [pinot]

chenboat commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002155543 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManagerTest.java: ## @@ -1386,6 +1393,28 @@ public void testGe

Re: [PR] Retry on segment cannot build [pinot]

chenboat commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r2002152540 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/BlockingSegmentCompletionFSM.java: ## @@ -181,6 +181,21 @@ public boolean isDone() {

Re: [PR] Retry on segment cannot build [pinot]

itschrispeck commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r1999349551 ## pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManagerTest.java: ## @@ -1022,7 +1027,13 @@ protected void postStopConsu

Re: [PR] Retry on segment cannot build [pinot]

lnbest0707-uber commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r1999700724 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1093,6 +1093,35 @@ public void seg

Re: [PR] Retry on segment cannot build [pinot]

lnbest0707-uber commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r1999706050 ## pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManagerTest.java: ## @@ -1022,7 +1027,13 @@ protected void postStopCo

Re: [PR] Retry on segment cannot build [pinot]

itschrispeck commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r1999346853 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1093,6 +1093,35 @@ public void segmen

Re: [PR] Retry on segment cannot build [pinot]

itschrispeck commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r1999345423 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -868,6 +869,13 @@ public void run() {

Re: [PR] Retry on segment cannot build [pinot]

lnbest0707-uber commented on code in PR #15234: URL: https://github.com/apache/pinot/pull/15234#discussion_r1990272365 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -868,6 +869,13 @@ public void run() {

[PR] Retry on segment cannot build [pinot]

lnbest0707-uber opened a new pull request, #15234: URL: https://github.com/apache/pinot/pull/15234 `ingestion` feature` When mutable segments get transferred to immutable segments. There are a few preConditions check like - 4GB SV compressed column size - 2G MV num of eleme

Re: [PR] Retry on segment cannot build [pinot]

codecov-commenter commented on PR #15234: URL: https://github.com/apache/pinot/pull/15234#issuecomment-2711658176 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15234?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u