yashmayya merged PR #15733:
URL: https://github.com/apache/pinot/pull/15733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
abhishekbafna commented on code in PR #15733:
URL: https://github.com/apache/pinot/pull/15733#discussion_r2080985925
##
pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotLogicalTableResourceTest.java:
##
@@ -199,15 +200,46 @@ public void testLogicalTa
yashmayya closed issue #15708: [Logical Tables] Enforce Schema
URL: https://github.com/apache/pinot/issues/15708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
This is an automated email from the ASF dual-hosted git repository.
yashmayya pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 980b5d04b3 Logical table schema enforcement. (
abhishekbafna commented on code in PR #15733:
URL: https://github.com/apache/pinot/pull/15733#discussion_r2080989296
##
pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotLogicalTableResourceTest.java:
##
@@ -199,15 +200,46 @@ public void testLogicalTa
abhishekbafna commented on code in PR #15733:
URL: https://github.com/apache/pinot/pull/15733#discussion_r2080972376
##
pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotLogicalTableResourceTest.java:
##
@@ -199,15 +200,46 @@ public void testLogicalTa
yashmayya commented on code in PR #15733:
URL: https://github.com/apache/pinot/pull/15733#discussion_r2080973032
##
pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotLogicalTableResourceTest.java:
##
@@ -199,15 +200,46 @@ public void testLogicalTableV
abhishekbafna commented on code in PR #15733:
URL: https://github.com/apache/pinot/pull/15733#discussion_r2080971716
##
pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotLogicalTableResourceTest.java:
##
@@ -199,15 +200,46 @@ public void testLogicalTa
vrajat opened a new issue, #15749:
URL: https://github.com/apache/pinot/issues/15749
This task depends on the following:
* https://github.com/apache/pinot/issues/15656
* https://github.com/apache/pinot/issues/15640
--
This is an automated message from the Apache Git Service.
To r
vvivekiyer commented on code in PR #15716:
URL: https://github.com/apache/pinot/pull/15716#discussion_r2080914942
##
pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java:
##
@@ -219,7 +219,9 @@ public enum ControllerGauge implements
AbstractMetrics.Ga
vrajat commented on code in PR #15720:
URL: https://github.com/apache/pinot/pull/15720#discussion_r2080922930
##
pinot-common/src/main/java/org/apache/pinot/common/config/provider/TableCache.java:
##
@@ -663,6 +665,30 @@ public synchronized void handleDataDeleted(String path) {
abhishekbafna commented on code in PR #15733:
URL: https://github.com/apache/pinot/pull/15733#discussion_r2080921594
##
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/PinotHelixPropertyStoreZnRecordProvider.java:
##
@@ -44,7 +44,7 @@ public static PinotHelixPrope
vrajat commented on code in PR #15733:
URL: https://github.com/apache/pinot/pull/15733#discussion_r2080916797
##
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/PinotHelixPropertyStoreZnRecordProvider.java:
##
@@ -44,7 +44,7 @@ public static PinotHelixPropertyStor
abhishekbafna commented on code in PR #15720:
URL: https://github.com/apache/pinot/pull/15720#discussion_r2080914414
##
pinot-common/src/main/java/org/apache/pinot/common/config/provider/TableCache.java:
##
@@ -363,14 +366,13 @@ private void putTableConfig(ZNRecord znRecord)
codecov-commenter commented on PR #15746:
URL: https://github.com/apache/pinot/pull/15746#issuecomment-2864864654
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15746?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
wirybeaver commented on code in PR #15203:
URL: https://github.com/apache/pinot/pull/15203#discussion_r2080763311
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/adaptiveserverselector/PriorityGroupInstanceSelector.java:
##
@@ -0,0 +1,194 @@
+/**
+ * Licensed to th
wirybeaver commented on code in PR #15203:
URL: https://github.com/apache/pinot/pull/15203#discussion_r2080762124
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/adaptiveserverselector/PriorityGroupInstanceSelector.java:
##
@@ -0,0 +1,194 @@
+/**
+ * Licensed to th
codecov-commenter commented on PR #15747:
URL: https://github.com/apache/pinot/pull/15747#issuecomment-2864876340
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15747?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
Jackie-Jiang commented on code in PR #15685:
URL: https://github.com/apache/pinot/pull/15685#discussion_r2080736600
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java:
##
@@ -117,9 +131,15 @@ private void addFlattened
Jackie-Jiang opened a new pull request, #15747:
URL: https://github.com/apache/pinot/pull/15747
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
chenboat commented on code in PR #15203:
URL: https://github.com/apache/pinot/pull/15203#discussion_r2039973082
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/adaptiveserverselector/PriorityGroupInstanceSelector.java:
##
@@ -0,0 +1,194 @@
+/**
+ * Licensed to the
codecov-commenter commented on PR #15745:
URL: https://github.com/apache/pinot/pull/15745#issuecomment-2864826546
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15745?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
somandal commented on code in PR #15617:
URL: https://github.com/apache/pinot/pull/15617#discussion_r2080683879
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -1524,67 +1535,336 @@ private static void handleErrorIns
Jackie-Jiang opened a new pull request, #15746:
URL: https://github.com/apache/pinot/pull/15746
- Always use the one from `SegmentDirectory` to avoid bugs introduced by
inconsistent segment metadata
- Reduce some unnecessary metadata load
--
This is an automated message from the Apache
somandal commented on code in PR #15617:
URL: https://github.com/apache/pinot/pull/15617#discussion_r2080686074
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -1524,67 +1535,336 @@ private static void handleErrorIns
somandal commented on code in PR #15617:
URL: https://github.com/apache/pinot/pull/15617#discussion_r2080689742
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -1524,67 +1535,336 @@ private static void handleErrorIns
somandal commented on code in PR #15617:
URL: https://github.com/apache/pinot/pull/15617#discussion_r2080689596
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##
@@ -625,6 +625,13 @@ public RebalanceResult rebalance(
somandal commented on code in PR #15617:
URL: https://github.com/apache/pinot/pull/15617#discussion_r2080686074
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -1524,67 +1535,336 @@ private static void handleErrorIns
somandal commented on code in PR #15617:
URL: https://github.com/apache/pinot/pull/15617#discussion_r2080680182
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -1524,67 +1535,336 @@ private static void handleErrorIns
UOETianleZhang commented on code in PR #15739:
URL: https://github.com/apache/pinot/pull/15739#discussion_r2080668807
##
.github/workflows/scripts/.pinot_linter.sh:
##
@@ -25,9 +25,8 @@ java -version
ifconfig
netstat -i
-
mvn -B -ntp -T1C license:check || exit 1
mvn -B -nt
Jackie-Jiang commented on issue #15440:
URL: https://github.com/apache/pinot/issues/15440#issuecomment-2864776827
Created #15745 to mimic the flow, which passed without problem. Do you have
a deeper stack trace?
Any chance you added TIMESTAMP index to this column?
--
This is an automat
Jackie-Jiang opened a new pull request, #15745:
URL: https://github.com/apache/pinot/pull/15745
Attempted to re-produce #15440 but no luck.
It is good to add this test anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
jadami10 commented on PR #14982:
URL: https://github.com/apache/pinot/pull/14982#issuecomment-2864745852
what does preprocess do, and when would you want to skip it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
praveenc7 commented on code in PR #15716:
URL: https://github.com/apache/pinot/pull/15716#discussion_r2080645156
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/ControllerAdminApiApplication.java:
##
@@ -130,4 +140,54 @@ public void filter(ContainerRequestConte
codecov-commenter commented on PR #15739:
URL: https://github.com/apache/pinot/pull/15739#issuecomment-2864688283
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15739?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
Jackie-Jiang commented on PR #15611:
URL: https://github.com/apache/pinot/pull/15611#issuecomment-2864574178
Proceed with #15692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
Jackie-Jiang closed pull request #15611: Fix multi-stage case insensitiveness
URL: https://github.com/apache/pinot/pull/15611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Jackie-Jiang commented on code in PR #15591:
URL: https://github.com/apache/pinot/pull/15591#discussion_r2080514969
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/IndexService.java:
##
@@ -58,6 +59,7 @@ public class IndexService {
private final List>
Jackie-Jiang commented on issue #15675:
URL: https://github.com/apache/pinot/issues/15675#issuecomment-2864564570
> We want to solve this problem for 2 cases: 1. SegmentRefresh 2. Server
Restarts. Is the idea here to fork out the queries to additional servers but
not use the result from the
Jackie-Jiang commented on code in PR #15733:
URL: https://github.com/apache/pinot/pull/15733#discussion_r2080289090
##
pinot-common/src/main/java/org/apache/pinot/common/utils/LogicalTableUtils.java:
##
@@ -74,7 +76,7 @@ public static ZNRecord toZNRecord(LogicalTableConfig
logi
Jackie-Jiang commented on code in PR #15726:
URL: https://github.com/apache/pinot/pull/15726#discussion_r2080230117
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##
@@ -2050,6 +2092,40 @@ public void setExistingTableConf
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from d6e37012d6 Enhance OfflineClusterIntegrationTest to check index size
and fix index removal for default column (#15740)
Jackie-Jiang merged PR #15692:
URL: https://github.com/apache/pinot/pull/15692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang merged PR #15740:
URL: https://github.com/apache/pinot/pull/15740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #15726:
URL: https://github.com/apache/pinot/pull/15726#discussion_r2080216939
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##
@@ -417,6 +417,12 @@ public synchronized void includeServerToRouting(St
Jackie-Jiang commented on code in PR #15725:
URL: https://github.com/apache/pinot/pull/15725#discussion_r2080298572
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableViews.java:
##
@@ -144,11 +148,28 @@ public String getSegmentsStatusDetails(
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new d6e37012d6 Enhance OfflineClusterIntegrationTest
Jackie-Jiang commented on code in PR #15726:
URL: https://github.com/apache/pinot/pull/15726#discussion_r2080196255
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##
@@ -417,6 +417,12 @@ public synchronized void includeServerToRouting(St
somandal commented on code in PR #15617:
URL: https://github.com/apache/pinot/pull/15617#discussion_r2080212649
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -1595,13 +1875,41 @@ private static Map>
getNextNonStri
somandal commented on code in PR #15617:
URL: https://github.com/apache/pinot/pull/15617#discussion_r2079974548
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -1524,67 +1535,336 @@ private static void handleErrorIns
Jackie-Jiang commented on code in PR #15726:
URL: https://github.com/apache/pinot/pull/15726#discussion_r2080196255
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##
@@ -417,6 +417,12 @@ public synchronized void includeServerToRouting(St
ankitsultana opened a new pull request, #15743:
URL: https://github.com/apache/pinot/pull/15743
# Summary
**Goal:** Prototype the MSE Lite Mode to enable testing in our clusters so
we can make informed decisions about its semantics and overall guarantees.
(e.g. what is the most intui
vrajat commented on code in PR #15720:
URL: https://github.com/apache/pinot/pull/15720#discussion_r2080070650
##
pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotLogicalTableResourceTest.java:
##
@@ -128,91 +132,183 @@ public void testCreateUpdateDel
codecov-commenter commented on PR #15743:
URL: https://github.com/apache/pinot/pull/15743#issuecomment-2863640133
:x: We are unable to process any of the uploaded JUnit XML files. Please
ensure your files are in the right format.
--
This is an automated message from the Apache Git Service
ankitsultana commented on code in PR #15743:
URL: https://github.com/apache/pinot/pull/15743#discussion_r2080001777
##
pinot-query-planner/src/test/resources/queries/PhysicalOptimizerPlans.json:
##
@@ -421,5 +421,104 @@
]
}
]
+ },
+ "physical_opt_lite_mode
somandal commented on code in PR #15617:
URL: https://github.com/apache/pinot/pull/15617#discussion_r2079974548
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -1524,67 +1535,336 @@ private static void handleErrorIns
ankitsultana commented on code in PR #15743:
URL: https://github.com/apache/pinot/pull/15743#discussion_r2079995355
##
pinot-query-planner/src/test/resources/queries/PhysicalOptimizerPlans.json:
##
@@ -421,5 +421,104 @@
]
}
]
+ },
+ "physical_opt_lite_mode
somandal commented on code in PR #15617:
URL: https://github.com/apache/pinot/pull/15617#discussion_r2079976643
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -1524,67 +1535,336 @@ private static void handleErrorIns
albertobastos closed pull request #15502: do not apply SSE always-false empty
response optimization if query includes aggregations
URL: https://github.com/apache/pinot/pull/15502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
albertobastos commented on PR #15502:
URL: https://github.com/apache/pinot/pull/15502#issuecomment-2863463850
Finally fixed with a new (and proper strategy) on
https://github.com/apache/pinot/pull/15703, closing this one.
--
This is an automated message from the Apache Git Service.
To res
yashmayya commented on code in PR #15617:
URL: https://github.com/apache/pinot/pull/15617#discussion_r2079510950
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##
@@ -625,6 +625,13 @@ public RebalanceResult rebalance(
abhishekbafna commented on code in PR #15733:
URL: https://github.com/apache/pinot/pull/15733#discussion_r2079666999
##
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/PinotHelixPropertyStoreZnRecordProvider.java:
##
@@ -51,6 +51,10 @@ public static PinotHelixProp
abhishekbafna commented on code in PR #15733:
URL: https://github.com/apache/pinot/pull/15733#discussion_r2079663078
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##
@@ -1637,6 +1637,12 @@ public Schema getSchemaForTable
abhishekbafna commented on code in PR #15733:
URL: https://github.com/apache/pinot/pull/15733#discussion_r2079661607
##
pinot-common/src/main/java/org/apache/pinot/common/utils/LogicalTableUtils.java:
##
@@ -74,7 +76,7 @@ public static ZNRecord toZNRecord(LogicalTableConfig
log
codecov-commenter commented on PR #15733:
URL: https://github.com/apache/pinot/pull/15733#issuecomment-2862952808
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15733?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
dependabot[bot] opened a new pull request, #15742:
URL: https://github.com/apache/pinot/pull/15742
Bumps software.amazon.awssdk:bom from 2.31.37 to 2.31.38.
Most Recent Ignore Conditions Applied to This Pull Request
| Dependency Name | Ignore Conditions |
| --- | --- |
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.31.38
in repository https://gitbox.apache.org/repos/asf/pinot.git
at ce91b112c9 Bump software.amazon.awssdk:bom from 2.31.37 to 2.31.38
N
abhishekbafna commented on code in PR #15726:
URL: https://github.com/apache/pinot/pull/15726#discussion_r2079154760
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##
@@ -417,6 +417,12 @@ public synchronized void includeServerToRouting(S
albertobastos commented on code in PR #15692:
URL: https://github.com/apache/pinot/pull/15692#discussion_r2079050965
##
pinot-common/src/main/java/org/apache/pinot/common/catalog/PinotNameMatcher.java:
##
@@ -0,0 +1,121 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
This is an automated email from the ASF dual-hosted git repository.
yashmayya pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 4b77f8ba0d Broker selection for logical tables
vrajat commented on code in PR #15726:
URL: https://github.com/apache/pinot/pull/15726#discussion_r2079176460
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##
@@ -417,6 +417,12 @@ public synchronized void includeServerToRouting(String
abhishekbafna commented on PR #15720:
URL: https://github.com/apache/pinot/pull/15720#issuecomment-2862211341
> Can you check the test failures ? I'll approve after that.
I am looking into the unit tests. They do pass locally.
--
This is an automated message from the Apache Git Serv
yashmayya merged PR #15726:
URL: https://github.com/apache/pinot/pull/15726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
yashmayya closed issue #15639: [Logical Table] Support Broker Tenants
URL: https://github.com/apache/pinot/issues/15639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
abhishekbafna commented on code in PR #15726:
URL: https://github.com/apache/pinot/pull/15726#discussion_r2079168262
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##
@@ -417,6 +417,12 @@ public synchronized void includeServerToRouting(S
abhishekbafna commented on code in PR #15726:
URL: https://github.com/apache/pinot/pull/15726#discussion_r2079154760
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##
@@ -417,6 +417,12 @@ public synchronized void includeServerToRouting(S
yashmayya commented on code in PR #15726:
URL: https://github.com/apache/pinot/pull/15726#discussion_r2079141829
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##
@@ -417,6 +417,12 @@ public synchronized void includeServerToRouting(Strin
hpvd commented on issue #15704:
URL: https://github.com/apache/pinot/issues/15704#issuecomment-2862157267
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
abhishekbafna commented on PR #15728:
URL: https://github.com/apache/pinot/pull/15728#issuecomment-2862155937
> Thanks for the fix!
>
> Merging it now. @abhishekbafna can you please confirm this fixes the
problem?
This is fixed now. Thank you Himanshu for quick fix.
--
This
hpvd commented on issue #14572:
URL: https://github.com/apache/pinot/issues/14572#issuecomment-2862131792
as @Jackie-Jiang identified, this is related to
https://github.com/apache/pinot/issues/15727
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
vrajat commented on code in PR #15726:
URL: https://github.com/apache/pinot/pull/15726#discussion_r2079103006
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##
@@ -417,6 +417,12 @@ public synchronized void includeServerToRouting(String
vrajat commented on code in PR #15726:
URL: https://github.com/apache/pinot/pull/15726#discussion_r2079094865
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##
@@ -417,6 +417,12 @@ public synchronized void includeServerToRouting(String
vrajat commented on code in PR #15726:
URL: https://github.com/apache/pinot/pull/15726#discussion_r2079094865
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##
@@ -417,6 +417,12 @@ public synchronized void includeServerToRouting(String
abhishekbafna commented on code in PR #15726:
URL: https://github.com/apache/pinot/pull/15726#discussion_r2079083100
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##
@@ -417,6 +417,12 @@ public synchronized void includeServerToRouting(S
yashmayya commented on code in PR #15726:
URL: https://github.com/apache/pinot/pull/15726#discussion_r2079063374
##
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##
@@ -417,6 +417,12 @@ public synchronized void includeServerToRouting(Strin
vrajat commented on code in PR #15720:
URL: https://github.com/apache/pinot/pull/15720#discussion_r2079027965
##
pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotLogicalTableResourceTest.java:
##
@@ -129,90 +133,191 @@ public void testCreateUpdateDel
abhishekbafna commented on code in PR #15720:
URL: https://github.com/apache/pinot/pull/15720#discussion_r2079052056
##
pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotLogicalTableResourceTest.java:
##
@@ -129,90 +133,191 @@ public void testCreateUp
abhishekbafna commented on code in PR #15720:
URL: https://github.com/apache/pinot/pull/15720#discussion_r2079048504
##
pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotLogicalTableResourceTest.java:
##
@@ -129,90 +133,191 @@ public void testCreateUp
88 matches
Mail list logo