Jackie-Jiang commented on code in PR #15733: URL: https://github.com/apache/pinot/pull/15733#discussion_r2080289090
########## pinot-common/src/main/java/org/apache/pinot/common/utils/LogicalTableUtils.java: ########## @@ -74,7 +76,7 @@ public static ZNRecord toZNRecord(LogicalTableConfig logicalTableConfig) } public static void validateLogicalTableName(LogicalTableConfig logicalTableConfig, List<String> allPhysicalTables, Review Comment: Not introduced in this PR, but passing all physical table names as list and search in it is not efficient. Given this class is within the `pinot-common` package, we can pass in some lambda which returns a boolean indicating whether a table, tenant, schema exists. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
