vrajat commented on code in PR #15726:
URL: https://github.com/apache/pinot/pull/15726#discussion_r2079094865
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##########
@@ -417,6 +417,12 @@ public synchronized void includeServerToRouting(String
instanceId) {
* Builds/rebuilds the routing for the given table.
*/
public synchronized void buildRouting(String tableNameWithType) {
+ // skip route building for logical tables
+ if (ZKMetadataProvider.isLogicalTableExists(_propertyStore,
tableNameWithType)) {
Review Comment:
@abhishekbafna I think it will help if you paste example IS/EV after this
change.
Details:
https://docs.google.com/document/d/1iS0wtG_V2-W9sQsKkziMjTljT5qKAH_hhsksXr1Tvys/edit?tab=t.0#heading=h.vf97hyarsl5h
tl;dr:
A new entry is made in `brokerResource` for logical tables with the list of
applicable brokers and whether they are online/offline. This call is made from
the `BrokerResourceOnlineOfflineStateModel`. Since logical tables do not have
any segments, this call has to be short-circuited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
