vvivekiyer commented on code in PR #15716:
URL: https://github.com/apache/pinot/pull/15716#discussion_r2080914942
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java:
##########
@@ -219,7 +219,9 @@ public enum ControllerGauge implements
AbstractMetrics.Gauge {
DEEP_STORE_WRITE_OPS_IN_PROGRESS("deepStoreWriteOpsInProgress", true),
// The progress of a certain table rebalance job of a table
- TABLE_REBALANCE_JOB_PROGRESS_PERCENT("percent", false);
+ TABLE_REBALANCE_JOB_PROGRESS_PERCENT("percent", false),
+ // HTTP thread utilization percent
+ HTTP_THREAD_UTILIZATION_PERCENT("httpThreadUtilizationPercent", true);
Review Comment:
(nit) HTTP_THREAD_UTILIZATION should be sufficient.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##########
@@ -608,6 +608,7 @@ protected void configure() {
LOGGER.info("Starting controller admin application on: {}",
ListenerConfigUtil.toString(_listenerConfigs));
_adminApp.start(_listenerConfigs);
+ _adminApp.registerHttpThreadUtilizationGauge(_controllerMetrics);
Review Comment:
(nit) move this to the _adminApp.start() function? We can pass
controllerMetrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
