vrajat commented on code in PR #15733:
URL: https://github.com/apache/pinot/pull/15733#discussion_r2080916797
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/PinotHelixPropertyStoreZnRecordProvider.java:
##########
@@ -44,7 +44,7 @@ public static PinotHelixPropertyStoreZnRecordProvider
forSchema(ZkHelixPropertyS
}
public static PinotHelixPropertyStoreZnRecordProvider
forTable(ZkHelixPropertyStore<ZNRecord> propertyStore) {
- return new PinotHelixPropertyStoreZnRecordProvider(propertyStore,
"/CONFIGS/TABLES");
+ return new PinotHelixPropertyStoreZnRecordProvider(propertyStore,
"/CONFIGS/TABLE");
Review Comment:
Or is this fly-by fix (unrelated to the changes in this PR) ?
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/PinotHelixPropertyStoreZnRecordProvider.java:
##########
@@ -44,7 +44,7 @@ public static PinotHelixPropertyStoreZnRecordProvider
forSchema(ZkHelixPropertyS
}
public static PinotHelixPropertyStoreZnRecordProvider
forTable(ZkHelixPropertyStore<ZNRecord> propertyStore) {
- return new PinotHelixPropertyStoreZnRecordProvider(propertyStore,
"/CONFIGS/TABLES");
+ return new PinotHelixPropertyStoreZnRecordProvider(propertyStore,
"/CONFIGS/TABLE");
Review Comment:
How did you find this ? DId you add a new test ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
