yashmayya commented on code in PR #15726:
URL: https://github.com/apache/pinot/pull/15726#discussion_r2079063374
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##########
@@ -417,6 +417,12 @@ public synchronized void includeServerToRouting(String
instanceId) {
* Builds/rebuilds the routing for the given table.
*/
public synchronized void buildRouting(String tableNameWithType) {
+ // skip route building for logical tables
+ if (ZKMetadataProvider.isLogicalTableExists(_propertyStore,
tableNameWithType)) {
Review Comment:
I presume this will only happen if a user explicitly calls the `PUT
/routing/{tableName}` broker API with a logical table name since we won't have
actual state transitions for logical tables that could trigger this routing
update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
