(pinot) branch master updated: [pinot-avro plugin] by default enable logical types support (#15654)

2025-05-05 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new debbb6df6f [pinot-avro plugin] by default enable

Re: [PR] [pinot-avro plugin] by default enable logical types support [pinot]

2025-05-05 Thread via GitHub
xiangfu0 merged PR #15654: URL: https://github.com/apache/pinot/pull/15654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-05-05 Thread via GitHub
vrajat commented on code in PR #15388: URL: https://github.com/apache/pinot/pull/15388#discussion_r2074744804 ## pinot-core/src/main/java/org/apache/pinot/core/transport/ImplicitHybridTableRouteInfo.java: ## @@ -0,0 +1,370 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-05-05 Thread via GitHub
vrajat commented on code in PR #15388: URL: https://github.com/apache/pinot/pull/15388#discussion_r2074743868 ## pinot-core/src/main/java/org/apache/pinot/core/transport/QueryRouter.java: ## @@ -92,6 +88,16 @@ public AsyncQueryResponse submitQuery(long requestId, String rawTabl

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-05-05 Thread via GitHub
vrajat commented on code in PR #15388: URL: https://github.com/apache/pinot/pull/15388#discussion_r2074743454 ## pinot-core/src/main/java/org/apache/pinot/core/transport/ImplicitHybridTableRouteInfo.java: ## @@ -0,0 +1,370 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-05-05 Thread via GitHub
vrajat commented on code in PR #15388: URL: https://github.com/apache/pinot/pull/15388#discussion_r2074741444 ## pinot-core/src/main/java/org/apache/pinot/core/transport/ImplicitHybridTableRouteInfo.java: ## @@ -0,0 +1,370 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [PR] Metric for HTTP Thread Utilization (Controller) [pinot]

2025-05-05 Thread via GitHub
codecov-commenter commented on PR #15716: URL: https://github.com/apache/pinot/pull/15716#issuecomment-2853280904 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15716?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-05-05 Thread via GitHub
vrajat commented on PR #15388: URL: https://github.com/apache/pinot/pull/15388#issuecomment-2853254490 > Mostly good. Can you please rebase it to the latest master? Rebased. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Create proper response when all segments are pruned on broker [pinot]

2025-05-05 Thread via GitHub
yashmayya commented on code in PR #15703: URL: https://github.com/apache/pinot/pull/15703#discussion_r2074717729 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/EmptyResponseUtils.java: ## @@ -0,0 +1,206 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Create proper response when all segments are pruned on broker [pinot]

2025-05-05 Thread via GitHub
yashmayya commented on code in PR #15703: URL: https://github.com/apache/pinot/pull/15703#discussion_r2074716127 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ## @@ -1024,25 +1024,49 @@ private static String getRou

Re: [PR] Create proper response when all segments are pruned on broker [pinot]

2025-05-05 Thread via GitHub
yashmayya commented on code in PR #15703: URL: https://github.com/apache/pinot/pull/15703#discussion_r2072833382 ## pinot-common/src/main/java/org/apache/pinot/common/cursors/AbstractResponseStore.java: ## @@ -185,7 +185,7 @@ public CursorResponse handleCursorRequest(String requ

[PR] Metric for HTTP Thread Utilization [pinot]

2025-05-05 Thread via GitHub
praveenc7 opened a new pull request, #15716: URL: https://github.com/apache/pinot/pull/15716 ## Summary Metric for HTTP Thread Utilization to increase observability in thread utilization ## Testing Done TODO -- This is an automated message from the Apache Git Service. To

Re: [PR] Metric for HTTP Thread Utilization [pinot]

2025-05-05 Thread via GitHub
praveenc7 closed pull request #15715: Metric for HTTP Thread Utilization URL: https://github.com/apache/pinot/pull/15715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-05 Thread via GitHub
yashmayya commented on PR #15618: URL: https://github.com/apache/pinot/pull/15618#issuecomment-2853223987 > > > Before this PR, if we set externalViewStabilizationTimeoutInMs=1ms, regular run will fail after 1ms wait, while bestEfforts continue the next step after 1ms. > > >

[PR] Metric for HTTP Thread Utilization [pinot]

2025-05-05 Thread via GitHub
praveenc7 opened a new pull request, #15715: URL: https://github.com/apache/pinot/pull/15715 ## Summary Metric for HTTP Thread Utilization ## Description ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Make variables and a method protected to extend from DefaultTableDataManagerProvider & BaseTableDataManager [pinot]

2025-05-05 Thread via GitHub
deepthi912 closed pull request #15598: Make variables and a method protected to extend from DefaultTableDataManagerProvider & BaseTableDataManager URL: https://github.com/apache/pinot/pull/15598 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] Automate License and Notice Binary update manual step [pinot]

2025-05-05 Thread via GitHub
destrex271 commented on issue #15460: URL: https://github.com/apache/pinot/issues/15460#issuecomment-2853001105 Hi @abhioncbr , I opened a draft PR a while back. Would love to get your input on this. The current implementation is able to find which dependencies were removed, added or upgrad

(pinot) branch master updated: [timeseries] Add Metadata Provider to Time Series Query Planner (#15604)

2025-05-05 Thread ankitsultana
This is an automated email from the ASF dual-hosted git repository. ankitsultana pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 78504647a9 [timeseries] Add Metadata Provid

Re: [PR] [timeseries] Add Metadata Provider to Time Series Query Planner [pinot]

2025-05-05 Thread via GitHub
ankitsultana merged PR #15604: URL: https://github.com/apache/pinot/pull/15604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [I] PageCache Warmup During Server Restart and Segment Refresh [pinot]

2025-05-05 Thread via GitHub
praveenc7 commented on issue #15675: URL: https://github.com/apache/pinot/issues/15675#issuecomment-2852821812 > One challenge is to figure out the pages to cache. Do you plan to shadow some queries to the segments so that cache can be warmed up based on the live traffic? @Jackie-Jia

Re: [PR] Log IS update failures in ensureAllPartitionsConsuming [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang commented on code in PR #15673: URL: https://github.com/apache/pinot/pull/15673#discussion_r2074294144 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotTableIdealStateBuilder.java: ## @@ -96,9 +98,15 @@ public static List getPartitionGr

Re: [I] Swagger UI does not respect Knox gateway path during redirection [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang closed issue #15706: Swagger UI does not respect Knox gateway path during redirection URL: https://github.com/apache/pinot/issues/15706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] roundDecimal() fails for null FLOAT values [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang commented on code in PR #15377: URL: https://github.com/apache/pinot/pull/15377#discussion_r2074285164 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/RoundDecimalTransformFunction.java: ## @@ -90,18 +90,31 @@ public double[] transformT

Re: [PR] Adding null check in fromZNRecord while creating InstancePartitions from ZNRecord [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang commented on PR #15693: URL: https://github.com/apache/pinot/pull/15693#issuecomment-2852469125 Please rebase the PR properly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

(pinot) branch master updated: [multistage] Support Physical Optimizer E2E (#15698)

2025-05-05 Thread ankitsultana
This is an automated email from the ASF dual-hosted git repository. ankitsultana pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new a231dbbe43 [multistage] Support Physical Op

Re: [PR] [multistage] Support Physical Optimizer E2E [pinot]

2025-05-05 Thread via GitHub
ankitsultana merged PR #15698: URL: https://github.com/apache/pinot/pull/15698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] [multistage] Support Physical Optimizer E2E [pinot]

2025-05-05 Thread via GitHub
shauryachats commented on code in PR #15698: URL: https://github.com/apache/pinot/pull/15698#discussion_r2074272751 ## pinot-query-planner/src/test/resources/queries/PhysicalOptimizerPlans.json: ## @@ -0,0 +1,425 @@ +{ + "physical_opt_join_planning_tests": { +"queries": [ +

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang commented on code in PR #15388: URL: https://github.com/apache/pinot/pull/15388#discussion_r2074260352 ## pinot-core/src/main/java/org/apache/pinot/core/transport/ImplicitHybridTableRouteInfo.java: ## @@ -0,0 +1,370 @@ +/** + * Licensed to the Apache Software Founda

Re: [I] PageCache Warmup During Server Restart and Segment Refresh [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang commented on issue #15675: URL: https://github.com/apache/pinot/issues/15675#issuecomment-2852410971 One challenge is to figure out the pages to cache. Do you plan to shadow some queries to the segments so that cache can be warmed up based on the live traffic? -- This is an

Re: [I] taskMaxNumFiles is being ignored [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang commented on issue #15666: URL: https://github.com/apache/pinot/issues/15666#issuecomment-2852401807 @KKcorps @swaminathanmanish Please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Add segment end criteria check for SVForwardIndex and Dictionary [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang merged PR #15120: URL: https://github.com/apache/pinot/pull/15120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (7fc0f4099b -> 85c3d04beb)

2025-05-05 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 7fc0f4099b Bump software.amazon.awssdk:bom from 2.31.34 to 2.31.35 (#15713) add 85c3d04beb Add segment end criter

Re: [PR] Add Table config decorator support [pinot]

2025-05-05 Thread via GitHub
krishna-st commented on code in PR #15714: URL: https://github.com/apache/pinot/pull/15714#discussion_r2074231788 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/TableConfigDecoratorRegistry.java: ## @@ -0,0 +1,79 @@ +/** + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Create proper response when all segments are pruned on broker [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang commented on code in PR #15703: URL: https://github.com/apache/pinot/pull/15703#discussion_r2074222554 ## pinot-common/src/main/java/org/apache/pinot/common/cursors/AbstractResponseStore.java: ## @@ -185,7 +185,7 @@ public CursorResponse handleCursorRequest(String r

Re: [PR] Create proper response when all segments are pruned on broker [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang commented on code in PR #15703: URL: https://github.com/apache/pinot/pull/15703#discussion_r2074221728 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/EmptyResponseUtils.java: ## @@ -0,0 +1,206 @@ +/** + * Licensed to the Apache Software Foundat

Re: [PR] Create proper response when all segments are pruned on broker [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang commented on code in PR #15703: URL: https://github.com/apache/pinot/pull/15703#discussion_r2074217194 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/EmptyResponseUtils.java: ## @@ -0,0 +1,206 @@ +/** + * Licensed to the Apache Software Foundat

Re: [PR] Changes to Enable Pluggable forward Index and Map Index Filter Operator for MAP column [pinot]

2025-05-05 Thread via GitHub
raghavyadav01 commented on code in PR #15526: URL: https://github.com/apache/pinot/pull/15526#discussion_r2074205529 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -411,7 +412,8 @@ private boolean shouldCh

Re: [PR] Create proper response when all segments are pruned on broker [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang commented on code in PR #15703: URL: https://github.com/apache/pinot/pull/15703#discussion_r2074209577 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/EmptyResponseUtils.java: ## @@ -0,0 +1,206 @@ +/** + * Licensed to the Apache Software Foundat

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-05 Thread via GitHub
somandal commented on code in PR #15618: URL: https://github.com/apache/pinot/pull/15618#discussion_r2074200163 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1300,50 +1301,91 @@ private IdealState waitForExternalV

Re: [PR] Create proper response when all segments are pruned on broker [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang commented on code in PR #15703: URL: https://github.com/apache/pinot/pull/15703#discussion_r2074207391 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/EmptyResponseUtils.java: ## @@ -0,0 +1,206 @@ +/** + * Licensed to the Apache Software Foundat

Re: [PR] Add Table config decorator support [pinot]

2025-05-05 Thread via GitHub
codecov-commenter commented on PR #15714: URL: https://github.com/apache/pinot/pull/15714#issuecomment-2852330088 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15714?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Create proper response when all segments are pruned on broker [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang commented on code in PR #15703: URL: https://github.com/apache/pinot/pull/15703#discussion_r2074196840 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ## @@ -1024,25 +1024,49 @@ private static String get

Re: [PR] Changes to Enable Pluggable forward Index and Map Index Filter Operator for MAP column [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang commented on code in PR #15526: URL: https://github.com/apache/pinot/pull/15526#discussion_r2074190174 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/MapIndexFilterOperator.java: ## @@ -0,0 +1,269 @@ +/** + * Licensed to the Apache Software Founda

Re: [PR] Changes to Enable Pluggable forward Index and Map Index Filter Operator for MAP column [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang commented on code in PR #15526: URL: https://github.com/apache/pinot/pull/15526#discussion_r2074190878 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -411,7 +412,8 @@ private boolean shouldCha

Re: [PR] Changes to Enable Pluggable forward Index and Map Index Filter Operator for MAP column [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang commented on code in PR #15526: URL: https://github.com/apache/pinot/pull/15526#discussion_r2074186208 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/forward/ForwardIndexReaderFactory.java: ## @@ -68,10 +68,33 @@ public static Forw

Re: [PR] Allow segment pre-processing failure during segment loading phase [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang commented on code in PR #15672: URL: https://github.com/apache/pinot/pull/15672#discussion_r2074166131 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java: ## @@ -130,7 +130,24 @@ public void process(@Nul

Re: [PR] Dynamic timeout for EV convergence in table rebalance [pinot]

2025-05-05 Thread via GitHub
somandal commented on PR #15618: URL: https://github.com/apache/pinot/pull/15618#issuecomment-2852295027 > > Before this PR, if we set externalViewStabilizationTimeoutInMs=1ms, regular run will fail after 1ms wait, while bestEfforts continue the next step after 1ms. > > In th

Re: [PR] Changes to Enable Pluggable forward Index and Map Index Filter Operator for MAP column [pinot]

2025-05-05 Thread via GitHub
raghavyadav01 commented on code in PR #15526: URL: https://github.com/apache/pinot/pull/15526#discussion_r2074159717 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ## @@ -411,7 +412,8 @@ private boolean shouldCh

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.34 to 2.31.35 [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang merged PR #15713: URL: https://github.com/apache/pinot/pull/15713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.35 deleted (was dbc3a2285b)

2025-05-05 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.35 in repository https://gitbox.apache.org/repos/asf/pinot.git was dbc3a2285b Bump software.amazon.awssdk:bom from 2.31.34 to 2.31.35 The r

Re: [PR] Changes to Enable Pluggable forward Index and Map Index Filter Operator for MAP column [pinot]

2025-05-05 Thread via GitHub
raghavyadav01 commented on code in PR #15526: URL: https://github.com/apache/pinot/pull/15526#discussion_r2074158076 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/forward/ForwardIndexReaderFactory.java: ## @@ -68,10 +68,33 @@ public static For

(pinot) branch dependabot/maven/com.github.luben-zstd-jni-1.5.7-3 deleted (was 1449c53237)

2025-05-05 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.github.luben-zstd-jni-1.5.7-3 in repository https://gitbox.apache.org/repos/asf/pinot.git was 1449c53237 Bump com.github.luben:zstd-jni from 1.5.7-2 to 1.5.7-3 The rev

(pinot) branch master updated: Bump org.checkerframework:checker-qual from 3.49.2 to 3.49.3 (#15711)

2025-05-05 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new c699a3db0c Bump org.checkerframework:checker-qual

(pinot) branch master updated (1fba9ace5b -> 7fc0f4099b)

2025-05-05 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 1fba9ace5b Bump com.github.luben:zstd-jni from 1.5.7-2 to 1.5.7-3 (#15712) add 7fc0f4099b Bump software.amazon.aw

(pinot) branch dependabot/maven/org.checkerframework-checker-qual-3.49.3 deleted (was 4b776ca308)

2025-05-05 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.checkerframework-checker-qual-3.49.3 in repository https://gitbox.apache.org/repos/asf/pinot.git was 4b776ca308 Bump org.checkerframework:checker-qual from 3.49.2 to 3.

Re: [PR] Bump org.checkerframework:checker-qual from 3.49.2 to 3.49.3 [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang merged PR #15711: URL: https://github.com/apache/pinot/pull/15711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (c699a3db0c -> 1fba9ace5b)

2025-05-05 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from c699a3db0c Bump org.checkerframework:checker-qual from 3.49.2 to 3.49.3 (#15711) add 1fba9ace5b Bump com.github.l

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.7-2 to 1.5.7-3 [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang merged PR #15712: URL: https://github.com/apache/pinot/pull/15712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] [timeseries] Add Metadata Provider to Time Series Query Planner [pinot]

2025-05-05 Thread via GitHub
ankitsultana commented on code in PR #15604: URL: https://github.com/apache/pinot/pull/15604#discussion_r2074145355 ## pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/TimeSeriesMetadata.java: ## @@ -0,0 +1,49 @@ +/** + * Licensed to the Apache Softw

Re: [PR] Changes to Enable Pluggable forward Index and Map Index Filter Operator for MAP column [pinot]

2025-05-05 Thread via GitHub
raghavyadav01 commented on code in PR #15526: URL: https://github.com/apache/pinot/pull/15526#discussion_r2074141235 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/MapIndexFilterOperator.java: ## @@ -0,0 +1,269 @@ +/** + * Licensed to the Apache Software Found

Re: [PR] Add Table config decorator support [pinot]

2025-05-05 Thread via GitHub
Jackie-Jiang commented on code in PR #15714: URL: https://github.com/apache/pinot/pull/15714#discussion_r2074135826 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/TableConfigDecoratorRegistry.java: ## @@ -0,0 +1,79 @@ +/** + * Licensed to the Apache Software Foundation (A

Re: [PR] Pass Table Config to timeSeries Plugin to use in logical plan phase. [pinot]

2025-05-05 Thread via GitHub
raghavyadav01 commented on code in PR #15604: URL: https://github.com/apache/pinot/pull/15604#discussion_r2074109868 ## pinot-common/src/main/java/org/apache/pinot/common/config/provider/TableCache.java: ## @@ -204,6 +204,17 @@ public TableConfig getTableConfig(String tableName

Re: [PR] Pass Table Config to timeSeries Plugin to use in logical plan phase. [pinot]

2025-05-05 Thread via GitHub
ankitsultana commented on code in PR #15604: URL: https://github.com/apache/pinot/pull/15604#discussion_r2074099495 ## pinot-common/src/main/java/org/apache/pinot/common/config/provider/TableCache.java: ## @@ -204,6 +204,17 @@ public TableConfig getTableConfig(String tableNameW

[PR] Add Table config decorator support [pinot]

2025-05-05 Thread via GitHub
krishna-st opened a new pull request, #15714: URL: https://github.com/apache/pinot/pull/15714 ## Introduce TableConfig Decorator This PR introduces a decorator pattern for `TableConfig` objects, providing a pluggable way to alter or augment table configurations. **Changes:**

Re: [PR] Changes to Enable Pluggable forward Index and Map Index Filter Operator for MAP column [pinot]

2025-05-05 Thread via GitHub
raghavyadav01 commented on code in PR #15526: URL: https://github.com/apache/pinot/pull/15526#discussion_r2074088607 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/map/MutableMapDataSource.java: ## @@ -55,15 +55,13 @@ public MutableMapDataSourc

Re: [PR] Changes to Enable Pluggable forward Index and Map Index Filter Operator for MAP column [pinot]

2025-05-05 Thread via GitHub
raghavyadav01 commented on code in PR #15526: URL: https://github.com/apache/pinot/pull/15526#discussion_r2074081298 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/MapIndexFilterOperator.java: ## @@ -0,0 +1,269 @@ +/** + * Licensed to the Apache Software Found

Re: [PR] Changes to Enable Pluggable forward Index and Map Index Filter Operator for MAP column [pinot]

2025-05-05 Thread via GitHub
raghavyadav01 commented on code in PR #15526: URL: https://github.com/apache/pinot/pull/15526#discussion_r2074077955 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/MapIndexFilterOperator.java: ## @@ -0,0 +1,269 @@ +/** + * Licensed to the Apache Software Found

Re: [PR] Changes to Enable Pluggable forward Index and Map Index Filter Operator for MAP column [pinot]

2025-05-05 Thread via GitHub
raghavyadav01 commented on code in PR #15526: URL: https://github.com/apache/pinot/pull/15526#discussion_r2074074994 ## pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java: ## @@ -238,6 +248,8 @@ private BaseFilterOperator constructPhysicalOperator(FilterCon

Re: [PR] Pass Table Config to timeSeries Plugin to use in logical plan phase. [pinot]

2025-05-05 Thread via GitHub
raghavyadav01 commented on code in PR #15604: URL: https://github.com/apache/pinot/pull/15604#discussion_r2074023914 ## pinot-plugins/pinot-timeseries-lang/pinot-timeseries-m3ql/src/main/java/org/apache/pinot/tsdb/m3ql/M3TimeSeriesPlanner.java: ## @@ -48,7 +49,7 @@ public void i

Re: [I] [feature] Read each object in root Array as an single message. [pinot]

2025-05-05 Thread via GitHub
felpasl commented on issue #14607: URL: https://github.com/apache/pinot/issues/14607#issuecomment-2852016268 Any update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [multistage] Support Physical Optimizer E2E [pinot]

2025-05-05 Thread via GitHub
ankitsultana commented on PR #15698: URL: https://github.com/apache/pinot/pull/15698#issuecomment-2851433403 @gortiz : thanks for sharing. I'll raise another one after this to address this. As for the cleanup, I wanted to make a change which explicitly tracks whether the QueryEnvironment us

Re: [PR] MSE support for case-insensitiveness without breaking compatibility [pinot]

2025-05-05 Thread via GitHub
albertobastos commented on code in PR #15692: URL: https://github.com/apache/pinot/pull/15692#discussion_r2072886315 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -124,15 +132,10 @@ public QueryEnvironment(Config config) { String d

Re: [PR] [multistage] Support Physical Optimizer E2E [pinot]

2025-05-05 Thread via GitHub
gortiz commented on PR #15698: URL: https://github.com/apache/pinot/pull/15698#issuecomment-2851204742 > The current QueryEnvironment I feel is quite bloated and I know several folks have also raised this. For now I have added the requestId to QueryEnvironment#Config. This eliminates passin

Re: [PR] Create proper response when all segments are pruned on broker [pinot]

2025-05-05 Thread via GitHub
gortiz commented on code in PR #15703: URL: https://github.com/apache/pinot/pull/15703#discussion_r2073534552 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/EmptyResponseUtils.java: ## @@ -0,0 +1,206 @@ +/** + * Licensed to the Apache Software Foundation (A

(pinot) branch master updated: Include stats on cancel (#15609)

2025-05-05 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 4d423555fc Include stats on cancel (#15609) 4d423

Re: [PR] Include stats on cancel [pinot]

2025-05-05 Thread via GitHub
gortiz merged PR #15609: URL: https://github.com/apache/pinot/pull/15609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

Re: [PR] Fail the config file reading if there are duplicated keys in the file [pinot]

2025-05-05 Thread via GitHub
xiangfu0 commented on PR #15648: URL: https://github.com/apache/pinot/pull/15648#issuecomment-2850973104 > > > I think duplicate key is the standard way of configuring array in `configuration2` to avoid problem of escaping special character. Please make sure the change is backward compatibl

Re: [PR] Allow segment pre-processing failure during segment loading phase [pinot]

2025-05-05 Thread via GitHub
xiangfu0 commented on code in PR #15672: URL: https://github.com/apache/pinot/pull/15672#discussion_r2073422374 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java: ## @@ -130,7 +130,24 @@ public void process(@Nullabl

Re: [PR] Include stats on cancel [pinot]

2025-05-05 Thread via GitHub
gortiz commented on PR #15609: URL: https://github.com/apache/pinot/pull/15609#issuecomment-2850946220 I've applied some last minute changes, including a new option to configure whether opchains should be kept or not when they finish successfully. By default, we will not keep them. This kee

Re: [PR] Include stats on cancel [pinot]

2025-05-05 Thread via GitHub
gortiz commented on code in PR #15609: URL: https://github.com/apache/pinot/pull/15609#discussion_r2073370059 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -1577,6 +1576,18 @@ public static class PlanVersions { public static final String

Re: [PR] Include stats on cancel [pinot]

2025-05-05 Thread via GitHub
gortiz commented on code in PR #15609: URL: https://github.com/apache/pinot/pull/15609#discussion_r2073370059 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -1577,6 +1576,18 @@ public static class PlanVersions { public static final String

Re: [PR] Include stats on cancel [pinot]

2025-05-05 Thread via GitHub
gortiz commented on code in PR #15609: URL: https://github.com/apache/pinot/pull/15609#discussion_r2073370059 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -1577,6 +1576,18 @@ public static class PlanVersions { public static final String

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.35 created (now dbc3a2285b)

2025-05-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.35 in repository https://gitbox.apache.org/repos/asf/pinot.git at dbc3a2285b Bump software.amazon.awssdk:bom from 2.31.34 to 2.31.35 N

[PR] Bump software.amazon.awssdk:bom from 2.31.34 to 2.31.35 [pinot]

2025-05-05 Thread via GitHub
dependabot[bot] opened a new pull request, #15713: URL: https://github.com/apache/pinot/pull/15713 Bumps software.amazon.awssdk:bom from 2.31.34 to 2.31.35. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- |

[PR] Bump com.github.luben:zstd-jni from 1.5.7-2 to 1.5.7-3 [pinot]

2025-05-05 Thread via GitHub
dependabot[bot] opened a new pull request, #15712: URL: https://github.com/apache/pinot/pull/15712 Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from 1.5.7-2 to 1.5.7-3. Commits https://github.com/luben/zstd-jni/commit/6fa4427bdcad2bb93319f9b2e70e296692a9

(pinot) branch dependabot/maven/com.github.luben-zstd-jni-1.5.7-3 created (now 1449c53237)

2025-05-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.github.luben-zstd-jni-1.5.7-3 in repository https://gitbox.apache.org/repos/asf/pinot.git at 1449c53237 Bump com.github.luben:zstd-jni from 1.5.7-2 to 1.5.7-3 No

[PR] Bump org.checkerframework:checker-qual from 3.49.2 to 3.49.3 [pinot]

2025-05-05 Thread via GitHub
dependabot[bot] opened a new pull request, #15711: URL: https://github.com/apache/pinot/pull/15711 Bumps [org.checkerframework:checker-qual](https://github.com/typetools/checker-framework) from 3.49.2 to 3.49.3. Release notes Sourced from https://github.com/typetools/checker-frame

(pinot) branch dependabot/maven/org.checkerframework-checker-qual-3.49.3 created (now 4b776ca308)

2025-05-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.checkerframework-checker-qual-3.49.3 in repository https://gitbox.apache.org/repos/asf/pinot.git at 4b776ca308 Bump org.checkerframework:checker-qual from 3.49.2 t

Re: [PR] Reduce segment metadata memory overhead. [pinot]

2025-05-05 Thread via GitHub
bziobrowski commented on code in PR #15591: URL: https://github.com/apache/pinot/pull/15591#discussion_r2073283552 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BigNumberOfSegmentsIntegrationTest.java: ## @@ -0,0 +1,266 @@ +/** + * Licensed to the A

Re: [PR] Improve byte-based gRPC block splitting [pinot]

2025-05-05 Thread via GitHub
albertobastos commented on code in PR #15694: URL: https://github.com/apache/pinot/pull/15694#discussion_r2073224386 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineSmallBufferTest.java: ## @@ -0,0 +1,181 @@ +/** + * Licensed to the Ap

Re: [PR] Logical table CRUD operations. [pinot]

2025-05-05 Thread via GitHub
vrajat commented on code in PR #15515: URL: https://github.com/apache/pinot/pull/15515#discussion_r2073213535 ## pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotLogicalTableResourceTest.java: ## @@ -0,0 +1,309 @@ +/** + * Licensed to the Apache Soft

Re: [PR] Retry postStopConsumedMsg for segment init errors [pinot]

2025-05-05 Thread via GitHub
noob-se7en commented on PR #15652: URL: https://github.com/apache/pinot/pull/15652#issuecomment-2850523062 > We do have RealtimeSegmentValidationManager._segmentAutoResetOnErrorAtValidation Its kept behind a controller flag. Should we make it a default behaviour? I asked in that PR:

Re: [PR] Improve byte-based gRPC block splitting [pinot]

2025-05-05 Thread via GitHub
gortiz commented on code in PR #15694: URL: https://github.com/apache/pinot/pull/15694#discussion_r2073162113 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java: ## @@ -319,4 +277,75 @@ static List toByteStrings(List bytes, int maxByteSt

Re: [PR] Improve byte-based gRPC block splitting [pinot]

2025-05-05 Thread via GitHub
gortiz commented on code in PR #15694: URL: https://github.com/apache/pinot/pull/15694#discussion_r2073158585 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java: ## @@ -319,4 +279,78 @@ static List toByteStrings(List bytes, int maxByteSt

Re: [PR] Improve byte-based gRPC block splitting [pinot]

2025-05-05 Thread via GitHub
gortiz commented on code in PR #15694: URL: https://github.com/apache/pinot/pull/15694#discussion_r2073155621 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineSmallBufferTest.java: ## @@ -0,0 +1,181 @@ +/** + * Licensed to the Apache So

Re: [PR] Improve byte-based gRPC block splitting [pinot]

2025-05-05 Thread via GitHub
gortiz commented on code in PR #15694: URL: https://github.com/apache/pinot/pull/15694#discussion_r2073152119 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineSmallBufferTest.java: ## @@ -0,0 +1,181 @@ +/** + * Licensed to the Apache So

Re: [PR] Improve byte-based gRPC block splitting [pinot]

2025-05-05 Thread via GitHub
albertobastos commented on code in PR #15694: URL: https://github.com/apache/pinot/pull/15694#discussion_r2073031413 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineSmallBufferTest.java: ## @@ -0,0 +1,181 @@ +/** + * Licensed to the Ap

Re: [PR] Improve byte-based gRPC block splitting [pinot]

2025-05-05 Thread via GitHub
gortiz commented on code in PR #15694: URL: https://github.com/apache/pinot/pull/15694#discussion_r2073024147 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java: ## @@ -67,28 +66,22 @@ public class GrpcSendingMailbox implements SendingMai

Re: [PR] Improve byte-based gRPC block splitting [pinot]

2025-05-05 Thread via GitHub
gortiz commented on code in PR #15694: URL: https://github.com/apache/pinot/pull/15694#discussion_r2073023266 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java: ## @@ -67,28 +66,22 @@ public class GrpcSendingMailbox implements SendingMai

Re: [PR] Improve byte-based gRPC block splitting [pinot]

2025-05-05 Thread via GitHub
gortiz commented on code in PR #15694: URL: https://github.com/apache/pinot/pull/15694#discussion_r2073022060 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java: ## @@ -319,4 +279,78 @@ static List toByteStrings(List bytes, int maxByteSt

  1   2   >