Jackie-Jiang commented on code in PR #15526:
URL: https://github.com/apache/pinot/pull/15526#discussion_r2074190878
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java:
##########
@@ -411,7 +412,8 @@ private boolean shouldChangeDictIdCompressionType(String
column, SegmentDirector
// The compression type for an existing segment can only be determined by
reading the forward index header.
ColumnMetadata existingColMetadata =
_segmentDirectory.getSegmentMetadata().getColumnMetadataFor(column);
DictIdCompressionType existingCompressionType;
- try (ForwardIndexReader<?> fwdIndexReader =
ForwardIndexType.read(segmentReader, existingColMetadata)) {
+ try (ForwardIndexReader<?> fwdIndexReader =
ForwardIndexType.read(segmentReader, _fieldIndexConfigs.get(column),
Review Comment:
I don't follow. Can you provide more context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
