noob-se7en commented on PR #15652: URL: https://github.com/apache/pinot/pull/15652#issuecomment-2850523062
> We do have RealtimeSegmentValidationManager._segmentAutoResetOnErrorAtValidation Its kept behind a controller flag. Should we make it a default behaviour? I asked in that PR: https://github.com/apache/pinot/pull/14217#issuecomment-2839693930 If we can make autoResetOnError a default behaviour then probably we can skip this PR's change. Ideally I wanted to do following for these problems in sequence: 1. First make behaviour consistent for all errors faced while consumption or during handling of offline -> consuming transition (This PR is doing this). Or We can skip this PR and make segmentAutoResetOnError default. 2. Remove segmentStoppedConsumed logic so that server does not rely on controller anymore and system can self recover. Need to consider side effects of this though and make it backward compatible. > What will happen for non-pauseless case when the segment is reset to CONSUMING before server sends the stop consumed message? This should be rare. The controller will make segment offline on receiving stop consumed message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
