Jackie-Jiang commented on code in PR #15673:
URL: https://github.com/apache/pinot/pull/15673#discussion_r2074294144
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotTableIdealStateBuilder.java:
##########
@@ -96,9 +98,15 @@ public static List<PartitionGroupMetadata>
getPartitionGroupMetadataList(List<St
return partitionGroupMetadataFetcher.getPartitionGroupMetadataList();
} catch (Exception e) {
Exception fetcherException =
partitionGroupMetadataFetcher.getException();
+ String tableNameWithType = streamConfigs.get(0).getTableNameWithType();
LOGGER.error("Could not get PartitionGroupMetadata for topic: {} of
table: {}",
streamConfigs.stream().map(streamConfig ->
streamConfig.getTopicName()).reduce((a, b) -> a + "," + b),
- streamConfigs.get(0).getTableNameWithType(), fetcherException);
+ tableNameWithType, fetcherException);
+ ControllerMetrics controllerMetrics = ControllerMetrics.get();
+ if (controllerMetrics != null) {
Review Comment:
(nit) This check is redundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
