xiangfu0 commented on PR #15648: URL: https://github.com/apache/pinot/pull/15648#issuecomment-2850973104
> > > I think duplicate key is the standard way of configuring array in `configuration2` to avoid problem of escaping special character. Please make sure the change is backward compatible > > > > > > Yes, the question here is: > > > > 1. Is this feature ever used? > > 2. Seems we saw more problems than the benefits for this feature. > > 3. Regarding escaping special characters, which config is using it maybe we can make a special handling for that. > > I think this is the default behavior for `configuration2`. Given the tests are passing, do we have any array field in our config? I modify the tests and also for now I only make it apply for the ServiceStartable configs. Metadata properties is still using the current behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
